summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZephyron <zephyron@citron-emu.org>2025-01-02 16:38:18 +1000
committerZephyron <zephyron@citron-emu.org>2025-01-02 16:38:18 +1000
commit1cbcd142fa3d058891eb71ea3cd295f9c9cff81d (patch)
tree90ce47d05784224edecc9164a8be0f7f0d0a786b
parent749d083197afaa30ad3130eea31672d1b95ae216 (diff)
video_core: Enforce safe memory reads for compute dispatch
- Modify DmaPusher to use safe memory reads when handling compute operations at High GPU accuracy - Prevent potential memory corruption issues that could lead to invalid dispatch parameters - Previously, unsafe reads could result in corrupted launch_description data in KeplerCompute::ProcessLaunch, causing invalid vkCmdDispatch calls - By enforcing safe reads specifically for compute operations, we maintain performance for other GPU tasks while ensuring compute dispatch stability This change requires >= High GPU accuracy level to take effect.
-rw-r--r--src/video_core/dma_pusher.cpp15
1 files changed, 9 insertions, 6 deletions
diff --git a/src/video_core/dma_pusher.cpp b/src/video_core/dma_pusher.cpp
index 7dc4d5855..57210882d 100644
--- a/src/video_core/dma_pusher.cpp
+++ b/src/video_core/dma_pusher.cpp
@@ -98,19 +98,22 @@ bool DmaPusher::Step() {
&command_headers);
ProcessCommands(headers);
};
+
+ // Only use unsafe reads for non-compute macro operations
if (Settings::IsGPULevelHigh()) {
- if (dma_state.method >= MacroRegistersStart) {
- unsafe_process();
- return true;
- }
- if (subchannel_type[dma_state.subchannel] == Engines::EngineTypes::KeplerCompute &&
- dma_state.method == ComputeInline) {
+ const bool is_compute = (subchannel_type[dma_state.subchannel] ==
+ Engines::EngineTypes::KeplerCompute);
+
+ if (dma_state.method >= MacroRegistersStart && !is_compute) {
unsafe_process();
return true;
}
+
+ // Always use safe reads for compute operations
safe_process();
return true;
}
+
unsafe_process();
}
return true;