diff options
| author | Lioncash <mathew1800@gmail.com> | 2018-07-29 06:13:10 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2018-07-29 06:16:59 -0400 |
| commit | 57c4d7aa007ba41029bd10c64b860d301d83b14f (patch) | |
| tree | a1f76fc0ecc1dcf35fb878cf406553d59d93d6e1 | |
| parent | 458fdda7005f5c84dad652792254260b01a1f389 (diff) | |
partition_filesystem: Remove dynamic_cast in PrintDebugInfo()
We shouldn't be upcasting our file instances. Given a
PartitionFilesystem is currently designed to accept any arbitrary
VfsFile instances, casting to a more specific type than that is just bad
design, and shows an interface design issue.
| -rw-r--r-- | src/core/file_sys/partition_filesystem.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/core/file_sys/partition_filesystem.cpp b/src/core/file_sys/partition_filesystem.cpp index 521e21078..47e032b19 100644 --- a/src/core/file_sys/partition_filesystem.cpp +++ b/src/core/file_sys/partition_filesystem.cpp @@ -97,9 +97,8 @@ void PartitionFilesystem::PrintDebugInfo() const { LOG_DEBUG(Service_FS, "Magic: {:.4}", pfs_header.magic); LOG_DEBUG(Service_FS, "Files: {}", pfs_header.num_entries); for (u32 i = 0; i < pfs_header.num_entries; i++) { - LOG_DEBUG(Service_FS, " > File {}: {} (0x{:X} bytes, at 0x{:X})", i, - pfs_files[i]->GetName(), pfs_files[i]->GetSize(), - dynamic_cast<OffsetVfsFile*>(pfs_files[i].get())->GetOffset()); + LOG_DEBUG(Service_FS, " > File {}: {} (0x{:X} bytes)", i, + pfs_files[i]->GetName(), pfs_files[i]->GetSize()); } } |