summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLioncash <mathew1800@gmail.com>2019-06-05 15:47:42 -0400
committerLioncash <mathew1800@gmail.com>2019-06-05 15:49:23 -0400
commit5b932901834b4d81d414b1845e2977a58984ecab (patch)
treee66a1775c2c4c23191896e2036abb46b26e38a19
parentb5e1e879229ca37332a73186924738b77181f666 (diff)
yuzu/CMakeLists: Disable unsafe overloads of QProcess' start() function
Other overloads of start() are considerably much safer to use if we ever need this in the future and need to pass arguments to the program, given it contains separate parameters for the program path and the arguments themselves, whereas this unsafe overload contains both as a single string. Given the alternatives are much safer, we can disable this.
-rw-r--r--src/yuzu/CMakeLists.txt3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/yuzu/CMakeLists.txt b/src/yuzu/CMakeLists.txt
index ec969a9a7..37394be37 100644
--- a/src/yuzu/CMakeLists.txt
+++ b/src/yuzu/CMakeLists.txt
@@ -162,6 +162,9 @@ target_compile_definitions(yuzu PRIVATE
# Disable implicit type narrowing in signal/slot connect() calls.
-DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT
+
+ # Disable unsafe overloads of QProcess' start() function.
+ -DQT_NO_PROCESS_COMBINED_ARGUMENT_START
)
if (YUZU_ENABLE_COMPATIBILITY_REPORTING)