diff options
| author | lat9nq <lat9nq@gmail.com> | 2022-04-23 02:56:58 -0400 |
|---|---|---|
| committer | lat9nq <lat9nq@gmail.com> | 2022-04-23 03:07:12 -0400 |
| commit | a63244d1e481ab9f816e11815b178b42b56f1fb8 (patch) | |
| tree | a3657fd6e3dcdfc0dd5b3a2b328fcd7a68d0dd86 | |
| parent | 749efbb84b67043fb3aa1ce7832bf798bf393b59 (diff) | |
CMakeLists: Revert ad55faaa3
The premise behind ad55faaa3 was due to an issue between Conan's
libiconv package and compiling SDL2 from our externals. Since none of
our Conan externals require libiconv any longer, though, we can remove
downloading our own Boost package and just rely on Conan again.
Additionally, removing CONFIG from the find_package(boost) call fixes
issues with finding Boost on Fedora and MSYS2, which was the main
motivation for this.
Also, remove QUIET since if something goes wrong finding Boost, this
makes it harder to tell what went wrong.
| -rw-r--r-- | CMakeLists.txt | 20 |
1 files changed, 1 insertions, 19 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 11a459813..caeb2ab8e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -21,8 +21,6 @@ CMAKE_DEPENDENT_OPTION(YUZU_USE_BUNDLED_QT "Download bundled Qt binaries" "${MSV option(ENABLE_WEB_SERVICE "Enable web services (telemetry, etc.)" ON) -option(YUZU_USE_BUNDLED_BOOST "Download bundled Boost" OFF) - option(YUZU_USE_BUNDLED_LIBUSB "Compile bundled libusb" OFF) option(YUZU_USE_BUNDLED_FFMPEG "Download/Build bundled FFmpeg" "${WIN32}") @@ -208,9 +206,7 @@ macro(yuzu_find_packages) unset(FN_FORCE_REQUIRED) endmacro() -if (NOT YUZU_USE_BUNDLED_BOOST) - find_package(Boost 1.73.0 CONFIG COMPONENTS context headers QUIET) -endif() +find_package(Boost 1.73.0 COMPONENTS context headers) if (Boost_FOUND) set(Boost_LIBRARIES Boost::boost) # Conditionally add Boost::context only if the active version of the Conan or system Boost package provides it @@ -221,20 +217,6 @@ if (Boost_FOUND) if (TARGET Boost::context) list(APPEND Boost_LIBRARIES Boost::context) endif() -elseif (${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR YUZU_USE_BUNDLED_BOOST) - message(STATUS "Boost 1.73.0 or newer not found, falling back to externals") - set(YUZU_USE_BUNDLED_BOOST ON CACHE BOOL "Download bundled Boost" FORCE) - - # Use yuzu Boost binaries - set(Boost_EXT_NAME "boost_1_75_0") - set(Boost_PATH "${CMAKE_BINARY_DIR}/externals/${Boost_EXT_NAME}") - download_bundled_external("boost/" ${Boost_EXT_NAME} "") - set(Boost_USE_DEBUG_RUNTIME FALSE) - set(Boost_USE_STATIC_LIBS ON) - find_package(Boost 1.75.0 CONFIG REQUIRED COMPONENTS context headers PATHS ${Boost_PATH} NO_DEFAULT_PATH) - # Manually set the include dirs since the find_package sets it incorrectly - set(Boost_INCLUDE_DIRS ${Boost_PATH}/include CACHE PATH "Path to Boost headers" FORCE) - include_directories(SYSTEM "${Boost_INCLUDE_DIRS}") else() message(STATUS "Boost 1.73.0 or newer not found, falling back to Conan") list(APPEND CONAN_REQUIRED_LIBS "boost/1.78.0") |