diff options
author | Salvage <29021710+Saalvage@users.noreply.github.com> | 2022-12-09 13:41:04 +0100 |
---|---|---|
committer | Salvage <29021710+Saalvage@users.noreply.github.com> | 2022-12-09 16:39:59 +0100 |
commit | c586ac9be2edea86889b44d44cede599a0c4dba5 (patch) | |
tree | 1f6426d0fa21acd1eaacd42ecbc130d002591b6a | |
parent | 41461514d6f3ba59dc027dbc4a88c0ffb570ea49 (diff) |
Remove the lock entirely as per PR discussion
Correctly unlock mutex before its destruction
As per https://en.cppreference.com/w/cpp/thread/mutex/~mutex destroying a locked mutex is undefined behavior and MSVC++ decides to throw in this case
Swap out unique for scoped lock and readd comment
-rw-r--r-- | src/core/hle/kernel/service_thread.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/core/hle/kernel/service_thread.cpp b/src/core/hle/kernel/service_thread.cpp index e72c3d35d..38afa720b 100644 --- a/src/core/hle/kernel/service_thread.cpp +++ b/src/core/hle/kernel/service_thread.cpp @@ -163,9 +163,6 @@ ServiceThread::Impl::~Impl() { m_wakeup_event->Signal(); m_host_thread.join(); - // Lock mutex. - m_session_mutex.lock(); - // Close all remaining sessions. for (const auto& [server_session, manager] : m_sessions) { server_session->Close(); |