summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNarr the Reg <juangerman-13@hotmail.com>2023-09-17 14:27:44 -0600
committerGitHub <noreply@github.com>2023-09-17 14:27:44 -0600
commite18ff5cb4e1495ee700486e7b1a7d15bc3a1d6af (patch)
tree49b2f189ca12a0b65169794ddd072f4cb1a734ff
parent2fe92436b9433230391f7fa1d4835ddbf3ee0d62 (diff)
parent77682aabd3a8c4dbda3dd20421a5dea16b6ef86d (diff)
Merge pull request #11529 from lat9nq/no-oob-names-pls
mii_types: Remove null terminator check
-rw-r--r--src/core/hle/service/mii/mii_types.h5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/core/hle/service/mii/mii_types.h b/src/core/hle/service/mii/mii_types.h
index 95476f745..611ff4f81 100644
--- a/src/core/hle/service/mii/mii_types.h
+++ b/src/core/hle/service/mii/mii_types.h
@@ -606,15 +606,12 @@ struct Nickname {
static constexpr std::size_t MaxNameSize = 10;
std::array<char16_t, MaxNameSize> data;
- // Checks for null, non-zero terminated or dirty strings
+ // Checks for null or dirty strings
bool IsValid() const {
if (data[0] == 0) {
return false;
}
- if (data[MaxNameSize] != 0) {
- return false;
- }
std::size_t index = 1;
while (data[index] != 0) {
index++;