summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReinUsesLisp <reinuseslisp@airmail.cc>2019-03-08 04:06:54 -0300
committerReinUsesLisp <reinuseslisp@airmail.cc>2019-03-08 04:06:54 -0300
commite7ac5a6adf397b64d4ca3f29726c44c77faa3558 (patch)
treed5e840c8756ca5270e54bf66bcbe328c04be2c5a
parentd26ee6e01ea02ca525d5032656563b11d6c3d28a (diff)
dma_pusher: Store command_list_header by copy
Instead of holding a reference that will get invalidated by dma_pushbuffer.pop(), hold it as a copy. This doesn't have any performance cost since CommandListHeader is 8 bytes long.
-rw-r--r--src/video_core/dma_pusher.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/video_core/dma_pusher.cpp b/src/video_core/dma_pusher.cpp
index 669541b4b..bff1a37ff 100644
--- a/src/video_core/dma_pusher.cpp
+++ b/src/video_core/dma_pusher.cpp
@@ -39,7 +39,7 @@ bool DmaPusher::Step() {
}
const CommandList& command_list{dma_pushbuffer.front()};
- const CommandListHeader& command_list_header{command_list[dma_pushbuffer_subindex++]};
+ const CommandListHeader command_list_header{command_list[dma_pushbuffer_subindex++]};
GPUVAddr dma_get = command_list_header.addr;
GPUVAddr dma_put = dma_get + command_list_header.size * sizeof(u32);
bool non_main = command_list_header.is_non_main;