diff options
| author | lat9nq <22451773+lat9nq@users.noreply.github.com> | 2021-07-30 16:12:15 -0400 |
|---|---|---|
| committer | lat9nq <22451773+lat9nq@users.noreply.github.com> | 2021-07-30 18:44:50 -0400 |
| commit | e9cf08c2411197860330f77650a9aaac586b9725 (patch) | |
| tree | 50cb3be85ffd9732e06d2b38be12442006203d7f | |
| parent | 7737bdfd1ac2868397b94ba26a9ccf06ea1dfcba (diff) | |
settings: Remove unnecessary std::move usages
Addresses review feedback.
Co-authored-by: Mai M. <mathew1800@gmail.com>
| -rw-r--r-- | src/common/settings.h | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/src/common/settings.h b/src/common/settings.h index f54705a96..4432b5ddd 100644 --- a/src/common/settings.h +++ b/src/common/settings.h @@ -170,11 +170,11 @@ public: void SetValue(const Type& value) override { Type temp; if (value < minimum) { - temp = std::move(minimum); + temp = minimum; } else if (value > maximum) { - temp = std::move(maximum); + temp = maximum; } else { - temp = std::move(value); + temp = value; } std::swap(this->global, temp); } @@ -188,11 +188,11 @@ public: const Type& operator=(const Type& value) override { Type temp; if (value < minimum) { - temp = std::move(minimum); + temp = minimum; } else if (value > maximum) { - temp = std::move(maximum); + temp = maximum; } else { - temp = std::move(value); + temp = value; } std::swap(this->global, temp); return this->global; @@ -344,11 +344,11 @@ public: void SetValue(const Type& value) override { Type temp; if (value < this->minimum) { - temp = std::move(this->minimum); + temp = this->minimum; } else if (value > this->maximum) { - temp = std::move(this->maximum); + temp = this->maximum; } else { - temp = std::move(value); + temp = value; } if (this->use_global) { std::swap(this->global, temp); @@ -367,11 +367,11 @@ public: const Type& operator=(const Type& value) override { Type temp; if (value < this->minimum) { - temp = std::move(this->minimum); + temp = this->minimum; } else if (value > this->maximum) { - temp = std::move(this->maximum); + temp = this->maximum; } else { - temp = std::move(value); + temp = value; } if (this->use_global) { std::swap(this->global, temp); |