diff options
| author | bunnei <bunneidev@gmail.com> | 2022-09-23 22:40:30 -0700 | 
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-23 22:40:30 -0700 | 
| commit | 1b1b99fbd5b1c2fbe4a99c90f5bf73b4502e7c9e (patch) | |
| tree | 324d371a8a8ecedb7f24b147415e11e81f7e7065 /src/audio_core/sink | |
| parent | d794ced30328cf347f2dbacb9444bbe0a3b22a32 (diff) | |
| parent | 56b8a9ba6edc6f2225166cad6668dec0c059d706 (diff) | |
Merge pull request #8941 from Kelebek1/single_core_sucks
Do not try to pause core timing from the audio thread when using single-core
Diffstat (limited to 'src/audio_core/sink')
| -rw-r--r-- | src/audio_core/sink/sink_stream.cpp | 9 | 
1 files changed, 7 insertions, 2 deletions
diff --git a/src/audio_core/sink/sink_stream.cpp b/src/audio_core/sink/sink_stream.cpp index 37fe725e4..849f862b0 100644 --- a/src/audio_core/sink/sink_stream.cpp +++ b/src/audio_core/sink/sink_stream.cpp @@ -214,8 +214,13 @@ void SinkStream::ProcessAudioOutAndRender(std::span<s16> output_buffer, std::siz      // video play out without attempting to stall.      // Can hopefully remove this later with a more complete NVDEC implementation.      const auto nvdec_active{system.AudioCore().IsNVDECActive()}; -    if (!nvdec_active && queued_buffers > max_queue_size) { + +    // Core timing cannot be paused in single-core mode, so Stall ends up being called over and over +    // and never recovers to a normal state, so just skip attempting to sync things on single-core. +    if (system.IsMulticore() && !nvdec_active && queued_buffers > max_queue_size) {          Stall(); +    } else if (system.IsMulticore() && queued_buffers <= max_queue_size) { +        Unstall();      }      while (frames_written < num_frames) { @@ -255,7 +260,7 @@ void SinkStream::ProcessAudioOutAndRender(std::span<s16> output_buffer, std::siz      std::memcpy(&last_frame[0], &output_buffer[(frames_written - 1) * frame_size],                  frame_size_bytes); -    if (stalled && queued_buffers <= max_queue_size) { +    if (system.IsMulticore() && queued_buffers <= max_queue_size) {          Unstall();      }  }  | 
