diff options
| author | Lioncash <mathew1800@gmail.com> | 2020-10-29 23:30:42 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2020-10-30 00:13:21 -0400 |
| commit | 26547d3e3be403047445fd39e671d7ef3b88dabb (patch) | |
| tree | 2189a7d0f6eb01a30a16ce2137bb952a0a854fea /src/common/file_util.h | |
| parent | 7dcf4c00180c4e8b9342042ce9860bf5fc576dc2 (diff) | |
General: Make ignoring a discarded return value an error
Allows our CI to catch more potential bugs. This also removes the
[[nodiscard]] attribute of IOFile's Open member function. There are
cases where a file may want to be opened, but have the status of it
checked at a later time.
Diffstat (limited to 'src/common/file_util.h')
| -rw-r--r-- | src/common/file_util.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/file_util.h b/src/common/file_util.h index 8b587320f..840cde2a6 100644 --- a/src/common/file_util.h +++ b/src/common/file_util.h @@ -232,7 +232,7 @@ public: void Swap(IOFile& other) noexcept; - [[nodiscard]] bool Open(const std::string& filename, const char openmode[], int flags = 0); + bool Open(const std::string& filename, const char openmode[], int flags = 0); bool Close(); template <typename T> |