summaryrefslogtreecommitdiff
path: root/src/common/fs
diff options
context:
space:
mode:
authorlat9nq <lat9nq@gmail.com>2022-05-26 18:49:18 -0400
committerlat9nq <lat9nq@gmail.com>2022-05-26 19:01:26 -0400
commit0e5a6676c325b2183904643a42ce7593b36e0d8c (patch)
treeb3bf6795af3bc9d7c7855c1307932cdb7bf1dcba /src/common/fs
parenta9beb4746e423e976323fa3866702e0fc977d543 (diff)
path_util: Resolve `-Wpointer-bool-conversion` warning
Clang (rightfully) warns that we are checking for the existence of pointer to something just allocated on the stack, which is always true. Instead, check whether GetModuleFileNameW failed. Co-authored-by: Mai M <mathew1800@gmail.com>
Diffstat (limited to 'src/common/fs')
-rw-r--r--src/common/fs/path_util.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/common/fs/path_util.cpp b/src/common/fs/path_util.cpp
index 62318e70c..1074f2421 100644
--- a/src/common/fs/path_util.cpp
+++ b/src/common/fs/path_util.cpp
@@ -232,9 +232,7 @@ void SetYuzuPath(YuzuPath yuzu_path, const fs::path& new_path) {
fs::path GetExeDirectory() {
wchar_t exe_path[MAX_PATH];
- GetModuleFileNameW(nullptr, exe_path, MAX_PATH);
-
- if (!exe_path) {
+ if (GetModuleFileNameW(nullptr, exe_path, MAX_PATH) == 0) {
LOG_ERROR(Common_Filesystem,
"Failed to get the path to the executable of the current process");
}