diff options
| author | bunnei <bunneidev@gmail.com> | 2020-08-16 01:47:54 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-16 01:47:54 -0400 |
| commit | db96034ea429cf0b0b5e2bac790392d9e2f50990 (patch) | |
| tree | 9a1ed0bfc2d01d67d0f62383dbb2a1f4c9fb4eca /src/common/lz4_compression.h | |
| parent | 404362e1b070960cdc2c600ca206c2b792d8a880 (diff) | |
| parent | 1ee060ca0dfae7d0a1c830c7495f3125acf0ec7f (diff) | |
Merge pull request #4528 from lioncash/discard
common: Make use of [[nodiscard]] where applicable
Diffstat (limited to 'src/common/lz4_compression.h')
| -rw-r--r-- | src/common/lz4_compression.h | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/src/common/lz4_compression.h b/src/common/lz4_compression.h index 173f9b9ad..87a4be1b0 100644 --- a/src/common/lz4_compression.h +++ b/src/common/lz4_compression.h @@ -4,7 +4,6 @@ #pragma once -#include <span> #include <vector> #include "common/common_types.h" @@ -14,11 +13,12 @@ namespace Common::Compression { /** * Compresses a source memory region with LZ4 and returns the compressed data in a vector. * - * @param source the uncompressed source memory region. + * @param source The uncompressed source memory region. + * @param source_size The size of the uncompressed source memory region. * * @return the compressed data. */ -std::vector<u8> CompressDataLZ4(std::span<const u8> source); +[[nodiscard]] std::vector<u8> CompressDataLZ4(const u8* source, std::size_t source_size); /** * Utilizes the LZ4 subalgorithm LZ4HC with the specified compression level. Higher compression @@ -26,21 +26,24 @@ std::vector<u8> CompressDataLZ4(std::span<const u8> source); * compression level has almost no impact on decompression speed. Data compressed with LZ4HC can * also be decompressed with the default LZ4 decompression. * - * @param source the uncompressed source memory region. - * @param compression_level the used compression level. Should be between 3 and 12. + * @param source The uncompressed source memory region. + * @param source_size The size of the uncompressed source memory region. + * @param compression_level The used compression level. Should be between 3 and 12. * * @return the compressed data. */ -std::vector<u8> CompressDataLZ4HC(std::span<const u8> source, s32 compression_level); +[[nodiscard]] std::vector<u8> CompressDataLZ4HC(const u8* source, std::size_t source_size, + s32 compression_level); /** * Utilizes the LZ4 subalgorithm LZ4HC with the highest possible compression level. * - * @param source the uncompressed source memory region. + * @param source The uncompressed source memory region. + * @param source_size The size of the uncompressed source memory region * * @return the compressed data. */ -std::vector<u8> CompressDataLZ4HCMax(std::span<const u8> source); +[[nodiscard]] std::vector<u8> CompressDataLZ4HCMax(const u8* source, std::size_t source_size); /** * Decompresses a source memory region with LZ4 and returns the uncompressed data in a vector. @@ -50,6 +53,7 @@ std::vector<u8> CompressDataLZ4HCMax(std::span<const u8> source); * * @return the decompressed data. */ -std::vector<u8> DecompressDataLZ4(const std::vector<u8>& compressed, std::size_t uncompressed_size); +[[nodiscard]] std::vector<u8> DecompressDataLZ4(const std::vector<u8>& compressed, + std::size_t uncompressed_size); } // namespace Common::Compression
\ No newline at end of file |