summaryrefslogtreecommitdiff
path: root/src/common/string_util.h
diff options
context:
space:
mode:
authorWeiyi Wang <wwylele@gmail.com>2018-09-22 00:52:38 -0400
committerfearlessTobi <thm.frey@gmail.com>2018-10-02 16:10:20 +0200
commitbfe84f06f2de966b68026f5b3f4212fd2ba783b6 (patch)
treea5d3e6cbcfd520fde820edf83fbace8c174e9818 /src/common/string_util.h
parenta4595bb93947c849c8101cac6de29f9f694f26b1 (diff)
string_util: remove TString conversion for windows
First of all they are foundamentally broken. As our convention is that std::string is always UTF-8, these functions assume that the multi-byte character version of TString (std::string) from windows is also in UTF-8, which is almost always wrong. We are not going to build multi-byte character build, and even if we do, this dirty work should be handled by frontend framework early.
Diffstat (limited to 'src/common/string_util.h')
-rw-r--r--src/common/string_util.h18
1 files changed, 0 insertions, 18 deletions
diff --git a/src/common/string_util.h b/src/common/string_util.h
index 78b558405..32bf6a19c 100644
--- a/src/common/string_util.h
+++ b/src/common/string_util.h
@@ -76,24 +76,6 @@ std::u16string UTF8ToUTF16(const std::string& input);
std::string UTF16ToUTF8(const std::wstring& input);
std::wstring UTF8ToUTF16W(const std::string& str);
-#ifdef _UNICODE
-inline std::string TStrToUTF8(const std::wstring& str) {
- return UTF16ToUTF8(str);
-}
-
-inline std::wstring UTF8ToTStr(const std::string& str) {
- return UTF8ToUTF16W(str);
-}
-#else
-inline std::string TStrToUTF8(const std::string& str) {
- return str;
-}
-
-inline std::string UTF8ToTStr(const std::string& str) {
- return str;
-}
-#endif
-
#endif
/**