diff options
| author | Yuri Kunde Schlesner <yuriks@yuriks.net> | 2014-12-05 23:53:49 -0200 | 
|---|---|---|
| committer | Yuri Kunde Schlesner <yuriks@yuriks.net> | 2014-12-13 02:08:02 -0200 | 
| commit | 0600e2d8b5b30bd68c8b19cb1f2051e096e7caa9 (patch) | |
| tree | 40fee084c551bfb497e68181447298f862ea68ca /src/core/hle | |
| parent | 6390c66e950b0536c438bf3be1ea78fd0540d6c9 (diff) | |
Convert old logging calls to new logging macros
Diffstat (limited to 'src/core/hle')
| -rw-r--r-- | src/core/hle/config_mem.cpp | 2 | ||||
| -rw-r--r-- | src/core/hle/hle.cpp | 12 | ||||
| -rw-r--r-- | src/core/hle/kernel/address_arbiter.cpp | 8 | ||||
| -rw-r--r-- | src/core/hle/kernel/archive.cpp | 50 | ||||
| -rw-r--r-- | src/core/hle/kernel/kernel.cpp | 8 | ||||
| -rw-r--r-- | src/core/hle/kernel/kernel.h | 17 | ||||
| -rw-r--r-- | src/core/hle/kernel/shared_memory.cpp | 10 | ||||
| -rw-r--r-- | src/core/hle/kernel/thread.cpp | 24 | ||||
| -rw-r--r-- | src/core/hle/service/ac_u.cpp | 2 | ||||
| -rw-r--r-- | src/core/hle/service/apt_u.cpp | 20 | ||||
| -rw-r--r-- | src/core/hle/service/cfg_u.cpp | 6 | ||||
| -rw-r--r-- | src/core/hle/service/dsp_dsp.cpp | 14 | ||||
| -rw-r--r-- | src/core/hle/service/fs_user.cpp | 54 | ||||
| -rw-r--r-- | src/core/hle/service/gsp_gpu.cpp | 18 | ||||
| -rw-r--r-- | src/core/hle/service/hid_user.cpp | 2 | ||||
| -rw-r--r-- | src/core/hle/service/ptm_u.cpp | 8 | ||||
| -rw-r--r-- | src/core/hle/service/service.cpp | 4 | ||||
| -rw-r--r-- | src/core/hle/service/service.h | 8 | ||||
| -rw-r--r-- | src/core/hle/service/srv.cpp | 8 | ||||
| -rw-r--r-- | src/core/hle/svc.cpp | 54 | 
20 files changed, 138 insertions, 191 deletions
diff --git a/src/core/hle/config_mem.cpp b/src/core/hle/config_mem.cpp index 1c9b89227..d8ba9e6cf 100644 --- a/src/core/hle/config_mem.cpp +++ b/src/core/hle/config_mem.cpp @@ -55,7 +55,7 @@ inline void Read(T &var, const u32 addr) {          break;      default: -        ERROR_LOG(HLE, "unknown addr=0x%08X", addr); +        LOG_ERROR(Kernel, "unknown addr=0x%08X", addr);      }  } diff --git a/src/core/hle/hle.cpp b/src/core/hle/hle.cpp index b8ac186f6..3f73b5538 100644 --- a/src/core/hle/hle.cpp +++ b/src/core/hle/hle.cpp @@ -20,7 +20,7 @@ bool g_reschedule = false;  ///< If true, immediately reschedules the CPU to a n  const FunctionDef* GetSVCInfo(u32 opcode) {      u32 func_num = opcode & 0xFFFFFF; // 8 bits      if (func_num > 0xFF) { -        ERROR_LOG(HLE,"unknown svc=0x%02X", func_num); +        LOG_ERROR(Kernel_SVC,"unknown svc=0x%02X", func_num);          return nullptr;      }      return &g_module_db[0].func_table[func_num]; @@ -35,14 +35,12 @@ void CallSVC(u32 opcode) {      if (info->func) {          info->func();      } else { -        ERROR_LOG(HLE, "unimplemented SVC function %s(..)", info->name.c_str()); +        LOG_ERROR(Kernel_SVC, "unimplemented SVC function %s(..)", info->name.c_str());      }  }  void Reschedule(const char *reason) { -#ifdef _DEBUG -    _dbg_assert_msg_(HLE, reason != 0 && strlen(reason) < 256, "Reschedule: Invalid or too long reason."); -#endif +    _dbg_assert_msg_(Kernel, reason != 0 && strlen(reason) < 256, "Reschedule: Invalid or too long reason.");      Core::g_app_core->PrepareReschedule();      g_reschedule = true;  } @@ -61,7 +59,7 @@ void Init() {      RegisterAllModules(); -    NOTICE_LOG(HLE, "initialized OK"); +    LOG_DEBUG(Kernel, "initialized OK");  }  void Shutdown() { @@ -69,7 +67,7 @@ void Shutdown() {      g_module_db.clear(); -    NOTICE_LOG(HLE, "shutdown OK"); +    LOG_DEBUG(Kernel, "shutdown OK");  }  } // namespace diff --git a/src/core/hle/kernel/address_arbiter.cpp b/src/core/hle/kernel/address_arbiter.cpp index ce4f3c854..9a921108d 100644 --- a/src/core/hle/kernel/address_arbiter.cpp +++ b/src/core/hle/kernel/address_arbiter.cpp @@ -24,12 +24,6 @@ public:      Kernel::HandleType GetHandleType() const override { return HandleType::AddressArbiter; }      std::string name;   ///< Name of address arbiter object (optional) - -    ResultVal<bool> WaitSynchronization() override { -        // TODO(bunnei): ImplementMe -        ERROR_LOG(OSHLE, "(UNIMPLEMENTED)"); -        return UnimplementedFunction(ErrorModule::OS); -    }  };  //////////////////////////////////////////////////////////////////////////////////////////////////// @@ -59,7 +53,7 @@ ResultCode ArbitrateAddress(Handle handle, ArbitrationType type, u32 address, s3          break;      default: -        ERROR_LOG(KERNEL, "unknown type=%d", type); +        LOG_ERROR(Kernel, "unknown type=%d", type);          return ResultCode(ErrorDescription::InvalidEnumValue, ErrorModule::Kernel, ErrorSummary::WrongArgument, ErrorLevel::Usage);      }      return RESULT_SUCCESS; diff --git a/src/core/hle/kernel/archive.cpp b/src/core/hle/kernel/archive.cpp index a875fa7ff..ddc09e13b 100644 --- a/src/core/hle/kernel/archive.cpp +++ b/src/core/hle/kernel/archive.cpp @@ -94,26 +94,20 @@ public:          }          case FileCommand::Close:          { -            DEBUG_LOG(KERNEL, "Close %s %s", GetTypeName().c_str(), GetName().c_str()); +            LOG_TRACE(Service_FS, "Close %s %s", GetTypeName().c_str(), GetName().c_str());              CloseArchive(backend->GetIdCode());              break;          }          // Unknown command...          default:          { -            ERROR_LOG(KERNEL, "Unknown command=0x%08X!", cmd); +            LOG_ERROR(Service_FS, "Unknown command=0x%08X", cmd);              return UnimplementedFunction(ErrorModule::FS);          }          }          cmd_buff[1] = 0; // No error          return MakeResult<bool>(false);      } - -    ResultVal<bool> WaitSynchronization() override { -        // TODO(bunnei): ImplementMe -        ERROR_LOG(OSHLE, "(UNIMPLEMENTED)"); -        return UnimplementedFunction(ErrorModule::FS); -    }  };  class File : public Object { @@ -138,7 +132,7 @@ public:              u64 offset = cmd_buff[1] | ((u64) cmd_buff[2]) << 32;              u32 length  = cmd_buff[3];              u32 address = cmd_buff[5]; -            DEBUG_LOG(KERNEL, "Read %s %s: offset=0x%llx length=%d address=0x%x", +            LOG_TRACE(Service_FS, "Read %s %s: offset=0x%llx length=%d address=0x%x",                        GetTypeName().c_str(), GetName().c_str(), offset, length, address);              cmd_buff[2] = backend->Read(offset, length, Memory::GetPointer(address));              break; @@ -151,7 +145,7 @@ public:              u32 length  = cmd_buff[3];              u32 flush   = cmd_buff[4];              u32 address = cmd_buff[6]; -            DEBUG_LOG(KERNEL, "Write %s %s: offset=0x%llx length=%d address=0x%x, flush=0x%x", +            LOG_TRACE(Service_FS, "Write %s %s: offset=0x%llx length=%d address=0x%x, flush=0x%x",                        GetTypeName().c_str(), GetName().c_str(), offset, length, address, flush);              cmd_buff[2] = backend->Write(offset, length, flush, Memory::GetPointer(address));              break; @@ -159,7 +153,7 @@ public:          case FileCommand::GetSize:          { -            DEBUG_LOG(KERNEL, "GetSize %s %s", GetTypeName().c_str(), GetName().c_str()); +            LOG_TRACE(Service_FS, "GetSize %s %s", GetTypeName().c_str(), GetName().c_str());              u64 size = backend->GetSize();              cmd_buff[2] = (u32)size;              cmd_buff[3] = size >> 32; @@ -169,7 +163,7 @@ public:          case FileCommand::SetSize:          {              u64 size = cmd_buff[1] | ((u64)cmd_buff[2] << 32); -            DEBUG_LOG(KERNEL, "SetSize %s %s size=%llu", +            LOG_TRACE(Service_FS, "SetSize %s %s size=%llu",                      GetTypeName().c_str(), GetName().c_str(), size);              backend->SetSize(size);              break; @@ -177,14 +171,14 @@ public:          case FileCommand::Close:          { -            DEBUG_LOG(KERNEL, "Close %s %s", GetTypeName().c_str(), GetName().c_str()); +            LOG_TRACE(Service_FS, "Close %s %s", GetTypeName().c_str(), GetName().c_str());              Kernel::g_object_pool.Destroy<File>(GetHandle());              break;          }          // Unknown command...          default: -            ERROR_LOG(KERNEL, "Unknown command=0x%08X!", cmd); +            LOG_ERROR(Service_FS, "Unknown command=0x%08X!", cmd);              ResultCode error = UnimplementedFunction(ErrorModule::FS);              cmd_buff[1] = error.raw; // TODO(Link Mauve): use the correct error code for that.              return error; @@ -192,12 +186,6 @@ public:          cmd_buff[1] = 0; // No error          return MakeResult<bool>(false);      } - -    ResultVal<bool> WaitSynchronization() override { -        // TODO(bunnei): ImplementMe -        ERROR_LOG(OSHLE, "(UNIMPLEMENTED)"); -        return UnimplementedFunction(ErrorModule::FS); -    }  };  class Directory : public Object { @@ -222,7 +210,7 @@ public:              u32 count = cmd_buff[1];              u32 address = cmd_buff[3];              auto entries = reinterpret_cast<FileSys::Entry*>(Memory::GetPointer(address)); -            DEBUG_LOG(KERNEL, "Read %s %s: count=%d", +            LOG_TRACE(Service_FS, "Read %s %s: count=%d",                      GetTypeName().c_str(), GetName().c_str(), count);              // Number of entries actually read @@ -232,14 +220,14 @@ public:          case DirectoryCommand::Close:          { -            DEBUG_LOG(KERNEL, "Close %s %s", GetTypeName().c_str(), GetName().c_str()); +            LOG_TRACE(Service_FS, "Close %s %s", GetTypeName().c_str(), GetName().c_str());              Kernel::g_object_pool.Destroy<Directory>(GetHandle());              break;          }          // Unknown command...          default: -            ERROR_LOG(KERNEL, "Unknown command=0x%08X!", cmd); +            LOG_ERROR(Service_FS, "Unknown command=0x%08X!", cmd);              ResultCode error = UnimplementedFunction(ErrorModule::FS);              cmd_buff[1] = error.raw; // TODO(Link Mauve): use the correct error code for that.              return error; @@ -247,12 +235,6 @@ public:          cmd_buff[1] = 0; // No error          return MakeResult<bool>(false);      } - -    ResultVal<bool> WaitSynchronization() override { -        // TODO(bunnei): ImplementMe -        ERROR_LOG(OSHLE, "(UNIMPLEMENTED)"); -        return UnimplementedFunction(ErrorModule::FS); -    }  };  //////////////////////////////////////////////////////////////////////////////////////////////////// @@ -272,11 +254,11 @@ ResultVal<Handle> OpenArchive(FileSys::Archive::IdCode id_code) {  ResultCode CloseArchive(FileSys::Archive::IdCode id_code) {      auto itr = g_archive_map.find(id_code);      if (itr == g_archive_map.end()) { -        ERROR_LOG(KERNEL, "Cannot close archive %d, does not exist!", (int)id_code); +        LOG_ERROR(Service_FS, "Cannot close archive %d, does not exist!", (int)id_code);          return InvalidHandle(ErrorModule::FS);      } -    INFO_LOG(KERNEL, "Closed archive %d", (int) id_code); +    LOG_TRACE(Service_FS, "Closed archive %d", (int) id_code);      return RESULT_SUCCESS;  } @@ -288,11 +270,11 @@ ResultCode MountArchive(Archive* archive) {      FileSys::Archive::IdCode id_code = archive->backend->GetIdCode();      ResultVal<Handle> archive_handle = OpenArchive(id_code);      if (archive_handle.Succeeded()) { -        ERROR_LOG(KERNEL, "Cannot mount two archives with the same ID code! (%d)", (int) id_code); +        LOG_ERROR(Service_FS, "Cannot mount two archives with the same ID code! (%d)", (int) id_code);          return archive_handle.Code();      }      g_archive_map[id_code] = archive->GetHandle(); -    INFO_LOG(KERNEL, "Mounted archive %s", archive->GetName().c_str()); +    LOG_TRACE(Service_FS, "Mounted archive %s", archive->GetName().c_str());      return RESULT_SUCCESS;  } @@ -442,7 +424,7 @@ void ArchiveInit() {      if (archive->Initialize())          CreateArchive(archive, "SDMC");      else -        ERROR_LOG(KERNEL, "Can't instantiate SDMC archive with path %s", sdmc_directory.c_str()); +        LOG_ERROR(Service_FS, "Can't instantiate SDMC archive with path %s", sdmc_directory.c_str());  }  /// Shutdown archives diff --git a/src/core/hle/kernel/kernel.cpp b/src/core/hle/kernel/kernel.cpp index 80a34c2d5..b38be0a49 100644 --- a/src/core/hle/kernel/kernel.cpp +++ b/src/core/hle/kernel/kernel.cpp @@ -35,7 +35,7 @@ Handle ObjectPool::Create(Object* obj, int range_bottom, int range_top) {              return i + HANDLE_OFFSET;          }      } -    ERROR_LOG(HLE, "Unable to allocate kernel object, too many objects slots in use."); +    LOG_ERROR(Kernel, "Unable to allocate kernel object, too many objects slots in use.");      return 0;  } @@ -62,7 +62,7 @@ void ObjectPool::Clear() {  Object* &ObjectPool::operator [](Handle handle)  { -    _dbg_assert_msg_(KERNEL, IsValid(handle), "GRABBING UNALLOCED KERNEL OBJ"); +    _dbg_assert_msg_(Kernel, IsValid(handle), "GRABBING UNALLOCED KERNEL OBJ");      return pool[handle - HANDLE_OFFSET];  } @@ -70,7 +70,7 @@ void ObjectPool::List() {      for (int i = 0; i < MAX_COUNT; i++) {          if (occupied[i]) {              if (pool[i]) { -                INFO_LOG(KERNEL, "KO %i: %s \"%s\"", i + HANDLE_OFFSET, pool[i]->GetTypeName().c_str(), +                LOG_DEBUG(Kernel, "KO %i: %s \"%s\"", i + HANDLE_OFFSET, pool[i]->GetTypeName().c_str(),                      pool[i]->GetName().c_str());              }          } @@ -82,7 +82,7 @@ int ObjectPool::GetCount() const {  }  Object* ObjectPool::CreateByIDType(int type) { -    ERROR_LOG(COMMON, "Unimplemented: %d.", type); +    LOG_ERROR(Kernel, "Unimplemented: %d.", type);      return nullptr;  } diff --git a/src/core/hle/kernel/kernel.h b/src/core/hle/kernel/kernel.h index 00a2228bf..00f9b57fc 100644 --- a/src/core/hle/kernel/kernel.h +++ b/src/core/hle/kernel/kernel.h @@ -57,7 +57,7 @@ public:       * @return True if the current thread should wait as a result of the sync       */      virtual ResultVal<bool> SyncRequest() { -        ERROR_LOG(KERNEL, "(UNIMPLEMENTED)"); +        LOG_ERROR(Kernel, "(UNIMPLEMENTED)");          return UnimplementedFunction(ErrorModule::Kernel);      } @@ -65,7 +65,10 @@ public:       * Wait for kernel object to synchronize.       * @return True if the current thread should wait as a result of the wait       */ -    virtual ResultVal<bool> WaitSynchronization() = 0; +    virtual ResultVal<bool> WaitSynchronization() { +        LOG_ERROR(Kernel, "(UNIMPLEMENTED)"); +        return UnimplementedFunction(ErrorModule::Kernel); +    }  };  class ObjectPool : NonCopyable { @@ -92,13 +95,13 @@ public:      T* Get(Handle handle) {          if (handle < HANDLE_OFFSET || handle >= HANDLE_OFFSET + MAX_COUNT || !occupied[handle - HANDLE_OFFSET]) {              if (handle != 0) { -                WARN_LOG(KERNEL, "Kernel: Bad object handle %i (%08x)", handle, handle); +                LOG_ERROR(Kernel, "Bad object handle %08x", handle, handle);              }              return nullptr;          } else {              Object* t = pool[handle - HANDLE_OFFSET];              if (t->GetHandleType() != T::GetStaticHandleType()) { -                WARN_LOG(KERNEL, "Kernel: Wrong object type for %i (%08x)", handle, handle); +                LOG_ERROR(Kernel, "Wrong object type for %08x", handle, handle);                  return nullptr;              }              return static_cast<T*>(t); @@ -109,7 +112,7 @@ public:      template <class T>      T *GetFast(Handle handle) {          const Handle realHandle = handle - HANDLE_OFFSET; -        _dbg_assert_(KERNEL, realHandle >= 0 && realHandle < MAX_COUNT && occupied[realHandle]); +        _dbg_assert_(Kernel, realHandle >= 0 && realHandle < MAX_COUNT && occupied[realHandle]);          return static_cast<T*>(pool[realHandle]);      } @@ -130,8 +133,8 @@ public:      bool GetIDType(Handle handle, HandleType* type) const {          if ((handle < HANDLE_OFFSET) || (handle >= HANDLE_OFFSET + MAX_COUNT) || -            !occupied[handle - HANDLE_OFFSET]) { -            ERROR_LOG(KERNEL, "Kernel: Bad object handle %i (%08x)", handle, handle); +                !occupied[handle - HANDLE_OFFSET]) { +            LOG_ERROR(Kernel, "Bad object handle %08X", handle, handle);              return false;          }          Object* t = pool[handle - HANDLE_OFFSET]; diff --git a/src/core/hle/kernel/shared_memory.cpp b/src/core/hle/kernel/shared_memory.cpp index cfcc0e0b7..3c8c502c6 100644 --- a/src/core/hle/kernel/shared_memory.cpp +++ b/src/core/hle/kernel/shared_memory.cpp @@ -16,12 +16,6 @@ public:      static Kernel::HandleType GetStaticHandleType() {  return Kernel::HandleType::SharedMemory; }      Kernel::HandleType GetHandleType() const override { return Kernel::HandleType::SharedMemory; } -    ResultVal<bool> WaitSynchronization() override { -        // TODO(bunnei): ImplementMe -        ERROR_LOG(OSHLE, "(UNIMPLEMENTED)"); -        return UnimplementedFunction(ErrorModule::OS); -    } -      u32 base_address;                   ///< Address of shared memory block in RAM      MemoryPermission permissions;       ///< Permissions of shared memory block (SVC field)      MemoryPermission other_permissions; ///< Other permissions of shared memory block (SVC field) @@ -61,7 +55,7 @@ ResultCode MapSharedMemory(u32 handle, u32 address, MemoryPermission permissions      MemoryPermission other_permissions) {      if (address < Memory::SHARED_MEMORY_VADDR || address >= Memory::SHARED_MEMORY_VADDR_END) { -        ERROR_LOG(KERNEL, "cannot map handle=0x%08X, address=0x%08X outside of shared mem bounds!", +        LOG_ERROR(Kernel_SVC, "cannot map handle=0x%08X, address=0x%08X outside of shared mem bounds!",              handle, address);          return ResultCode(ErrorDescription::InvalidAddress, ErrorModule::Kernel,                  ErrorSummary::InvalidArgument, ErrorLevel::Permanent); @@ -83,7 +77,7 @@ ResultVal<u8*> GetSharedMemoryPointer(Handle handle, u32 offset) {      if (0 != shared_memory->base_address)          return MakeResult<u8*>(Memory::GetPointer(shared_memory->base_address + offset)); -    ERROR_LOG(KERNEL, "memory block handle=0x%08X not mapped!", handle); +    LOG_ERROR(Kernel_SVC, "memory block handle=0x%08X not mapped!", handle);      // TODO(yuriks): Verify error code.      return ResultCode(ErrorDescription::InvalidAddress, ErrorModule::Kernel,              ErrorSummary::InvalidState, ErrorLevel::Permanent); diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp index 492b917e1..1c04701de 100644 --- a/src/core/hle/kernel/thread.cpp +++ b/src/core/hle/kernel/thread.cpp @@ -150,13 +150,13 @@ void ChangeReadyState(Thread* t, bool ready) {  /// Verify that a thread has not been released from waiting  static bool VerifyWait(const Thread* thread, WaitType type, Handle wait_handle) { -    _dbg_assert_(KERNEL, thread != nullptr); +    _dbg_assert_(Kernel, thread != nullptr);      return (type == thread->wait_type) && (wait_handle == thread->wait_handle) && (thread->IsWaiting());  }  /// Verify that a thread has not been released from waiting (with wait address)  static bool VerifyWait(const Thread* thread, WaitType type, Handle wait_handle, VAddr wait_address) { -    _dbg_assert_(KERNEL, thread != nullptr); +    _dbg_assert_(Kernel, thread != nullptr);      return VerifyWait(thread, type, wait_handle) && (wait_address == thread->wait_address);  } @@ -196,7 +196,7 @@ void ChangeThreadState(Thread* t, ThreadStatus new_status) {      if (new_status == THREADSTATUS_WAIT) {          if (t->wait_type == WAITTYPE_NONE) { -            ERROR_LOG(KERNEL, "Waittype none not allowed"); +            LOG_ERROR(Kernel, "Waittype none not allowed");          }      }  } @@ -318,12 +318,12 @@ void DebugThreadQueue() {      if (!thread) {          return;      } -    INFO_LOG(KERNEL, "0x%02X 0x%08X (current)", thread->current_priority, GetCurrentThreadHandle()); +    LOG_DEBUG(Kernel, "0x%02X 0x%08X (current)", thread->current_priority, GetCurrentThreadHandle());      for (u32 i = 0; i < thread_queue.size(); i++) {          Handle handle = thread_queue[i];          s32 priority = thread_ready_queue.contains(handle);          if (priority != -1) { -            INFO_LOG(KERNEL, "0x%02X 0x%08X", priority, handle); +            LOG_DEBUG(Kernel, "0x%02X 0x%08X", priority, handle);          }      }  } @@ -333,7 +333,7 @@ Thread* CreateThread(Handle& handle, const char* name, u32 entry_point, s32 prio      s32 processor_id, u32 stack_top, int stack_size) {      _assert_msg_(KERNEL, (priority >= THREADPRIO_HIGHEST && priority <= THREADPRIO_LOWEST), -        "CreateThread priority=%d, outside of allowable range!", priority) +        "priority=%d, outside of allowable range!", priority)      Thread* thread = new Thread; @@ -362,24 +362,24 @@ Handle CreateThread(const char* name, u32 entry_point, s32 priority, u32 arg, s3      u32 stack_top, int stack_size) {      if (name == nullptr) { -        ERROR_LOG(KERNEL, "CreateThread(): nullptr name"); +        LOG_ERROR(Kernel_SVC, "nullptr name");          return -1;      }      if ((u32)stack_size < 0x200) { -        ERROR_LOG(KERNEL, "CreateThread(name=%s): invalid stack_size=0x%08X", name, +        LOG_ERROR(Kernel_SVC, "(name=%s): invalid stack_size=0x%08X", name,              stack_size);          return -1;      }      if (priority < THREADPRIO_HIGHEST || priority > THREADPRIO_LOWEST) {          s32 new_priority = CLAMP(priority, THREADPRIO_HIGHEST, THREADPRIO_LOWEST); -        WARN_LOG(KERNEL, "CreateThread(name=%s): invalid priority=0x%08X, clamping to %08X", +        LOG_WARNING(Kernel_SVC, "(name=%s): invalid priority=%d, clamping to %d",              name, priority, new_priority);          // TODO(bunnei): Clamping to a valid priority is not necessarily correct behavior... Confirm          // validity of this          priority = new_priority;      }      if (!Memory::GetPointer(entry_point)) { -        ERROR_LOG(KERNEL, "CreateThread(name=%s): invalid entry %08x", name, entry_point); +        LOG_ERROR(Kernel_SVC, "(name=%s): invalid entry %08x", name, entry_point);          return -1;      }      Handle handle; @@ -416,7 +416,7 @@ ResultCode SetThreadPriority(Handle handle, s32 priority) {      // If priority is invalid, clamp to valid range      if (priority < THREADPRIO_HIGHEST || priority > THREADPRIO_LOWEST) {          s32 new_priority = CLAMP(priority, THREADPRIO_HIGHEST, THREADPRIO_LOWEST); -        WARN_LOG(KERNEL, "invalid priority=0x%08X, clamping to %08X", priority, new_priority); +        LOG_WARNING(Kernel_SVC, "invalid priority=%d, clamping to %d", priority, new_priority);          // TODO(bunnei): Clamping to a valid priority is not necessarily correct behavior... Confirm          // validity of this          priority = new_priority; @@ -470,7 +470,7 @@ void Reschedule() {      Thread* next = NextThread();      HLE::g_reschedule = false;      if (next > 0) { -        INFO_LOG(KERNEL, "context switch 0x%08X -> 0x%08X", prev->GetHandle(), next->GetHandle()); +        LOG_TRACE(Kernel, "context switch 0x%08X -> 0x%08X", prev->GetHandle(), next->GetHandle());          SwitchContext(next); diff --git a/src/core/hle/service/ac_u.cpp b/src/core/hle/service/ac_u.cpp index 46aee40d6..4130feb9d 100644 --- a/src/core/hle/service/ac_u.cpp +++ b/src/core/hle/service/ac_u.cpp @@ -26,7 +26,7 @@ void GetWifiStatus(Service::Interface* self) {      cmd_buff[1] = 0; // No error      cmd_buff[2] = 0; // Connection type set to none -    WARN_LOG(KERNEL, "(STUBBED) called"); +    LOG_WARNING(Service_AC, "(STUBBED) called");  }  const Interface::FunctionInfo FunctionTable[] = { diff --git a/src/core/hle/service/apt_u.cpp b/src/core/hle/service/apt_u.cpp index 181763724..b6d5d101f 100644 --- a/src/core/hle/service/apt_u.cpp +++ b/src/core/hle/service/apt_u.cpp @@ -53,7 +53,7 @@ void Initialize(Service::Interface* self) {      cmd_buff[1] = 0; // No error -    DEBUG_LOG(KERNEL, "called"); +    LOG_DEBUG(Service_APT, "called");  }  void GetLockHandle(Service::Interface* self) { @@ -74,14 +74,14 @@ void GetLockHandle(Service::Interface* self) {      cmd_buff[4] = 0;      cmd_buff[5] = lock_handle; -    DEBUG_LOG(KERNEL, "called handle=0x%08X", cmd_buff[5]); +    LOG_TRACE(Service_APT, "called handle=0x%08X", cmd_buff[5]);  }  void Enable(Service::Interface* self) {      u32* cmd_buff = Service::GetCommandBuffer();      u32 unk = cmd_buff[1]; // TODO(bunnei): What is this field used for?      cmd_buff[1] = 0; // No error -    WARN_LOG(KERNEL, "(STUBBED) called unk=0x%08X", unk); +    LOG_WARNING(Service_APT, "(STUBBED) called unk=0x%08X", unk);  }  void InquireNotification(Service::Interface* self) { @@ -89,7 +89,7 @@ void InquireNotification(Service::Interface* self) {      u32 app_id = cmd_buff[2];      cmd_buff[1] = 0; // No error      cmd_buff[2] = static_cast<u32>(SignalType::None); // Signal type -    WARN_LOG(KERNEL, "(STUBBED) called app_id=0x%08X", app_id); +    LOG_WARNING(Service_APT, "(STUBBED) called app_id=0x%08X", app_id);  }  /** @@ -122,7 +122,7 @@ void ReceiveParameter(Service::Interface* self) {      cmd_buff[5] = 0;      cmd_buff[6] = 0;      cmd_buff[7] = 0; -    WARN_LOG(KERNEL, "(STUBBED) called app_id=0x%08X, buffer_size=0x%08X", app_id, buffer_size); +    LOG_WARNING(Service_APT, "(STUBBED) called app_id=0x%08X, buffer_size=0x%08X", app_id, buffer_size);  }  /** @@ -155,7 +155,7 @@ void GlanceParameter(Service::Interface* self) {      cmd_buff[6] = 0;      cmd_buff[7] = 0; -    WARN_LOG(KERNEL, "(STUBBED) called app_id=0x%08X, buffer_size=0x%08X", app_id, buffer_size); +    LOG_WARNING(Service_APT, "(STUBBED) called app_id=0x%08X, buffer_size=0x%08X", app_id, buffer_size);  }  /** @@ -181,7 +181,7 @@ void AppletUtility(Service::Interface* self) {      cmd_buff[1] = 0; // No error -    WARN_LOG(KERNEL, "(STUBBED) called unk=0x%08X, buffer1_size=0x%08x, buffer2_size=0x%08x, " +    LOG_WARNING(Service_APT, "(STUBBED) called unk=0x%08X, buffer1_size=0x%08x, buffer2_size=0x%08x, "               "buffer1_addr=0x%08x, buffer2_addr=0x%08x", unk, buffer1_size, buffer2_size,               buffer1_addr, buffer2_addr);  } @@ -194,7 +194,7 @@ void AppletUtility(Service::Interface* self) {   *      4 : Handle to shared font memory   */  void GetSharedFont(Service::Interface* self) { -    DEBUG_LOG(KERNEL, "called"); +    LOG_TRACE(Kernel_SVC, "called");      u32* cmd_buff = Service::GetCommandBuffer(); @@ -210,7 +210,7 @@ void GetSharedFont(Service::Interface* self) {          cmd_buff[4] = shared_font_mem;      } else {          cmd_buff[1] = -1; // Generic error (not really possible to verify this on hardware) -        ERROR_LOG(KERNEL, "called, but %s has not been loaded!", SHARED_FONT); +        LOG_ERROR(Kernel_SVC, "called, but %s has not been loaded!", SHARED_FONT);      }  } @@ -321,7 +321,7 @@ Interface::Interface() {          // Create shared font memory object          shared_font_mem = Kernel::CreateSharedMemory("APT_U:shared_font_mem");      } else { -        WARN_LOG(KERNEL, "Unable to load shared font: %s", filepath.c_str()); +        LOG_WARNING(Service_APT, "Unable to load shared font: %s", filepath.c_str());          shared_font_mem = 0;      } diff --git a/src/core/hle/service/cfg_u.cpp b/src/core/hle/service/cfg_u.cpp index 82bab5797..972cc0534 100644 --- a/src/core/hle/service/cfg_u.cpp +++ b/src/core/hle/service/cfg_u.cpp @@ -56,7 +56,7 @@ static void GetCountryCodeString(Service::Interface* self) {      u32 country_code_id = cmd_buffer[1];      if (country_code_id >= country_codes.size() || 0 == country_codes[country_code_id]) { -        ERROR_LOG(KERNEL, "requested country code id=%d is invalid", country_code_id); +        LOG_ERROR(Service_CFG, "requested country code id=%d is invalid", country_code_id);          cmd_buffer[1] = ResultCode(ErrorDescription::NotFound, ErrorModule::Config, ErrorSummary::WrongArgument, ErrorLevel::Permanent).raw;          return;      } @@ -79,7 +79,7 @@ static void GetCountryCodeID(Service::Interface* self) {      u16 country_code_id = 0;      // The following algorithm will fail if the first country code isn't 0. -    _dbg_assert_(HLE, country_codes[0] == 0); +    _dbg_assert_(Service_CFG, country_codes[0] == 0);      for (size_t id = 0; id < country_codes.size(); ++id) {          if (country_codes[id] == country_code) { @@ -89,7 +89,7 @@ static void GetCountryCodeID(Service::Interface* self) {      }      if (0 == country_code_id) { -        ERROR_LOG(KERNEL, "requested country code name=%c%c is invalid", country_code & 0xff, country_code >> 8); +        LOG_ERROR(Service_CFG, "requested country code name=%c%c is invalid", country_code & 0xff, country_code >> 8);          cmd_buffer[1] = ResultCode(ErrorDescription::NotFound, ErrorModule::Config, ErrorSummary::WrongArgument, ErrorLevel::Permanent).raw;          cmd_buffer[2] = 0xFFFF;          return; diff --git a/src/core/hle/service/dsp_dsp.cpp b/src/core/hle/service/dsp_dsp.cpp index e89c8aae3..ce1c9938d 100644 --- a/src/core/hle/service/dsp_dsp.cpp +++ b/src/core/hle/service/dsp_dsp.cpp @@ -32,7 +32,7 @@ void ConvertProcessAddressFromDspDram(Service::Interface* self) {      cmd_buff[1] = 0; // No error      cmd_buff[2] = (addr << 1) + (Memory::DSP_MEMORY_VADDR + 0x40000); -    DEBUG_LOG(KERNEL, "(STUBBED) called with address %u", addr); +    LOG_WARNING(Service_DSP, "(STUBBED) called with address %u", addr);  }  /** @@ -55,7 +55,7 @@ void LoadComponent(Service::Interface* self) {      // TODO(bunnei): Implement real DSP firmware loading -    DEBUG_LOG(KERNEL, "(STUBBED) called"); +    LOG_WARNING(Service_DSP, "(STUBBED) called");  }  /** @@ -70,7 +70,7 @@ void GetSemaphoreEventHandle(Service::Interface* self) {      cmd_buff[1] = 0; // No error      cmd_buff[3] = semaphore_event; // Event handle -    DEBUG_LOG(KERNEL, "(STUBBED) called"); +    LOG_WARNING(Service_DSP, "(STUBBED) called");  }  /** @@ -89,7 +89,7 @@ void RegisterInterruptEvents(Service::Interface* self) {      cmd_buff[1] = 0; // No error -    DEBUG_LOG(KERNEL, "(STUBBED) called"); +    LOG_WARNING(Service_DSP, "(STUBBED) called");  }  /** @@ -106,7 +106,7 @@ void WriteReg0x10(Service::Interface* self) {      cmd_buff[1] = 0; // No error -    DEBUG_LOG(KERNEL, "(STUBBED) called"); +    LOG_WARNING(Service_DSP, "(STUBBED) called");  }  /** @@ -140,7 +140,7 @@ void ReadPipeIfPossible(Service::Interface* self) {              Memory::Write16(addr + offset, canned_read_pipe[read_pipe_count]);              read_pipe_count++;          } else { -            ERROR_LOG(KERNEL, "canned read pipe log exceeded!"); +            LOG_ERROR(Service_DSP, "canned read pipe log exceeded!");              break;          }      } @@ -148,7 +148,7 @@ void ReadPipeIfPossible(Service::Interface* self) {      cmd_buff[1] = 0; // No error      cmd_buff[2] = (read_pipe_count - initial_size) * sizeof(u16); -    DEBUG_LOG(KERNEL, "(STUBBED) called size=0x%08X, buffer=0x%08X", size, addr); +    LOG_WARNING(Service_DSP, "(STUBBED) called size=0x%08X, buffer=0x%08X", size, addr);  }  const Interface::FunctionInfo FunctionTable[] = { diff --git a/src/core/hle/service/fs_user.cpp b/src/core/hle/service/fs_user.cpp index 51e8b579e..9bda4fe8a 100644 --- a/src/core/hle/service/fs_user.cpp +++ b/src/core/hle/service/fs_user.cpp @@ -23,7 +23,7 @@ static void Initialize(Service::Interface* self) {      // http://3dbrew.org/wiki/FS:Initialize#Request      cmd_buff[1] = RESULT_SUCCESS.raw; -    DEBUG_LOG(KERNEL, "called"); +    LOG_DEBUG(Service_FS, "called");  }  /** @@ -55,17 +55,15 @@ static void OpenFile(Service::Interface* self) {      u32 filename_ptr      = cmd_buff[9];      FileSys::Path file_path(filename_type, filename_size, filename_ptr); -    DEBUG_LOG(KERNEL, "path=%s, mode=%d attrs=%u", file_path.DebugStr().c_str(), mode.hex, attributes); +    LOG_DEBUG(Service_FS, "path=%s, mode=%d attrs=%u", file_path.DebugStr().c_str(), mode.hex, attributes);      ResultVal<Handle> handle = Kernel::OpenFileFromArchive(archive_handle, file_path, mode);      cmd_buff[1] = handle.Code().raw;      if (handle.Succeeded()) {          cmd_buff[3] = *handle;      } else { -        ERROR_LOG(KERNEL, "failed to get a handle for file %s", file_path.DebugStr().c_str()); +        LOG_ERROR(Service_FS, "failed to get a handle for file %s", file_path.DebugStr().c_str());      } - -    DEBUG_LOG(KERNEL, "called");  }  /** @@ -102,11 +100,11 @@ static void OpenFileDirectly(Service::Interface* self) {      FileSys::Path archive_path(archivename_type, archivename_size, archivename_ptr);      FileSys::Path file_path(filename_type, filename_size, filename_ptr); -    DEBUG_LOG(KERNEL, "archive_path=%s file_path=%s, mode=%u attributes=%d", +    LOG_DEBUG(Service_FS, "archive_path=%s file_path=%s, mode=%u attributes=%d",                archive_path.DebugStr().c_str(), file_path.DebugStr().c_str(), mode.hex, attributes);      if (archive_path.GetType() != FileSys::Empty) { -        ERROR_LOG(KERNEL, "archive LowPath type other than empty is currently unsupported"); +        LOG_ERROR(Service_FS, "archive LowPath type other than empty is currently unsupported");          cmd_buff[1] = UnimplementedFunction(ErrorModule::FS).raw;          return;      } @@ -116,7 +114,7 @@ static void OpenFileDirectly(Service::Interface* self) {      ResultVal<Handle> archive_handle = Kernel::OpenArchive(archive_id);      cmd_buff[1] = archive_handle.Code().raw;      if (archive_handle.Failed()) { -        ERROR_LOG(KERNEL, "failed to get a handle for archive"); +        LOG_ERROR(Service_FS, "failed to get a handle for archive");          return;      }      // cmd_buff[2] isn't used according to 3dmoo's implementation. @@ -127,10 +125,8 @@ static void OpenFileDirectly(Service::Interface* self) {      if (handle.Succeeded()) {          cmd_buff[3] = *handle;      } else { -        ERROR_LOG(KERNEL, "failed to get a handle for file %s", file_path.DebugStr().c_str()); +        LOG_ERROR(Service_FS, "failed to get a handle for file %s", file_path.DebugStr().c_str());      } - -    DEBUG_LOG(KERNEL, "called");  }  /* @@ -156,12 +152,10 @@ void DeleteFile(Service::Interface* self) {      FileSys::Path file_path(filename_type, filename_size, filename_ptr); -    DEBUG_LOG(KERNEL, "type=%d size=%d data=%s", +    LOG_DEBUG(Service_FS, "type=%d size=%d data=%s",                filename_type, filename_size, file_path.DebugStr().c_str());      cmd_buff[1] = Kernel::DeleteFileFromArchive(archive_handle, file_path).raw; -     -    DEBUG_LOG(KERNEL, "called");  }  /* @@ -197,13 +191,11 @@ void RenameFile(Service::Interface* self) {      FileSys::Path src_file_path(src_filename_type, src_filename_size, src_filename_ptr);      FileSys::Path dest_file_path(dest_filename_type, dest_filename_size, dest_filename_ptr); -    DEBUG_LOG(KERNEL, "src_type=%d src_size=%d src_data=%s dest_type=%d dest_size=%d dest_data=%s", +    LOG_DEBUG(Service_FS, "src_type=%d src_size=%d src_data=%s dest_type=%d dest_size=%d dest_data=%s",                src_filename_type, src_filename_size, src_file_path.DebugStr().c_str(),                dest_filename_type, dest_filename_size, dest_file_path.DebugStr().c_str());      cmd_buff[1] = Kernel::RenameFileBetweenArchives(src_archive_handle, src_file_path, dest_archive_handle, dest_file_path).raw; -     -    DEBUG_LOG(KERNEL, "called");  }  /* @@ -229,12 +221,10 @@ void DeleteDirectory(Service::Interface* self) {      FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); -    DEBUG_LOG(KERNEL, "type=%d size=%d data=%s", +    LOG_DEBUG(Service_FS, "type=%d size=%d data=%s",                dirname_type, dirname_size, dir_path.DebugStr().c_str());      cmd_buff[1] = Kernel::DeleteDirectoryFromArchive(archive_handle, dir_path).raw; -     -    DEBUG_LOG(KERNEL, "called");  }  /* @@ -260,11 +250,9 @@ static void CreateDirectory(Service::Interface* self) {      FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); -    DEBUG_LOG(KERNEL, "type=%d size=%d data=%s", dirname_type, dirname_size, dir_path.DebugStr().c_str()); +    LOG_DEBUG(Service_FS, "type=%d size=%d data=%s", dirname_type, dirname_size, dir_path.DebugStr().c_str());      cmd_buff[1] = Kernel::CreateDirectoryFromArchive(archive_handle, dir_path).raw; - -    DEBUG_LOG(KERNEL, "called");  }  /* @@ -300,13 +288,11 @@ void RenameDirectory(Service::Interface* self) {      FileSys::Path src_dir_path(src_dirname_type, src_dirname_size, src_dirname_ptr);      FileSys::Path dest_dir_path(dest_dirname_type, dest_dirname_size, dest_dirname_ptr); -    DEBUG_LOG(KERNEL, "src_type=%d src_size=%d src_data=%s dest_type=%d dest_size=%d dest_data=%s", +    LOG_DEBUG(Service_FS, "src_type=%d src_size=%d src_data=%s dest_type=%d dest_size=%d dest_data=%s",                src_dirname_type, src_dirname_size, src_dir_path.DebugStr().c_str(),                dest_dirname_type, dest_dirname_size, dest_dir_path.DebugStr().c_str());      cmd_buff[1] = Kernel::RenameDirectoryBetweenArchives(src_archive_handle, src_dir_path, dest_archive_handle, dest_dir_path).raw; -     -    DEBUG_LOG(KERNEL, "called");  }  static void OpenDirectory(Service::Interface* self) { @@ -321,17 +307,15 @@ static void OpenDirectory(Service::Interface* self) {      FileSys::Path dir_path(dirname_type, dirname_size, dirname_ptr); -    DEBUG_LOG(KERNEL, "type=%d size=%d data=%s", dirname_type, dirname_size, dir_path.DebugStr().c_str()); +    LOG_DEBUG(Service_FS, "type=%d size=%d data=%s", dirname_type, dirname_size, dir_path.DebugStr().c_str());      ResultVal<Handle> handle = Kernel::OpenDirectoryFromArchive(archive_handle, dir_path);      cmd_buff[1] = handle.Code().raw;      if (handle.Succeeded()) {          cmd_buff[3] = *handle;      } else { -        ERROR_LOG(KERNEL, "failed to get a handle for directory"); +        LOG_ERROR(Service_FS, "failed to get a handle for directory");      } - -    DEBUG_LOG(KERNEL, "called");  }  /** @@ -356,10 +340,10 @@ static void OpenArchive(Service::Interface* self) {      u32 archivename_ptr   = cmd_buff[5];      FileSys::Path archive_path(archivename_type, archivename_size, archivename_ptr); -    DEBUG_LOG(KERNEL, "archive_path=%s", archive_path.DebugStr().c_str()); +    LOG_DEBUG(Service_FS, "archive_path=%s", archive_path.DebugStr().c_str());      if (archive_path.GetType() != FileSys::Empty) { -        ERROR_LOG(KERNEL, "archive LowPath type other than empty is currently unsupported"); +        LOG_ERROR(Service_FS, "archive LowPath type other than empty is currently unsupported");          cmd_buff[1] = UnimplementedFunction(ErrorModule::FS).raw;          return;      } @@ -370,10 +354,8 @@ static void OpenArchive(Service::Interface* self) {          // cmd_buff[2] isn't used according to 3dmoo's implementation.          cmd_buff[3] = *handle;      } else { -        ERROR_LOG(KERNEL, "failed to get a handle for archive"); +        LOG_ERROR(Service_FS, "failed to get a handle for archive");      } - -    DEBUG_LOG(KERNEL, "called");  }  /* @@ -388,7 +370,7 @@ static void IsSdmcDetected(Service::Interface* self) {      cmd_buff[1] = 0;      cmd_buff[2] = Settings::values.use_virtual_sd ? 1 : 0; -    DEBUG_LOG(KERNEL, "called"); +    LOG_DEBUG(Service_FS, "called");  }  const Interface::FunctionInfo FunctionTable[] = { diff --git a/src/core/hle/service/gsp_gpu.cpp b/src/core/hle/service/gsp_gpu.cpp index 34eabac45..223800560 100644 --- a/src/core/hle/service/gsp_gpu.cpp +++ b/src/core/hle/service/gsp_gpu.cpp @@ -33,7 +33,7 @@ static inline u8* GetCommandBuffer(u32 thread_id) {  }  static inline FrameBufferUpdate* GetFrameBufferInfo(u32 thread_id, u32 screen_index) { -    _dbg_assert_msg_(GSP, screen_index < 2, "Invalid screen index"); +    _dbg_assert_msg_(Service_GSP, screen_index < 2, "Invalid screen index");      // For each thread there are two FrameBufferUpdate fields      u32 offset = 0x200 + (2 * thread_id + screen_index) * sizeof(FrameBufferUpdate); @@ -50,14 +50,14 @@ static inline InterruptRelayQueue* GetInterruptRelayQueue(u32 thread_id) {  static void WriteHWRegs(u32 base_address, u32 size_in_bytes, const u32* data) {      // TODO: Return proper error codes      if (base_address + size_in_bytes >= 0x420000) { -        ERROR_LOG(GPU, "Write address out of range! (address=0x%08x, size=0x%08x)", +        LOG_ERROR(Service_GSP, "Write address out of range! (address=0x%08x, size=0x%08x)",                    base_address, size_in_bytes);          return;      }      // size should be word-aligned      if ((size_in_bytes % 4) != 0) { -        ERROR_LOG(GPU, "Invalid size 0x%08x", size_in_bytes); +        LOG_ERROR(Service_GSP, "Invalid size 0x%08x", size_in_bytes);          return;      } @@ -89,13 +89,13 @@ static void ReadHWRegs(Service::Interface* self) {      // TODO: Return proper error codes      if (reg_addr + size >= 0x420000) { -        ERROR_LOG(GPU, "Read address out of range! (address=0x%08x, size=0x%08x)", reg_addr, size); +        LOG_ERROR(Service_GSP, "Read address out of range! (address=0x%08x, size=0x%08x)", reg_addr, size);          return;      }      // size should be word-aligned      if ((size % 4) != 0) { -        ERROR_LOG(GPU, "Invalid size 0x%08x", size); +        LOG_ERROR(Service_GSP, "Invalid size 0x%08x", size);          return;      } @@ -177,11 +177,11 @@ static void RegisterInterruptRelayQueue(Service::Interface* self) {   */  void SignalInterrupt(InterruptId interrupt_id) {      if (0 == g_interrupt_event) { -        WARN_LOG(GSP, "cannot synchronize until GSP event has been created!"); +        LOG_WARNING(Service_GSP, "cannot synchronize until GSP event has been created!");          return;      }      if (0 == g_shared_memory) { -        WARN_LOG(GSP, "cannot synchronize until GSP shared memory has been created!"); +        LOG_WARNING(Service_GSP, "cannot synchronize until GSP shared memory has been created!");          return;      }      for (int thread_id = 0; thread_id < 0x4; ++thread_id) { @@ -298,14 +298,14 @@ static void ExecuteCommand(const Command& command, u32 thread_id) {      }      default: -        ERROR_LOG(GSP, "unknown command 0x%08X", (int)command.id.Value()); +        LOG_ERROR(Service_GSP, "unknown command 0x%08X", (int)command.id.Value());      }  }  /// This triggers handling of the GX command written to the command buffer in shared memory.  static void TriggerCmdReqQueue(Service::Interface* self) { -    DEBUG_LOG(GSP, "called"); +    LOG_TRACE(Service_GSP, "called");      // Iterate through each thread's command queue...      for (unsigned thread_id = 0; thread_id < 0x4; ++thread_id) { diff --git a/src/core/hle/service/hid_user.cpp b/src/core/hle/service/hid_user.cpp index 2abaf0f2f..5772199d4 100644 --- a/src/core/hle/service/hid_user.cpp +++ b/src/core/hle/service/hid_user.cpp @@ -163,7 +163,7 @@ static void GetIPCHandles(Service::Interface* self) {      cmd_buff[7] = event_gyroscope;      cmd_buff[8] = event_debug_pad; -    DEBUG_LOG(KERNEL, "called"); +    LOG_TRACE(Service_HID, "called");  }  const Interface::FunctionInfo FunctionTable[] = { diff --git a/src/core/hle/service/ptm_u.cpp b/src/core/hle/service/ptm_u.cpp index 941df467b..559f148dd 100644 --- a/src/core/hle/service/ptm_u.cpp +++ b/src/core/hle/service/ptm_u.cpp @@ -42,7 +42,7 @@ static void GetAdapterState(Service::Interface* self) {      cmd_buff[1] = 0; // No error      cmd_buff[2] = battery_is_charging ? 1 : 0; -    WARN_LOG(KERNEL, "(STUBBED) called"); +    LOG_WARNING(Service_PTM, "(STUBBED) called");  }  /* @@ -57,7 +57,7 @@ static void GetShellState(Service::Interface* self) {      cmd_buff[1] = 0;      cmd_buff[2] = shell_open ? 1 : 0; -    DEBUG_LOG(KERNEL, "PTM_U::GetShellState called"); +    LOG_TRACE(Service_PTM, "PTM_U::GetShellState called");  }  /** @@ -76,7 +76,7 @@ static void GetBatteryLevel(Service::Interface* self) {      cmd_buff[1] = 0; // No error      cmd_buff[2] = static_cast<u32>(ChargeLevels::CompletelyFull); // Set to a completely full battery -    WARN_LOG(KERNEL, "(STUBBED) called"); +    LOG_WARNING(Service_PTM, "(STUBBED) called");  }  /** @@ -94,7 +94,7 @@ static void GetBatteryChargeState(Service::Interface* self) {      cmd_buff[1] = 0; // No error      cmd_buff[2] = battery_is_charging ? 1 : 0; -    WARN_LOG(KERNEL, "(STUBBED) called"); +    LOG_WARNING(Service_PTM, "(STUBBED) called");  }  const Interface::FunctionInfo FunctionTable[] = { diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp index fed2268a0..e6973572b 100644 --- a/src/core/hle/service/service.cpp +++ b/src/core/hle/service/service.cpp @@ -106,13 +106,13 @@ void Init() {      g_manager->AddService(new SOC_U::Interface);      g_manager->AddService(new SSL_C::Interface); -    NOTICE_LOG(HLE, "initialized OK"); +    LOG_DEBUG(Service, "initialized OK");  }  /// Shutdown ServiceManager  void Shutdown() {      delete g_manager; -    NOTICE_LOG(HLE, "shutdown OK"); +    LOG_DEBUG(Service, "shutdown OK");  } diff --git a/src/core/hle/service/service.h b/src/core/hle/service/service.h index 3a7d6c469..baae910a1 100644 --- a/src/core/hle/service/service.h +++ b/src/core/hle/service/service.h @@ -91,7 +91,7 @@ public:              std::string name = (itr == m_functions.end()) ? Common::StringFromFormat("0x%08X", cmd_buff[0]) : itr->second.name; -            ERROR_LOG(OSHLE, error.c_str(), name.c_str(), GetPortName().c_str()); +            LOG_ERROR(Service, error.c_str(), name.c_str(), GetPortName().c_str());              // TODO(bunnei): Hack - ignore error              cmd_buff[1] = 0; @@ -103,12 +103,6 @@ public:          return MakeResult<bool>(false); // TODO: Implement return from actual function      } -    ResultVal<bool> WaitSynchronization() override { -        // TODO(bunnei): ImplementMe -        ERROR_LOG(OSHLE, "unimplemented function"); -        return UnimplementedFunction(ErrorModule::OS); -    } -  protected:      /** diff --git a/src/core/hle/service/srv.cpp b/src/core/hle/service/srv.cpp index 0e7fa9e3b..24a846533 100644 --- a/src/core/hle/service/srv.cpp +++ b/src/core/hle/service/srv.cpp @@ -14,7 +14,7 @@ namespace SRV {  static Handle g_event_handle = 0;  static void Initialize(Service::Interface* self) { -    DEBUG_LOG(OSHLE, "called"); +    LOG_DEBUG(Service_SRV, "called");      u32* cmd_buff = Service::GetCommandBuffer(); @@ -22,7 +22,7 @@ static void Initialize(Service::Interface* self) {  }  static void GetProcSemaphore(Service::Interface* self) { -    DEBUG_LOG(OSHLE, "called"); +    LOG_TRACE(Service_SRV, "called");      u32* cmd_buff = Service::GetCommandBuffer(); @@ -43,9 +43,9 @@ static void GetServiceHandle(Service::Interface* self) {      if (nullptr != service) {          cmd_buff[3] = service->GetHandle(); -        DEBUG_LOG(OSHLE, "called port=%s, handle=0x%08X", port_name.c_str(), cmd_buff[3]); +        LOG_TRACE(Service_SRV, "called port=%s, handle=0x%08X", port_name.c_str(), cmd_buff[3]);      } else { -        ERROR_LOG(OSHLE, "(UNIMPLEMENTED) called port=%s", port_name.c_str()); +        LOG_ERROR(Service_SRV, "(UNIMPLEMENTED) called port=%s", port_name.c_str());          res = UnimplementedFunction(ErrorModule::SRV);      }      cmd_buff[1] = res.raw; diff --git a/src/core/hle/svc.cpp b/src/core/hle/svc.cpp index b99c301d4..db0c42e74 100644 --- a/src/core/hle/svc.cpp +++ b/src/core/hle/svc.cpp @@ -31,7 +31,7 @@ enum ControlMemoryOperation {  /// Map application or GSP heap memory  static Result ControlMemory(u32* out_addr, u32 operation, u32 addr0, u32 addr1, u32 size, u32 permissions) { -    DEBUG_LOG(SVC,"called operation=0x%08X, addr0=0x%08X, addr1=0x%08X, size=%08X, permissions=0x%08X", +    LOG_TRACE(Kernel_SVC,"called operation=0x%08X, addr0=0x%08X, addr1=0x%08X, size=%08X, permissions=0x%08X",          operation, addr0, addr1, size, permissions);      switch (operation) { @@ -48,14 +48,14 @@ static Result ControlMemory(u32* out_addr, u32 operation, u32 addr0, u32 addr1,      // Unknown ControlMemory operation      default: -        ERROR_LOG(SVC, "unknown operation=0x%08X", operation); +        LOG_ERROR(Kernel_SVC, "unknown operation=0x%08X", operation);      }      return 0;  }  /// Maps a memory block to specified address  static Result MapMemoryBlock(Handle handle, u32 addr, u32 permissions, u32 other_permissions) { -    DEBUG_LOG(SVC, "called memblock=0x%08X, addr=0x%08X, mypermissions=0x%08X, otherpermission=%d", +    LOG_TRACE(Kernel_SVC, "called memblock=0x%08X, addr=0x%08X, mypermissions=0x%08X, otherpermission=%d",          handle, addr, permissions, other_permissions);      Kernel::MemoryPermission permissions_type = static_cast<Kernel::MemoryPermission>(permissions); @@ -68,7 +68,7 @@ static Result MapMemoryBlock(Handle handle, u32 addr, u32 permissions, u32 other              static_cast<Kernel::MemoryPermission>(other_permissions));          break;      default: -        ERROR_LOG(OSHLE, "unknown permissions=0x%08X", permissions); +        LOG_ERROR(Kernel_SVC, "unknown permissions=0x%08X", permissions);      }      return 0;  } @@ -77,7 +77,7 @@ static Result MapMemoryBlock(Handle handle, u32 addr, u32 permissions, u32 other  static Result ConnectToPort(Handle* out, const char* port_name) {      Service::Interface* service = Service::g_manager->FetchFromPortName(port_name); -    DEBUG_LOG(SVC, "called port_name=%s", port_name); +    LOG_TRACE(Kernel_SVC, "called port_name=%s", port_name);      _assert_msg_(KERNEL, (service != nullptr), "called, but service is not implemented!");      *out = service->GetHandle(); @@ -95,7 +95,7 @@ static Result SendSyncRequest(Handle handle) {      Kernel::Object* object = Kernel::g_object_pool.GetFast<Kernel::Object>(handle);      _assert_msg_(KERNEL, (object != nullptr), "called, but kernel object is nullptr!"); -    DEBUG_LOG(SVC, "called handle=0x%08X(%s)", handle, object->GetTypeName().c_str()); +    LOG_TRACE(Kernel_SVC, "called handle=0x%08X(%s)", handle, object->GetTypeName().c_str());      ResultVal<bool> wait = object->SyncRequest();      if (wait.Succeeded() && *wait) { @@ -108,7 +108,7 @@ static Result SendSyncRequest(Handle handle) {  /// Close a handle  static Result CloseHandle(Handle handle) {      // ImplementMe -    ERROR_LOG(SVC, "(UNIMPLEMENTED) called handle=0x%08X", handle); +    LOG_ERROR(Kernel_SVC, "(UNIMPLEMENTED) called handle=0x%08X", handle);      return 0;  } @@ -121,9 +121,9 @@ static Result WaitSynchronization1(Handle handle, s64 nano_seconds) {          return InvalidHandle(ErrorModule::Kernel).raw;      }      Kernel::Object* object = Kernel::g_object_pool.GetFast<Kernel::Object>(handle); -    _dbg_assert_(KERNEL, object != nullptr); +    _dbg_assert_(Kernel, object != nullptr); -    DEBUG_LOG(SVC, "called handle=0x%08X(%s:%s), nanoseconds=%lld", handle, object->GetTypeName().c_str(), +    LOG_TRACE(Kernel_SVC, "called handle=0x%08X(%s:%s), nanoseconds=%lld", handle, object->GetTypeName().c_str(),              object->GetName().c_str(), nano_seconds);      ResultVal<bool> wait = object->WaitSynchronization(); @@ -143,7 +143,7 @@ static Result WaitSynchronizationN(s32* out, Handle* handles, s32 handle_count,      bool unlock_all = true;      bool wait_infinite = (nano_seconds == -1); // Used to wait until a thread has terminated -    DEBUG_LOG(SVC, "called handle_count=%d, wait_all=%s, nanoseconds=%lld", +    LOG_TRACE(Kernel_SVC, "called handle_count=%d, wait_all=%s, nanoseconds=%lld",          handle_count, (wait_all ? "true" : "false"), nano_seconds);      // Iterate through each handle, synchronize kernel object @@ -153,7 +153,7 @@ static Result WaitSynchronizationN(s32* out, Handle* handles, s32 handle_count,          }          Kernel::Object* object = Kernel::g_object_pool.GetFast<Kernel::Object>(handles[i]); -        DEBUG_LOG(SVC, "\thandle[%d] = 0x%08X(%s:%s)", i, handles[i], object->GetTypeName().c_str(), +        LOG_TRACE(Kernel_SVC, "\thandle[%d] = 0x%08X(%s:%s)", i, handles[i], object->GetTypeName().c_str(),              object->GetName().c_str());          // TODO(yuriks): Verify how the real function behaves when an error happens here @@ -181,7 +181,7 @@ static Result WaitSynchronizationN(s32* out, Handle* handles, s32 handle_count,  /// Create an address arbiter (to allocate access to shared resources)  static Result CreateAddressArbiter(u32* arbiter) { -    DEBUG_LOG(SVC, "called"); +    LOG_TRACE(Kernel_SVC, "called");      Handle handle = Kernel::CreateAddressArbiter();      *arbiter = handle;      return 0; @@ -189,7 +189,7 @@ static Result CreateAddressArbiter(u32* arbiter) {  /// Arbitrate address  static Result ArbitrateAddress(Handle arbiter, u32 address, u32 type, u32 value, s64 nanoseconds) { -    DEBUG_LOG(SVC, "called handle=0x%08X, address=0x%08X, type=0x%08X, value=0x%08X", arbiter, +    LOG_TRACE(Kernel_SVC, "called handle=0x%08X, address=0x%08X, type=0x%08X, value=0x%08X", arbiter,          address, type, value);      return Kernel::ArbitrateAddress(arbiter, static_cast<Kernel::ArbitrationType>(type),              address, value).raw; @@ -197,7 +197,7 @@ static Result ArbitrateAddress(Handle arbiter, u32 address, u32 type, u32 value,  /// Used to output a message on a debug hardware unit - does nothing on a retail unit  static void OutputDebugString(const char* string) { -    OS_LOG(SVC, "%s", string); +    LOG_DEBUG(Debug_Emulated, "%s", string);  }  /// Get resource limit @@ -206,14 +206,14 @@ static Result GetResourceLimit(Handle* resource_limit, Handle process) {      // 0xFFFF8001 is a handle alias for the current KProcess, and 0xFFFF8000 is a handle alias for      // the current KThread.      *resource_limit = 0xDEADBEEF; -    ERROR_LOG(SVC, "(UNIMPLEMENTED) called process=0x%08X", process); +    LOG_ERROR(Kernel_SVC, "(UNIMPLEMENTED) called process=0x%08X", process);      return 0;  }  /// Get resource limit current values  static Result GetResourceLimitCurrentValues(s64* values, Handle resource_limit, void* names,      s32 name_count) { -    ERROR_LOG(SVC, "(UNIMPLEMENTED) called resource_limit=%08X, names=%s, name_count=%d", +    LOG_ERROR(Kernel_SVC, "(UNIMPLEMENTED) called resource_limit=%08X, names=%s, name_count=%d",          resource_limit, names, name_count);      Memory::Write32(Core::g_app_core->GetReg(0), 0); // Normmatt: Set used memory to 0 for now      return 0; @@ -234,7 +234,7 @@ static Result CreateThread(u32 priority, u32 entry_point, u32 arg, u32 stack_top      Core::g_app_core->SetReg(1, thread); -    DEBUG_LOG(SVC, "called entrypoint=0x%08X (%s), arg=0x%08X, stacktop=0x%08X, " +    LOG_TRACE(Kernel_SVC, "called entrypoint=0x%08X (%s), arg=0x%08X, stacktop=0x%08X, "          "threadpriority=0x%08X, processorid=0x%08X : created handle=0x%08X", entry_point,          name.c_str(), arg, stack_top, priority, processor_id, thread); @@ -245,7 +245,7 @@ static Result CreateThread(u32 priority, u32 entry_point, u32 arg, u32 stack_top  static u32 ExitThread() {      Handle thread = Kernel::GetCurrentThreadHandle(); -    DEBUG_LOG(SVC, "called, pc=0x%08X", Core::g_app_core->GetPC()); // PC = 0x0010545C +    LOG_TRACE(Kernel_SVC, "called, pc=0x%08X", Core::g_app_core->GetPC()); // PC = 0x0010545C      Kernel::StopThread(thread, __func__);      HLE::Reschedule(__func__); @@ -269,42 +269,42 @@ static Result SetThreadPriority(Handle handle, s32 priority) {  /// Create a mutex  static Result CreateMutex(Handle* mutex, u32 initial_locked) {      *mutex = Kernel::CreateMutex((initial_locked != 0)); -    DEBUG_LOG(SVC, "called initial_locked=%s : created handle=0x%08X", +    LOG_TRACE(Kernel_SVC, "called initial_locked=%s : created handle=0x%08X",          initial_locked ? "true" : "false", *mutex);      return 0;  }  /// Release a mutex  static Result ReleaseMutex(Handle handle) { -    DEBUG_LOG(SVC, "called handle=0x%08X", handle); +    LOG_TRACE(Kernel_SVC, "called handle=0x%08X", handle);      ResultCode res = Kernel::ReleaseMutex(handle);      return res.raw;  }  /// Get the ID for the specified thread.  static Result GetThreadId(u32* thread_id, Handle handle) { -    DEBUG_LOG(SVC, "called thread=0x%08X", handle); +    LOG_TRACE(Kernel_SVC, "called thread=0x%08X", handle);      ResultCode result = Kernel::GetThreadId(thread_id, handle);      return result.raw;  }  /// Query memory  static Result QueryMemory(void* info, void* out, u32 addr) { -    ERROR_LOG(SVC, "(UNIMPLEMENTED) called addr=0x%08X", addr); +    LOG_ERROR(Kernel_SVC, "(UNIMPLEMENTED) called addr=0x%08X", addr);      return 0;  }  /// Create an event  static Result CreateEvent(Handle* evt, u32 reset_type) {      *evt = Kernel::CreateEvent((ResetType)reset_type); -    DEBUG_LOG(SVC, "called reset_type=0x%08X : created handle=0x%08X", +    LOG_TRACE(Kernel_SVC, "called reset_type=0x%08X : created handle=0x%08X",          reset_type, *evt);      return 0;  }  /// Duplicates a kernel handle  static Result DuplicateHandle(Handle* out, Handle handle) { -    DEBUG_LOG(SVC, "called handle=0x%08X", handle); +    LOG_WARNING(Kernel_SVC, "(STUBBED) called handle=0x%08X", handle);      // Translate kernel handles -> real handles      if (handle == Kernel::CurrentThread) { @@ -321,19 +321,19 @@ static Result DuplicateHandle(Handle* out, Handle handle) {  /// Signals an event  static Result SignalEvent(Handle evt) { -    DEBUG_LOG(SVC, "called event=0x%08X", evt); +    LOG_TRACE(Kernel_SVC, "called event=0x%08X", evt);      return Kernel::SignalEvent(evt).raw;  }  /// Clears an event  static Result ClearEvent(Handle evt) { -    DEBUG_LOG(SVC, "called event=0x%08X", evt); +    LOG_TRACE(Kernel_SVC, "called event=0x%08X", evt);      return Kernel::ClearEvent(evt).raw;  }  /// Sleep the current thread  static void SleepThread(s64 nanoseconds) { -    DEBUG_LOG(SVC, "called nanoseconds=%lld", nanoseconds); +    LOG_TRACE(Kernel_SVC, "called nanoseconds=%lld", nanoseconds);      // Check for next thread to schedule      HLE::Reschedule(__func__);  | 
