summaryrefslogtreecommitdiff
path: root/src/web_service
diff options
context:
space:
mode:
authorLioncash <mathew1800@gmail.com>2018-10-10 20:59:25 -0400
committerLioncash <mathew1800@gmail.com>2018-10-10 20:59:28 -0400
commit881bb2295d40c50a401cd05fff8eeb822ec577e9 (patch)
tree87f5ed2f86168d9c8a181323f60e9d4f104bfca8 /src/web_service
parenta34e5e51d8c0e2a0c8b6224db806dfe20d0319ce (diff)
telemetry_json: Take std::string parameters by value
Taking them by const reference isn't advisable here, because it means the std::move calls were doing nothing and we were always copying the std::string instances.
Diffstat (limited to 'src/web_service')
-rw-r--r--src/web_service/telemetry_json.cpp3
-rw-r--r--src/web_service/telemetry_json.h2
2 files changed, 2 insertions, 3 deletions
diff --git a/src/web_service/telemetry_json.cpp b/src/web_service/telemetry_json.cpp
index e77950aa3..b24e806a8 100644
--- a/src/web_service/telemetry_json.cpp
+++ b/src/web_service/telemetry_json.cpp
@@ -8,8 +8,7 @@
namespace WebService {
-TelemetryJson::TelemetryJson(const std::string& host, const std::string& username,
- const std::string& token)
+TelemetryJson::TelemetryJson(std::string host, std::string username, std::string token)
: host(std::move(host)), username(std::move(username)), token(std::move(token)) {}
TelemetryJson::~TelemetryJson() = default;
diff --git a/src/web_service/telemetry_json.h b/src/web_service/telemetry_json.h
index 72627a416..92ead9856 100644
--- a/src/web_service/telemetry_json.h
+++ b/src/web_service/telemetry_json.h
@@ -18,7 +18,7 @@ namespace WebService {
*/
class TelemetryJson : public Telemetry::VisitorInterface {
public:
- TelemetryJson(const std::string& host, const std::string& username, const std::string& token);
+ TelemetryJson(std::string host, std::string username, std::string token);
~TelemetryJson();
void Visit(const Telemetry::Field<bool>& field) override;