configuration: Move CreateWidget to a class

We were passing so many objects between the function and the caller that
it needed to be redesigned.

1 files changed, 0 insertions, 386 deletions

diff --git a/src/yuzu/configuration/configuration_shared.cpp b/src/yuzu/configuration/configuration_shared.cpp
index 076d9cc0d..dff70f04b 100644
--- a/src/yuzu/configuration/configuration_shared.cpp
+++ b/src/yuzu/configuration/configuration_shared.cpp
@@ -28,392 +28,6 @@
 
 namespace ConfigurationShared {
 
-static QPushButton* CreateRestoreGlobalButton(QWidget* parent, Settings::BasicSetting* setting) {
-    QStyle* style = parent->style();
-    QIcon* icon = new QIcon(style->standardIcon(QStyle::SP_DialogResetButton));
-    QPushButton* button = new QPushButton(*icon, QStringLiteral(""), parent);
-    button->setSizePolicy(QSizePolicy::Maximum, QSizePolicy::Expanding);
-
-    QSizePolicy sp_retain = button->sizePolicy();
-    sp_retain.setRetainSizeWhenHidden(true);
-    button->setSizePolicy(sp_retain);
-
-    button->setEnabled(!setting->UsingGlobal());
-    button->setVisible(!setting->UsingGlobal());
-
-    return button;
-}
-
-static std::tuple<QWidget*, void*, QPushButton*, std::function<void()>> CreateCheckBox(
-    Settings::BasicSetting* setting, const QString& label, QWidget* parent) {
-    QWidget* widget = new QWidget(parent);
-    QHBoxLayout* layout = new QHBoxLayout(widget);
-
-    QCheckBox* checkbox = new QCheckBox(label, parent);
-    checkbox->setObjectName(QString::fromStdString(setting->GetLabel()));
-    checkbox->setCheckState(setting->ToString() == "true" ? Qt::CheckState::Checked
-                                                          : Qt::CheckState::Unchecked);
-
-    std::function<void()> load_func;
-
-    QPushButton* button{nullptr};
-
-    layout->addWidget(checkbox);
-    if (Settings::IsConfiguringGlobal()) {
-        load_func = [setting, checkbox]() {
-            setting->LoadString(checkbox->checkState() == Qt::Checked ? "true" : "false");
-        };
-    } else {
-        button = CreateRestoreGlobalButton(parent, setting);
-        layout->addWidget(button);
-
-        QObject::connect(checkbox, &QCheckBox::stateChanged, [button](int) {
-            button->setVisible(true);
-            button->setEnabled(true);
-        });
-
-        QObject::connect(button, &QAbstractButton::clicked, [checkbox, setting, button](bool) {
-            checkbox->setCheckState(setting->ToStringGlobal() == "true" ? Qt::Checked
-                                                                        : Qt::Unchecked);
-            button->setEnabled(false);
-            button->setVisible(false);
-        });
-
-        load_func = [setting, checkbox, button]() {
-            bool using_global = !button->isEnabled();
-            setting->SetGlobal(using_global);
-            if (!using_global) {
-                setting->LoadString(checkbox->checkState() == Qt::Checked ? "true" : "false");
-            }
-        };
-    }
-
-    layout->setContentsMargins(0, 0, 0, 0);
-
-    return {widget, checkbox, button, load_func};
-}
-
-static std::tuple<QWidget*, QComboBox*, QPushButton*, std::function<void()>> CreateCombobox(
-    Settings::BasicSetting* setting, const QString& label, QWidget* parent, bool managed) {
-    const auto type = setting->TypeId();
-
-    QWidget* group = new QWidget(parent);
-    group->setObjectName(QString::fromStdString(setting->GetLabel()));
-    QLayout* layout = new QHBoxLayout(group);
-
-    QLabel* qt_label = new QLabel(label, parent);
-    QComboBox* combobox = new QComboBox(parent);
-
-    QPushButton* button{nullptr};
-
-    std::forward_list<QString> combobox_enumerations = ComboboxEnumeration(type, parent);
-    for (const auto& item : combobox_enumerations) {
-        combobox->addItem(item);
-    }
-
-    layout->addWidget(qt_label);
-    layout->addWidget(combobox);
-
-    layout->setSpacing(6);
-    layout->setContentsMargins(0, 0, 0, 0);
-
-    combobox->setCurrentIndex(std::stoi(setting->ToString()));
-
-    std::function<void()> load_func = []() {};
-
-    if (Settings::IsConfiguringGlobal() && managed) {
-        load_func = [setting, combobox]() {
-            setting->LoadString(std::to_string(combobox->currentIndex()));
-        };
-    } else if (managed) {
-        button = CreateRestoreGlobalButton(parent, setting);
-        layout->addWidget(button);
-
-        QObject::connect(button, &QAbstractButton::clicked, [button, combobox, setting](bool) {
-            button->setEnabled(false);
-            button->setVisible(false);
-
-            combobox->setCurrentIndex(std::stoi(setting->ToStringGlobal()));
-        });
-
-        QObject::connect(combobox, QOverload<int>::of(&QComboBox::activated), [=](int) {
-            button->setEnabled(true);
-            button->setVisible(true);
-        });
-
-        load_func = [setting, combobox, button]() {
-            bool using_global = !button->isEnabled();
-            setting->SetGlobal(using_global);
-            if (!using_global) {
-                setting->LoadString(std::to_string(combobox->currentIndex()));
-            }
-        };
-    }
-
-    return {group, combobox, button, load_func};
-}
-
-static std::tuple<QWidget*, void*, QPushButton*, std::function<void()>> CreateLineEdit(
-    Settings::BasicSetting* setting, const QString& label, QWidget* parent, bool managed = true) {
-    QWidget* widget = new QWidget(parent);
-    widget->setObjectName(label);
-
-    QHBoxLayout* layout = new QHBoxLayout(widget);
-    QLineEdit* line_edit = new QLineEdit(parent);
-
-    const QString text = QString::fromStdString(setting->ToString());
-    line_edit->setText(text);
-
-    std::function<void()> load_func = []() {};
-
-    QLabel* q_label = new QLabel(label, widget);
-    // setSizePolicy lets widget expand and take an equal part of the space as the line edit
-    q_label->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Preferred);
-    layout->addWidget(q_label);
-
-    layout->addWidget(line_edit);
-
-    QPushButton* button{nullptr};
-
-    if (Settings::IsConfiguringGlobal() && !managed) {
-        load_func = [line_edit, setting]() {
-            std::string load_text = line_edit->text().toStdString();
-            setting->LoadString(load_text);
-        };
-    } else if (!managed) {
-        button = CreateRestoreGlobalButton(parent, setting);
-        layout->addWidget(button);
-
-        QObject::connect(button, &QAbstractButton::clicked, [=](bool) {
-            button->setEnabled(false);
-            button->setVisible(false);
-
-            line_edit->setText(QString::fromStdString(setting->ToStringGlobal()));
-        });
-
-        QObject::connect(line_edit, &QLineEdit::textChanged, [=](QString) {
-            button->setEnabled(true);
-            button->setVisible(true);
-        });
-
-        load_func = [=]() {
-            bool using_global = !button->isEnabled();
-            setting->SetGlobal(using_global);
-            if (!using_global) {
-                setting->LoadString(line_edit->text().toStdString());
-            }
-        };
-    }
-
-    layout->setContentsMargins(0, 0, 0, 0);
-
-    return {widget, line_edit, button, load_func};
-}
-
-static std::tuple<QWidget*, void*, QPushButton*, std::function<void()>> CreateSlider(
-    Settings::BasicSetting* setting, const QString& name, QWidget* parent, bool reversed,
-    float multiplier) {
-    QWidget* widget = new QWidget(parent);
-    QHBoxLayout* layout = new QHBoxLayout(widget);
-    QSlider* slider = new QSlider(Qt::Horizontal, widget);
-    QLabel* label = new QLabel(name, widget);
-    QPushButton* button{nullptr};
-    QLabel* feedback = new QLabel(widget);
-
-    layout->addWidget(label);
-    layout->addWidget(slider);
-    layout->addWidget(feedback);
-
-    label->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Preferred);
-
-    layout->setContentsMargins(0, 0, 0, 0);
-
-    int max_val = std::stoi(setting->MaxVal());
-
-    QObject::connect(slider, &QAbstractSlider::valueChanged, [=](int value) {
-        int present = (reversed ? max_val - value : value) * multiplier;
-        feedback->setText(
-            QStringLiteral("%1%").arg(QString::fromStdString(std::to_string(present))));
-    });
-
-    slider->setValue(std::stoi(setting->ToString()));
-    slider->setMinimum(std::stoi(setting->MinVal()));
-    slider->setMaximum(max_val);
-
-    if (reversed) {
-        slider->setInvertedAppearance(true);
-    }
-
-    std::function<void()> load_func;
-
-    if (Settings::IsConfiguringGlobal()) {
-        load_func = [=]() { setting->LoadString(std::to_string(slider->value())); };
-    } else {
-        button = CreateRestoreGlobalButton(parent, setting);
-        layout->addWidget(button);
-
-        QObject::connect(button, &QAbstractButton::clicked, [=](bool) {
-            slider->setValue(std::stoi(setting->ToStringGlobal()));
-
-            button->setEnabled(false);
-            button->setVisible(false);
-        });
-
-        QObject::connect(slider, &QAbstractSlider::sliderMoved, [=](int) {
-            button->setEnabled(true);
-            button->setVisible(true);
-        });
-
-        load_func = [=]() {
-            bool using_global = !button->isEnabled();
-            setting->SetGlobal(using_global);
-            if (!using_global) {
-                setting->LoadString(std::to_string(slider->value()));
-            }
-        };
-    }
-
-    return {widget, slider, button, []() {}};
-}
-
-static std::tuple<QWidget*, void*, void*, QPushButton*, std::function<void()>>
-CreateCheckBoxWithLineEdit(Settings::BasicSetting* setting, const QString& label, QWidget* parent) {
-    auto tuple = CreateCheckBox(setting, label, parent);
-    auto* widget = std::get<0>(tuple);
-    auto* checkbox = std::get<1>(tuple);
-    auto* button = std::get<2>(tuple);
-    auto load_func = std::get<3>(tuple);
-    QHBoxLayout* layout = dynamic_cast<QHBoxLayout*>(widget->layout());
-
-    auto line_edit_tuple = CreateLineEdit(setting, label, parent, false);
-    auto* line_edit_widget = std::get<0>(line_edit_tuple);
-    auto* line_edit = std::get<1>(line_edit_tuple);
-
-    layout->insertWidget(1, line_edit_widget);
-
-    return {widget, checkbox, line_edit, button, load_func};
-}
-
-std::tuple<QWidget*, void*, QPushButton*> CreateWidget(
-    Settings::BasicSetting* setting, const TranslationMap& translations, QWidget* parent,
-    bool runtime_lock, std::forward_list<std::function<void(bool)>>& apply_funcs,
-    RequestType request, bool managed, float multiplier, const std::string& text_box_default) {
-    if (!Settings::IsConfiguringGlobal() && !setting->Switchable()) {
-        LOG_DEBUG(Frontend, "\"{}\" is not switchable, skipping...", setting->GetLabel());
-        return {nullptr, nullptr, nullptr};
-    }
-
-    const auto type = setting->TypeId();
-    const int id = setting->Id();
-    QWidget* widget{nullptr};
-    void* extra{nullptr};
-
-    std::function<void()> load_func;
-
-    const auto [label, tooltip] = [&]() {
-        const auto& setting_label = setting->GetLabel();
-        if (translations.contains(id)) {
-            return std::pair{translations.at(id).first, translations.at(id).second};
-        }
-        LOG_ERROR(Frontend, "Translation table lacks entry for \"{}\"", setting_label);
-        return std::pair{QString::fromStdString(setting_label), QStringLiteral("")};
-    }();
-
-    if (label == QStringLiteral("")) {
-        LOG_DEBUG(Frontend, "Translation table has emtpy entry for \"{}\", skipping...",
-                  setting->GetLabel());
-        return {nullptr, nullptr, nullptr};
-    }
-
-    QPushButton* button;
-
-    if (type == typeid(bool)) {
-        switch (request) {
-        case RequestType::Default: {
-            auto tuple = CreateCheckBox(setting, label, parent);
-            widget = std::get<0>(tuple);
-            extra = std::get<1>(tuple);
-            button = std::get<2>(tuple);
-            load_func = std::get<3>(tuple);
-            break;
-        }
-        case RequestType::LineEdit: {
-            auto tuple = CreateCheckBoxWithLineEdit(setting, label, parent);
-            widget = std::get<0>(tuple);
-            break;
-        }
-        case RequestType::ComboBox:
-        case RequestType::SpinBox:
-        case RequestType::Slider:
-        case RequestType::ReverseSlider:
-        case RequestType::MaxEnum:
-            break;
-        }
-    } else if (setting->IsEnum()) {
-        auto tuple = CreateCombobox(setting, label, parent, managed);
-        widget = std::get<0>(tuple);
-        extra = std::get<1>(tuple);
-        button = std::get<2>(tuple);
-        load_func = std::get<3>(tuple);
-    } else if (type == typeid(u32) || type == typeid(int)) {
-        switch (request) {
-        case RequestType::LineEdit:
-        case RequestType::Default: {
-            auto tuple = CreateLineEdit(setting, label, parent);
-            widget = std::get<0>(tuple);
-            extra = std::get<1>(tuple);
-            button = std::get<2>(tuple);
-            load_func = std::get<3>(tuple);
-            break;
-        }
-        case RequestType::ComboBox: {
-            auto tuple = CreateCombobox(setting, label, parent, managed);
-            widget = std::get<0>(tuple);
-            extra = std::get<1>(tuple);
-            button = std::get<2>(tuple);
-            load_func = std::get<3>(tuple);
-            break;
-        }
-        case RequestType::Slider:
-        case RequestType::ReverseSlider: {
-            auto tuple = CreateSlider(setting, label, parent, request == RequestType::ReverseSlider,
-                                      multiplier);
-            widget = std::get<0>(tuple);
-            extra = std::get<1>(tuple);
-            button = std::get<2>(tuple);
-            load_func = std::get<3>(tuple);
-            break;
-        }
-        case RequestType::SpinBox:
-        case RequestType::MaxEnum:
-            break;
-        }
-    }
-
-    if (widget == nullptr) {
-        LOG_ERROR(Frontend, "No widget was created for \"{}\"", setting->GetLabel());
-        return {nullptr, nullptr, nullptr};
-    }
-
-    apply_funcs.push_front([load_func, setting](bool powered_on) {
-        if (setting->RuntimeModfiable() || !powered_on) {
-            load_func();
-        }
-    });
-
-    bool enable = runtime_lock || setting->RuntimeModfiable();
-    if (setting->Switchable() && Settings::IsConfiguringGlobal() && !runtime_lock) {
-        enable &= !setting->UsingGlobal();
-    }
-    widget->setEnabled(enable);
-
-    widget->setVisible(Settings::IsConfiguringGlobal() || setting->Switchable());
-
-    widget->setToolTip(tooltip);
-
-    return {widget, extra, button};
-}
-
 Tab::Tab(std::shared_ptr<std::forward_list<Tab*>> group_, QWidget* parent)
     : QWidget(parent), group{group_} {
     if (group != nullptr) {