summaryrefslogtreecommitdiff
path: root/src/yuzu/configuration/configure_audio.cpp
diff options
context:
space:
mode:
authorlat9nq <22451773+lat9nq@users.noreply.github.com>2023-06-15 16:45:42 -0400
committerlat9nq <22451773+lat9nq@users.noreply.github.com>2023-07-21 10:56:54 -0400
commita7ee9d999f612dcf5e9fcf68b410a3b49039d8ed (patch)
tree5231b80e8ec0e0423a7478f988ea98bbf975a3bd /src/yuzu/configuration/configure_audio.cpp
parent6935332cbab11b08ce6b644c48c6d82e94bd90f9 (diff)
configuration: Use shorter constructor as needed
Reduces some confusion hopefully, since some parameters specified were not specific to the setting in question.
Diffstat (limited to 'src/yuzu/configuration/configure_audio.cpp')
-rw-r--r--src/yuzu/configuration/configure_audio.cpp9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/yuzu/configuration/configure_audio.cpp b/src/yuzu/configuration/configure_audio.cpp
index 98c6b6f44..c90316725 100644
--- a/src/yuzu/configuration/configure_audio.cpp
+++ b/src/yuzu/configuration/configure_audio.cpp
@@ -54,14 +54,15 @@ void ConfigureAudio::Setup() {
auto* widget = [&]() {
if (setting->Id() == Settings::values.volume.Id()) {
// volume needs to be a slider (default is line edit)
- return new ConfigurationShared::Widget(
- setting, translations, combobox_translations, this, runtime_lock, apply_funcs,
- ConfigurationShared::RequestType::Slider, true, 1.0f, nullptr,
- tr("%1%", "Volume percentage (e.g. 50%)"));
+ return new ConfigurationShared::Widget(setting, translations, combobox_translations,
+ this, runtime_lock, apply_funcs, nullptr,
+ ConfigurationShared::RequestType::Slider,
+ tr("%1%", "Volume percentage (e.g. 50%)"));
} else if (setting->Id() == Settings::values.audio_output_device_id.Id() ||
setting->Id() == Settings::values.audio_input_device_id.Id() ||
setting->Id() == Settings::values.sink_id.Id()) {
// These need to be unmanaged comboboxes, so we can populate them ourselves
+ // TODO (lat9nq): Let it manage sink_id
return new ConfigurationShared::Widget(
setting, translations, combobox_translations, this, runtime_lock, apply_funcs,
ConfigurationShared::RequestType::ComboBox, false);