summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorReinUsesLisp <reinuseslisp@airmail.cc>2021-04-22 18:29:59 -0300
committerameerj <52414509+ameerj@users.noreply.github.com>2021-07-22 21:51:29 -0400
commit92a01984e6315f3c214990926c8fa5b4474ed339 (patch)
treee7f4daea4da9141a0f4d0b668777098671a16bf0 /src
parentaece958c2ba5d4fe37246a6a7502d182931a7483 (diff)
shader: Remove invalidated blocks in dead code elimination pass
Diffstat (limited to 'src')
-rw-r--r--src/shader_recompiler/ir_opt/dead_code_elimination_pass.cpp9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/shader_recompiler/ir_opt/dead_code_elimination_pass.cpp b/src/shader_recompiler/ir_opt/dead_code_elimination_pass.cpp
index f9c5334b5..1e4a3fdae 100644
--- a/src/shader_recompiler/ir_opt/dead_code_elimination_pass.cpp
+++ b/src/shader_recompiler/ir_opt/dead_code_elimination_pass.cpp
@@ -14,9 +14,12 @@ void DeadCodeEliminationPass(IR::Program& program) {
// We iterate over the instructions in reverse order.
// This is because removing an instruction reduces the number of uses for earlier instructions.
for (IR::Block* const block : program.post_order_blocks) {
- for (IR::Inst& inst : block->Instructions() | std::views::reverse) {
- if (!inst.HasUses() && !inst.MayHaveSideEffects()) {
- inst.Invalidate();
+ auto it{block->end()};
+ while (it != block->begin()) {
+ --it;
+ if (!it->HasUses() && !it->MayHaveSideEffects()) {
+ it->Invalidate();
+ it = block->Instructions().erase(it);
}
}
}