diff options
author | Fernando Sahmkow <fsahmkow27@gmail.com> | 2019-05-18 20:51:54 -0400 |
---|---|---|
committer | FernandoS27 <fsahmkow27@gmail.com> | 2019-05-19 10:48:31 -0400 |
commit | 9e98100c9493f5a04de45002e8b4b1cd07b2b685 (patch) | |
tree | 20cd15c22ad9d0cb545f375dac1fc2ed5d9f03a1 /src | |
parent | fb85d5670d54e526035d83f66f7689eebda73be2 (diff) |
Dma_pusher: ASSERT on empty command_list
This is a measure to avoid crashes on command list reading as an empty
command_list is considered a NOP.
Diffstat (limited to 'src')
-rw-r--r-- | src/video_core/dma_pusher.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/video_core/dma_pusher.cpp b/src/video_core/dma_pusher.cpp index 036e66f05..3175579cc 100644 --- a/src/video_core/dma_pusher.cpp +++ b/src/video_core/dma_pusher.cpp @@ -40,6 +40,13 @@ bool DmaPusher::Step() { } const CommandList& command_list{dma_pushbuffer.front()}; + ASSERT_OR_EXECUTE(!command_list.empty(), { + // Somehow the command_list is empty, in order to avoid a crash + // We ignore it and assume its size is 0. + dma_pushbuffer.pop(); + dma_pushbuffer_subindex = 0; + return true; + }); const CommandListHeader command_list_header{command_list[dma_pushbuffer_subindex++]}; GPUVAddr dma_get = command_list_header.addr; GPUVAddr dma_put = dma_get + command_list_header.size * sizeof(u32); |