diff options
author | Lioncash <mathew1800@gmail.com> | 2018-01-17 20:08:02 -0500 |
---|---|---|
committer | Lioncash <mathew1800@gmail.com> | 2018-01-17 20:09:41 -0500 |
commit | b16c89bf659503687cef67782127e7694e98f0d3 (patch) | |
tree | 88d66fde318ce2cb92d024a90a1c4af0428f3f57 /src | |
parent | ee08c39b7251c6a037014b503ecf70ebf8dc5ed5 (diff) |
vi: Copy data directly into the std::vector within Parcel's ReadBlock function
Previously this would unnecessarily zero-initialize the vector before
copying the actual data into the vector instance.
Diffstat (limited to 'src')
-rw-r--r-- | src/core/hle/service/vi/vi.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp index cae2c4466..57ad4c59c 100644 --- a/src/core/hle/service/vi/vi.cpp +++ b/src/core/hle/service/vi/vi.cpp @@ -47,8 +47,9 @@ public: } std::vector<u8> ReadBlock(size_t length) { - std::vector<u8> data(length); - std::memcpy(data.data(), buffer.data() + read_index, length); + const u8* const begin = buffer.data() + read_index; + const u8* const end = begin + length; + std::vector<u8> data(begin, end); read_index += length; read_index = Common::AlignUp(read_index, 4); return data; |