summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2018-08-20 22:15:56 -0400
committerGitHub <noreply@github.com>2018-08-20 22:15:56 -0400
commitc4ce7e456a1cb86faa99f00479fe50b427a16026 (patch)
tree49a04f9de6091b00c0c2646f759ef9b8785e6224 /src
parente33452f7e8c80c8eb6e4704af6b53f7fb7aa596d (diff)
parentb5fb246a99962b69079a6742b602d58a3f15a843 (diff)
Merge pull request #1126 from lioncash/telem
telemetry_session: Don't allocate std::string instances for program lifetime in GetTelemetryId() and RegenerateTelemetryId()
Diffstat (limited to 'src')
-rw-r--r--src/core/telemetry_session.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/core/telemetry_session.cpp b/src/core/telemetry_session.cpp
index 7e4584fc2..69383330f 100644
--- a/src/core/telemetry_session.cpp
+++ b/src/core/telemetry_session.cpp
@@ -19,8 +19,8 @@ static u64 GenerateTelemetryId() {
u64 GetTelemetryId() {
u64 telemetry_id{};
- static const std::string& filename{FileUtil::GetUserPath(FileUtil::UserPath::ConfigDir) +
- "telemetry_id"};
+ const std::string filename{FileUtil::GetUserPath(FileUtil::UserPath::ConfigDir) +
+ "telemetry_id"};
if (FileUtil::Exists(filename)) {
FileUtil::IOFile file(filename, "rb");
@@ -44,8 +44,8 @@ u64 GetTelemetryId() {
u64 RegenerateTelemetryId() {
const u64 new_telemetry_id{GenerateTelemetryId()};
- static const std::string& filename{FileUtil::GetUserPath(FileUtil::UserPath::ConfigDir) +
- "telemetry_id"};
+ const std::string filename{FileUtil::GetUserPath(FileUtil::UserPath::ConfigDir) +
+ "telemetry_id"};
FileUtil::IOFile file(filename, "wb");
if (!file.IsOpen()) {