diff options
author | liamwhite <liamwhite@users.noreply.github.com> | 2022-10-21 03:47:02 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-10-21 03:47:02 -0400 |
commit | efaedcab312b4ead2757bd5f06d3e57688d61cd4 (patch) | |
tree | 995ae08f705b60810339db1041f090139cd15e99 /src | |
parent | 49682a0481946f3a9e4938cb795e4f89f03dd241 (diff) | |
parent | 0b181eeef4f56a814ea6c9b86d789be3ab8d1ae5 (diff) |
Merge pull request #9106 from lioncash/copy-err
hid/npad: Fix copy size in GetSupportedNpadIdTypes
Diffstat (limited to 'src')
-rw-r--r-- | src/core/hle/service/hid/controllers/npad.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/core/hle/service/hid/controllers/npad.cpp b/src/core/hle/service/hid/controllers/npad.cpp index 98e4f2af7..ba8a1f786 100644 --- a/src/core/hle/service/hid/controllers/npad.cpp +++ b/src/core/hle/service/hid/controllers/npad.cpp @@ -745,8 +745,9 @@ void Controller_NPad::SetSupportedNpadIdTypes(u8* data, std::size_t length) { } void Controller_NPad::GetSupportedNpadIdTypes(u32* data, std::size_t max_length) { - ASSERT(max_length < supported_npad_id_types.size()); - std::memcpy(data, supported_npad_id_types.data(), supported_npad_id_types.size()); + const auto copy_amount = supported_npad_id_types.size() * sizeof(u32); + ASSERT(max_length <= copy_amount); + std::memcpy(data, supported_npad_id_types.data(), copy_amount); } std::size_t Controller_NPad::GetSupportedNpadIdTypesSize() const { |