diff options
| -rw-r--r-- | src/common/settings.h | 2 | ||||
| -rw-r--r-- | src/yuzu/configuration/config.cpp | 2 | ||||
| -rw-r--r-- | src/yuzu/configuration/configure_graphics_advanced.cpp | 6 | ||||
| -rw-r--r-- | src/yuzu/configuration/configure_graphics_advanced.h | 1 | ||||
| -rw-r--r-- | src/yuzu/configuration/configure_graphics_advanced.ui | 18 | ||||
| -rw-r--r-- | src/yuzu/main.cpp | 10 | 
6 files changed, 10 insertions, 29 deletions
| diff --git a/src/common/settings.h b/src/common/settings.h index d2e91a2c9..71d0f864f 100644 --- a/src/common/settings.h +++ b/src/common/settings.h @@ -330,7 +330,7 @@ struct Values {      Setting<bool> use_nvdec_emulation{true, "use_nvdec_emulation"};      Setting<bool> accelerate_astc{true, "accelerate_astc"};      Setting<bool> use_vsync{true, "use_vsync"}; -    Setting<bool> disable_fps_limit{false, "disable_fps_limit"}; +    BasicSetting<bool> disable_fps_limit{false, "disable_fps_limit"};      Setting<bool> use_assembly_shaders{false, "use_assembly_shaders"};      Setting<bool> use_asynchronous_shaders{false, "use_asynchronous_shaders"};      Setting<bool> use_fast_gpu_time{true, "use_fast_gpu_time"}; diff --git a/src/yuzu/configuration/config.cpp b/src/yuzu/configuration/config.cpp index 87cb9dc93..8c71ad5c1 100644 --- a/src/yuzu/configuration/config.cpp +++ b/src/yuzu/configuration/config.cpp @@ -839,7 +839,6 @@ void Config::ReadRendererValues() {      ReadGlobalSetting(Settings::values.use_nvdec_emulation);      ReadGlobalSetting(Settings::values.accelerate_astc);      ReadGlobalSetting(Settings::values.use_vsync); -    ReadGlobalSetting(Settings::values.disable_fps_limit);      ReadGlobalSetting(Settings::values.use_assembly_shaders);      ReadGlobalSetting(Settings::values.use_asynchronous_shaders);      ReadGlobalSetting(Settings::values.use_fast_gpu_time); @@ -1369,7 +1368,6 @@ void Config::SaveRendererValues() {      WriteGlobalSetting(Settings::values.use_nvdec_emulation);      WriteGlobalSetting(Settings::values.accelerate_astc);      WriteGlobalSetting(Settings::values.use_vsync); -    WriteGlobalSetting(Settings::values.disable_fps_limit);      WriteGlobalSetting(Settings::values.use_assembly_shaders);      WriteGlobalSetting(Settings::values.use_asynchronous_shaders);      WriteGlobalSetting(Settings::values.use_fast_gpu_time); diff --git a/src/yuzu/configuration/configure_graphics_advanced.cpp b/src/yuzu/configuration/configure_graphics_advanced.cpp index 8d13c9857..a9e611125 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.cpp +++ b/src/yuzu/configuration/configure_graphics_advanced.cpp @@ -28,7 +28,6 @@ void ConfigureGraphicsAdvanced::SetConfiguration() {      ui->anisotropic_filtering_combobox->setEnabled(runtime_lock);      ui->use_vsync->setChecked(Settings::values.use_vsync.GetValue()); -    ui->disable_fps_limit->setChecked(Settings::values.disable_fps_limit.GetValue());      ui->use_assembly_shaders->setChecked(Settings::values.use_assembly_shaders.GetValue());      ui->use_asynchronous_shaders->setChecked(Settings::values.use_asynchronous_shaders.GetValue());      ui->use_caches_gc->setChecked(Settings::values.use_caches_gc.GetValue()); @@ -59,8 +58,6 @@ void ConfigureGraphicsAdvanced::ApplyConfiguration() {      ConfigurationShared::ApplyPerGameSetting(&Settings::values.max_anisotropy,                                               ui->anisotropic_filtering_combobox);      ConfigurationShared::ApplyPerGameSetting(&Settings::values.use_vsync, ui->use_vsync, use_vsync); -    ConfigurationShared::ApplyPerGameSetting(&Settings::values.disable_fps_limit, -                                             ui->disable_fps_limit, disable_fps_limit);      ConfigurationShared::ApplyPerGameSetting(&Settings::values.use_assembly_shaders,                                               ui->use_assembly_shaders, use_assembly_shaders);      ConfigurationShared::ApplyPerGameSetting(&Settings::values.use_asynchronous_shaders, @@ -103,7 +100,6 @@ void ConfigureGraphicsAdvanced::SetupPerGameUI() {      if (Settings::IsConfiguringGlobal()) {          ui->gpu_accuracy->setEnabled(Settings::values.gpu_accuracy.UsingGlobal());          ui->use_vsync->setEnabled(Settings::values.use_vsync.UsingGlobal()); -        ui->disable_fps_limit->setEnabled(Settings::values.disable_fps_limit.UsingGlobal());          ui->use_assembly_shaders->setEnabled(Settings::values.use_assembly_shaders.UsingGlobal());          ui->use_asynchronous_shaders->setEnabled(              Settings::values.use_asynchronous_shaders.UsingGlobal()); @@ -116,8 +112,6 @@ void ConfigureGraphicsAdvanced::SetupPerGameUI() {      }      ConfigurationShared::SetColoredTristate(ui->use_vsync, Settings::values.use_vsync, use_vsync); -    ConfigurationShared::SetColoredTristate(ui->disable_fps_limit, -                                            Settings::values.disable_fps_limit, disable_fps_limit);      ConfigurationShared::SetColoredTristate(          ui->use_assembly_shaders, Settings::values.use_assembly_shaders, use_assembly_shaders);      ConfigurationShared::SetColoredTristate(ui->use_asynchronous_shaders, diff --git a/src/yuzu/configuration/configure_graphics_advanced.h b/src/yuzu/configuration/configure_graphics_advanced.h index 6ac5f20ec..9148aacf2 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.h +++ b/src/yuzu/configuration/configure_graphics_advanced.h @@ -35,7 +35,6 @@ private:      std::unique_ptr<Ui::ConfigureGraphicsAdvanced> ui;      ConfigurationShared::CheckState use_vsync; -    ConfigurationShared::CheckState disable_fps_limit;      ConfigurationShared::CheckState use_assembly_shaders;      ConfigurationShared::CheckState use_asynchronous_shaders;      ConfigurationShared::CheckState use_fast_gpu_time; diff --git a/src/yuzu/configuration/configure_graphics_advanced.ui b/src/yuzu/configuration/configure_graphics_advanced.ui index 18c43629e..ad0840355 100644 --- a/src/yuzu/configuration/configure_graphics_advanced.ui +++ b/src/yuzu/configuration/configure_graphics_advanced.ui @@ -77,24 +77,6 @@           </widget>          </item>          <item> -         <widget class="QCheckBox" name="disable_fps_limit"> -          <property name="enabled"> -           <bool>true</bool> -          </property> -          <property name="toolTip"> -           <string> -            <html><head/><body> -            <p>Presents guest frames as they become available, disabling the FPS limit in most titles.</p> -            <p>NOTE: Will cause instabilities.</p> -            </body></html> -           </string> -          </property> -          <property name="text"> -           <string>Disable framerate limit (experimental)</string> -          </property> -         </widget> -        </item> -        <item>           <widget class="QCheckBox" name="use_assembly_shaders">            <property name="toolTip">             <string>Enabling this reduces shader stutter. Enables OpenGL assembly shaders on supported Nvidia devices (NV_gpu_program5 is required). This feature is experimental.</string> diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp index 5ed3b90b8..cb9c01154 100644 --- a/src/yuzu/main.cpp +++ b/src/yuzu/main.cpp @@ -1355,6 +1355,9 @@ void GMainWindow::BootGame(const QString& filename, std::size_t program_index, S      ConfigureVibration::SetAllVibrationDevices(); +    // Disable fps limit toggle when booting a new title +    Settings::values.disable_fps_limit.SetValue(false); +      // Save configurations      UpdateUISettings();      game_list->SaveInterfaceLayout(); @@ -2913,7 +2916,12 @@ void GMainWindow::UpdateStatusBar() {      } else {          emu_speed_label->setText(tr("Speed: %1%").arg(results.emulation_speed * 100.0, 0, 'f', 0));      } -    game_fps_label->setText(tr("Game: %1 FPS").arg(results.average_game_fps, 0, 'f', 0)); +    if (Settings::values.disable_fps_limit) { +        game_fps_label->setText( +            tr("Game: %1 FPS (Limit off)").arg(results.average_game_fps, 0, 'f', 0)); +    } else { +        game_fps_label->setText(tr("Game: %1 FPS").arg(results.average_game_fps, 0, 'f', 0)); +    }      emu_frametime_label->setText(tr("Frame: %1 ms").arg(results.frametime * 1000.0, 0, 'f', 2));      emu_speed_label->setVisible(!Settings::values.use_multi_core.GetValue()); | 
