diff options
| -rw-r--r-- | .gitmodules | 2 | ||||
| -rw-r--r-- | CMakeLists.txt | 3 | ||||
| -rw-r--r-- | src/common/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | src/common/platform.h | 34 | ||||
| -rw-r--r-- | src/core/hle/service/vi/vi.cpp | 242 | ||||
| -rw-r--r-- | src/core/hle/service/vi/vi.h | 34 | ||||
| -rw-r--r-- | src/core/hle/service/vi/vi_m.cpp | 15 | ||||
| -rw-r--r-- | src/core/hle/service/vi/vi_m.h | 17 | ||||
| -rw-r--r-- | src/core/hle/service/vi/vi_s.cpp | 15 | ||||
| -rw-r--r-- | src/core/hle/service/vi/vi_s.h | 17 | ||||
| -rw-r--r-- | src/core/hle/service/vi/vi_u.cpp | 15 | ||||
| -rw-r--r-- | src/core/hle/service/vi/vi_u.h | 17 | ||||
| -rw-r--r-- | src/yuzu/main.cpp | 1 | 
13 files changed, 164 insertions, 249 deletions
| diff --git a/.gitmodules b/.gitmodules index d5a7ade4f..a08850c1a 100644 --- a/.gitmodules +++ b/.gitmodules @@ -18,7 +18,7 @@      url = https://github.com/fmtlib/fmt.git  [submodule "lz4"]      path = externals/lz4 -    url = http://github.com/lz4/lz4.git +    url = https://github.com/lz4/lz4.git  [submodule "unicorn"]      path = externals/unicorn      url = https://github.com/yuzu-emu/unicorn diff --git a/CMakeLists.txt b/CMakeLists.txt index 1fcf0874f..bcd169643 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -160,6 +160,9 @@ set_property(DIRECTORY APPEND PROPERTY      COMPILE_DEFINITIONS $<$<CONFIG:Debug>:_DEBUG> $<$<NOT:$<CONFIG:Debug>>:NDEBUG>) +math(EXPR EMU_ARCH_BITS ${CMAKE_SIZEOF_VOID_P}*8) +add_definitions(-DEMU_ARCH_BITS=${EMU_ARCH_BITS}) +  # System imported libraries  # ====================== diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt index d132ab969..581c46b52 100644 --- a/src/common/CMakeLists.txt +++ b/src/common/CMakeLists.txt @@ -58,7 +58,6 @@ add_library(common STATIC      misc.cpp      param_package.cpp      param_package.h -    platform.h      quaternion.h      scm_rev.cpp      scm_rev.h diff --git a/src/common/platform.h b/src/common/platform.h deleted file mode 100644 index c62fb7c8f..000000000 --- a/src/common/platform.h +++ /dev/null @@ -1,34 +0,0 @@ -/** - * Copyright (C) 2005-2012 Gekko Emulator - * - * @file    platform.h - * @author  ShizZy <shizzy247@gmail.com> - * @date    2012-02-11 - * @brief   Platform detection macros for portable compilation - * - * @section LICENSE - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License as - * published by the Free Software Foundation; either version 2 of - * the License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details at - * http://www.gnu.org/copyleft/gpl.html - * - * Official project repository can be found at: - * http://code.google.com/p/gekko-gc-emu/ - */ - -#pragma once - -//////////////////////////////////////////////////////////////////////////////////////////////////// -// Platform detection - -#if defined(ARCHITECTURE_x86_64) || defined(__aarch64__) -#define EMU_ARCH_BITS 64 -#elif defined(__i386) || defined(_M_IX86) || defined(__arm__) || defined(_M_ARM) -#define EMU_ARCH_BITS 32 -#endif diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp index 6135eabf8..06c34e979 100644 --- a/src/core/hle/service/vi/vi.cpp +++ b/src/core/hle/service/vi/vi.cpp @@ -4,10 +4,13 @@  #include <algorithm>  #include <array> +#include <memory> +#include <boost/optional.hpp>  #include "common/alignment.h"  #include "common/scope_exit.h"  #include "core/core_timing.h"  #include "core/hle/ipc_helpers.h" +#include "core/hle/kernel/event.h"  #include "core/hle/service/nvdrv/nvdrv.h"  #include "core/hle/service/nvflinger/buffer_queue.h"  #include "core/hle/service/vi/vi.h" @@ -646,144 +649,152 @@ private:      std::shared_ptr<NVFlinger::NVFlinger> nv_flinger;  }; -void IApplicationDisplayService::GetRelayService(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); +class IApplicationDisplayService final : public ServiceFramework<IApplicationDisplayService> { +public: +    IApplicationDisplayService(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); +    ~IApplicationDisplayService() = default; -    IPC::ResponseBuilder rb{ctx, 2, 0, 1}; -    rb.Push(RESULT_SUCCESS); -    rb.PushIpcInterface<IHOSBinderDriver>(nv_flinger); -} +private: +    void GetRelayService(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); -void IApplicationDisplayService::GetSystemDisplayService(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); +        IPC::ResponseBuilder rb{ctx, 2, 0, 1}; +        rb.Push(RESULT_SUCCESS); +        rb.PushIpcInterface<IHOSBinderDriver>(nv_flinger); +    } -    IPC::ResponseBuilder rb{ctx, 2, 0, 1}; -    rb.Push(RESULT_SUCCESS); -    rb.PushIpcInterface<ISystemDisplayService>(); -} +    void GetSystemDisplayService(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); -void IApplicationDisplayService::GetManagerDisplayService(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); +        IPC::ResponseBuilder rb{ctx, 2, 0, 1}; +        rb.Push(RESULT_SUCCESS); +        rb.PushIpcInterface<ISystemDisplayService>(); +    } -    IPC::ResponseBuilder rb{ctx, 2, 0, 1}; -    rb.Push(RESULT_SUCCESS); -    rb.PushIpcInterface<IManagerDisplayService>(nv_flinger); -} +    void GetManagerDisplayService(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); -void IApplicationDisplayService::GetIndirectDisplayTransactionService( -    Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); +        IPC::ResponseBuilder rb{ctx, 2, 0, 1}; +        rb.Push(RESULT_SUCCESS); +        rb.PushIpcInterface<IManagerDisplayService>(nv_flinger); +    } -    IPC::ResponseBuilder rb{ctx, 2, 0, 1}; -    rb.Push(RESULT_SUCCESS); -    rb.PushIpcInterface<IHOSBinderDriver>(nv_flinger); -} +    void GetIndirectDisplayTransactionService(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); -void IApplicationDisplayService::OpenDisplay(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); -    IPC::RequestParser rp{ctx}; -    auto name_buf = rp.PopRaw<std::array<u8, 0x40>>(); -    auto end = std::find(name_buf.begin(), name_buf.end(), '\0'); +        IPC::ResponseBuilder rb{ctx, 2, 0, 1}; +        rb.Push(RESULT_SUCCESS); +        rb.PushIpcInterface<IHOSBinderDriver>(nv_flinger); +    } -    std::string name(name_buf.begin(), end); +    void OpenDisplay(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); +        IPC::RequestParser rp{ctx}; +        auto name_buf = rp.PopRaw<std::array<u8, 0x40>>(); +        auto end = std::find(name_buf.begin(), name_buf.end(), '\0'); -    ASSERT_MSG(name == "Default", "Non-default displays aren't supported yet"); +        std::string name(name_buf.begin(), end); -    IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0); -    rb.Push(RESULT_SUCCESS); -    rb.Push<u64>(nv_flinger->OpenDisplay(name)); -} +        ASSERT_MSG(name == "Default", "Non-default displays aren't supported yet"); -void IApplicationDisplayService::CloseDisplay(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); -    IPC::RequestParser rp{ctx}; -    u64 display_id = rp.Pop<u64>(); +        IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0); +        rb.Push(RESULT_SUCCESS); +        rb.Push<u64>(nv_flinger->OpenDisplay(name)); +    } -    IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); -    rb.Push(RESULT_SUCCESS); -} +    void CloseDisplay(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); +        IPC::RequestParser rp{ctx}; +        u64 display_id = rp.Pop<u64>(); -void IApplicationDisplayService::OpenLayer(Kernel::HLERequestContext& ctx) { -    LOG_DEBUG(Service_VI, "called"); -    IPC::RequestParser rp{ctx}; -    auto name_buf = rp.PopRaw<std::array<u8, 0x40>>(); -    auto end = std::find(name_buf.begin(), name_buf.end(), '\0'); +        IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); +        rb.Push(RESULT_SUCCESS); +    } -    std::string display_name(name_buf.begin(), end); +    void SetLayerScalingMode(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); +        IPC::RequestParser rp{ctx}; +        u32 scaling_mode = rp.Pop<u32>(); +        u64 unknown = rp.Pop<u64>(); -    u64 layer_id = rp.Pop<u64>(); -    u64 aruid = rp.Pop<u64>(); +        IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); +        rb.Push(RESULT_SUCCESS); +    } -    u64 display_id = nv_flinger->OpenDisplay(display_name); -    u32 buffer_queue_id = nv_flinger->GetBufferQueueId(display_id, layer_id); +    void ListDisplays(Kernel::HLERequestContext& ctx) { +        IPC::RequestParser rp{ctx}; +        DisplayInfo display_info; +        ctx.WriteBuffer(&display_info, sizeof(DisplayInfo)); +        IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0); +        rb.Push(RESULT_SUCCESS); +        rb.Push<u64>(1); +        LOG_WARNING(Service_VI, "(STUBBED) called"); +    } -    NativeWindow native_window{buffer_queue_id}; -    IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0); -    rb.Push(RESULT_SUCCESS); -    rb.Push<u64>(ctx.WriteBuffer(native_window.Serialize())); -} +    void OpenLayer(Kernel::HLERequestContext& ctx) { +        LOG_DEBUG(Service_VI, "called"); +        IPC::RequestParser rp{ctx}; +        auto name_buf = rp.PopRaw<std::array<u8, 0x40>>(); +        auto end = std::find(name_buf.begin(), name_buf.end(), '\0'); -void IApplicationDisplayService::CreateStrayLayer(Kernel::HLERequestContext& ctx) { -    LOG_DEBUG(Service_VI, "called"); +        std::string display_name(name_buf.begin(), end); -    IPC::RequestParser rp{ctx}; -    u32 flags = rp.Pop<u32>(); -    rp.Pop<u32>(); // padding -    u64 display_id = rp.Pop<u64>(); +        u64 layer_id = rp.Pop<u64>(); +        u64 aruid = rp.Pop<u64>(); -    // TODO(Subv): What's the difference between a Stray and a Managed layer? +        u64 display_id = nv_flinger->OpenDisplay(display_name); +        u32 buffer_queue_id = nv_flinger->GetBufferQueueId(display_id, layer_id); -    u64 layer_id = nv_flinger->CreateLayer(display_id); -    u32 buffer_queue_id = nv_flinger->GetBufferQueueId(display_id, layer_id); +        NativeWindow native_window{buffer_queue_id}; +        IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0); +        rb.Push(RESULT_SUCCESS); +        rb.Push<u64>(ctx.WriteBuffer(native_window.Serialize())); +    } -    NativeWindow native_window{buffer_queue_id}; -    IPC::ResponseBuilder rb = rp.MakeBuilder(6, 0, 0); -    rb.Push(RESULT_SUCCESS); -    rb.Push(layer_id); -    rb.Push<u64>(ctx.WriteBuffer(native_window.Serialize())); -} +    void CreateStrayLayer(Kernel::HLERequestContext& ctx) { +        LOG_DEBUG(Service_VI, "called"); -void IApplicationDisplayService::DestroyStrayLayer(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); +        IPC::RequestParser rp{ctx}; +        u32 flags = rp.Pop<u32>(); +        rp.Pop<u32>(); // padding +        u64 display_id = rp.Pop<u64>(); -    IPC::RequestParser rp{ctx}; -    u64 layer_id = rp.Pop<u64>(); +        // TODO(Subv): What's the difference between a Stray and a Managed layer? -    IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); -    rb.Push(RESULT_SUCCESS); -} +        u64 layer_id = nv_flinger->CreateLayer(display_id); +        u32 buffer_queue_id = nv_flinger->GetBufferQueueId(display_id, layer_id); -void IApplicationDisplayService::SetLayerScalingMode(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); -    IPC::RequestParser rp{ctx}; -    u32 scaling_mode = rp.Pop<u32>(); -    u64 unknown = rp.Pop<u64>(); +        NativeWindow native_window{buffer_queue_id}; +        IPC::ResponseBuilder rb = rp.MakeBuilder(6, 0, 0); +        rb.Push(RESULT_SUCCESS); +        rb.Push(layer_id); +        rb.Push<u64>(ctx.WriteBuffer(native_window.Serialize())); +    } -    IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); -    rb.Push(RESULT_SUCCESS); -} +    void DestroyStrayLayer(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); -void IApplicationDisplayService::ListDisplays(Kernel::HLERequestContext& ctx) { -    IPC::RequestParser rp{ctx}; -    DisplayInfo display_info; -    ctx.WriteBuffer(&display_info, sizeof(DisplayInfo)); -    IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0); -    rb.Push(RESULT_SUCCESS); -    rb.Push<u64>(1); -    LOG_WARNING(Service_VI, "(STUBBED) called"); -} +        IPC::RequestParser rp{ctx}; +        u64 layer_id = rp.Pop<u64>(); -void IApplicationDisplayService::GetDisplayVsyncEvent(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); -    IPC::RequestParser rp{ctx}; -    u64 display_id = rp.Pop<u64>(); +        IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0); +        rb.Push(RESULT_SUCCESS); +    } -    auto vsync_event = nv_flinger->GetVsyncEvent(display_id); +    void GetDisplayVsyncEvent(Kernel::HLERequestContext& ctx) { +        LOG_WARNING(Service_VI, "(STUBBED) called"); +        IPC::RequestParser rp{ctx}; +        u64 display_id = rp.Pop<u64>(); -    IPC::ResponseBuilder rb = rp.MakeBuilder(2, 1, 0); -    rb.Push(RESULT_SUCCESS); -    rb.PushCopyObjects(vsync_event); -} +        auto vsync_event = nv_flinger->GetVsyncEvent(display_id); + +        IPC::ResponseBuilder rb = rp.MakeBuilder(2, 1, 0); +        rb.Push(RESULT_SUCCESS); +        rb.PushCopyObjects(vsync_event); +    } + +    std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; +};  IApplicationDisplayService::IApplicationDisplayService(      std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) @@ -806,11 +817,24 @@ IApplicationDisplayService::IApplicationDisplayService(      RegisterHandlers(functions);  } +Module::Interface::Interface(std::shared_ptr<Module> module, const char* name, +                             std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) +    : ServiceFramework(name), module(std::move(module)), nv_flinger(std::move(nv_flinger)) {} + +void Module::Interface::GetDisplayService(Kernel::HLERequestContext& ctx) { +    LOG_WARNING(Service_VI, "(STUBBED) called"); + +    IPC::ResponseBuilder rb{ctx, 2, 0, 1}; +    rb.Push(RESULT_SUCCESS); +    rb.PushIpcInterface<IApplicationDisplayService>(nv_flinger); +} +  void InstallInterfaces(SM::ServiceManager& service_manager,                         std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) { -    std::make_shared<VI_M>(nv_flinger)->InstallAsService(service_manager); -    std::make_shared<VI_S>(nv_flinger)->InstallAsService(service_manager); -    std::make_shared<VI_U>(nv_flinger)->InstallAsService(service_manager); +    auto module = std::make_shared<Module>(); +    std::make_shared<VI_M>(module, nv_flinger)->InstallAsService(service_manager); +    std::make_shared<VI_S>(module, nv_flinger)->InstallAsService(service_manager); +    std::make_shared<VI_U>(module, nv_flinger)->InstallAsService(service_manager);  }  } // namespace VI diff --git a/src/core/hle/service/vi/vi.h b/src/core/hle/service/vi/vi.h index f6be7d1e6..985c9d27c 100644 --- a/src/core/hle/service/vi/vi.h +++ b/src/core/hle/service/vi/vi.h @@ -4,9 +4,6 @@  #pragma once -#include <memory> -#include <boost/optional.hpp> -#include "core/hle/kernel/event.h"  #include "core/hle/service/nvflinger/nvflinger.h"  #include "core/hle/service/service.h" @@ -17,26 +14,19 @@ struct EventType;  namespace Service {  namespace VI { -class IApplicationDisplayService final : public ServiceFramework<IApplicationDisplayService> { +class Module final {  public: -    IApplicationDisplayService(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); -    ~IApplicationDisplayService() = default; - -private: -    void GetRelayService(Kernel::HLERequestContext& ctx); -    void GetSystemDisplayService(Kernel::HLERequestContext& ctx); -    void GetManagerDisplayService(Kernel::HLERequestContext& ctx); -    void GetIndirectDisplayTransactionService(Kernel::HLERequestContext& ctx); -    void OpenDisplay(Kernel::HLERequestContext& ctx); -    void CloseDisplay(Kernel::HLERequestContext& ctx); -    void SetLayerScalingMode(Kernel::HLERequestContext& ctx); -    void ListDisplays(Kernel::HLERequestContext& ctx); -    void OpenLayer(Kernel::HLERequestContext& ctx); -    void CreateStrayLayer(Kernel::HLERequestContext& ctx); -    void DestroyStrayLayer(Kernel::HLERequestContext& ctx); -    void GetDisplayVsyncEvent(Kernel::HLERequestContext& ctx); - -    std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; +    class Interface : public ServiceFramework<Interface> { +    public: +        Interface(std::shared_ptr<Module> module, const char* name, +                  std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); + +        void GetDisplayService(Kernel::HLERequestContext& ctx); + +    protected: +        std::shared_ptr<Module> module; +        std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; +    };  };  /// Registers all VI services with the specified service manager. diff --git a/src/core/hle/service/vi/vi_m.cpp b/src/core/hle/service/vi/vi_m.cpp index 5d99647dc..5781fa9ec 100644 --- a/src/core/hle/service/vi/vi_m.cpp +++ b/src/core/hle/service/vi/vi_m.cpp @@ -2,24 +2,13 @@  // Licensed under GPLv2 or any later version  // Refer to the license.txt file included. -#include "common/logging/log.h" -#include "core/hle/ipc_helpers.h" -#include "core/hle/service/vi/vi.h"  #include "core/hle/service/vi/vi_m.h"  namespace Service {  namespace VI { -void VI_M::GetDisplayService(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); - -    IPC::ResponseBuilder rb{ctx, 2, 0, 1}; -    rb.Push(RESULT_SUCCESS); -    rb.PushIpcInterface<IApplicationDisplayService>(nv_flinger); -} - -VI_M::VI_M(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) -    : ServiceFramework("vi:m"), nv_flinger(std::move(nv_flinger)) { +VI_M::VI_M(std::shared_ptr<Module> module, std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) +    : Module::Interface(std::move(module), "vi:m", std::move(nv_flinger)) {      static const FunctionInfo functions[] = {          {2, &VI_M::GetDisplayService, "GetDisplayService"},          {3, nullptr, "GetDisplayServiceWithProxyNameExchange"}, diff --git a/src/core/hle/service/vi/vi_m.h b/src/core/hle/service/vi/vi_m.h index e5319b1e7..0f7b799d6 100644 --- a/src/core/hle/service/vi/vi_m.h +++ b/src/core/hle/service/vi/vi_m.h @@ -4,25 +4,14 @@  #pragma once -#include <memory> -#include "core/hle/service/service.h" +#include "core/hle/service/vi/vi.h"  namespace Service { -namespace NVFlinger { -class NVFlinger; -} -  namespace VI { -class VI_M final : public ServiceFramework<VI_M> { +class VI_M final : public Module::Interface {  public: -    VI_M(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); -    ~VI_M() = default; - -private: -    void GetDisplayService(Kernel::HLERequestContext& ctx); - -    std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; +    explicit VI_M(std::shared_ptr<Module> module, std::shared_ptr<NVFlinger::NVFlinger> nv_flinger);  };  } // namespace VI diff --git a/src/core/hle/service/vi/vi_s.cpp b/src/core/hle/service/vi/vi_s.cpp index 411757981..1f937b2a8 100644 --- a/src/core/hle/service/vi/vi_s.cpp +++ b/src/core/hle/service/vi/vi_s.cpp @@ -2,24 +2,13 @@  // Licensed under GPLv2 or any later version  // Refer to the license.txt file included. -#include "common/logging/log.h" -#include "core/hle/ipc_helpers.h" -#include "core/hle/service/vi/vi.h"  #include "core/hle/service/vi/vi_s.h"  namespace Service {  namespace VI { -void VI_S::GetDisplayService(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); - -    IPC::ResponseBuilder rb{ctx, 2, 0, 1}; -    rb.Push(RESULT_SUCCESS); -    rb.PushIpcInterface<IApplicationDisplayService>(nv_flinger); -} - -VI_S::VI_S(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) -    : ServiceFramework("vi:s"), nv_flinger(std::move(nv_flinger)) { +VI_S::VI_S(std::shared_ptr<Module> module, std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) +    : Module::Interface(std::move(module), "vi:s", std::move(nv_flinger)) {      static const FunctionInfo functions[] = {          {1, &VI_S::GetDisplayService, "GetDisplayService"},          {3, nullptr, "GetDisplayServiceWithProxyNameExchange"}, diff --git a/src/core/hle/service/vi/vi_s.h b/src/core/hle/service/vi/vi_s.h index 6978fd700..7b32fdddc 100644 --- a/src/core/hle/service/vi/vi_s.h +++ b/src/core/hle/service/vi/vi_s.h @@ -4,25 +4,14 @@  #pragma once -#include <memory> -#include "core/hle/service/service.h" +#include "core/hle/service/vi/vi.h"  namespace Service { -namespace NVFlinger { -class NVFlinger; -} -  namespace VI { -class VI_S final : public ServiceFramework<VI_S> { +class VI_S final : public Module::Interface {  public: -    VI_S(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); -    ~VI_S() = default; - -private: -    void GetDisplayService(Kernel::HLERequestContext& ctx); - -    std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; +    explicit VI_S(std::shared_ptr<Module> module, std::shared_ptr<NVFlinger::NVFlinger> nv_flinger);  };  } // namespace VI diff --git a/src/core/hle/service/vi/vi_u.cpp b/src/core/hle/service/vi/vi_u.cpp index f5568383b..14e375b86 100644 --- a/src/core/hle/service/vi/vi_u.cpp +++ b/src/core/hle/service/vi/vi_u.cpp @@ -2,24 +2,13 @@  // Licensed under GPLv2 or any later version  // Refer to the license.txt file included. -#include "common/logging/log.h" -#include "core/hle/ipc_helpers.h" -#include "core/hle/service/vi/vi.h"  #include "core/hle/service/vi/vi_u.h"  namespace Service {  namespace VI { -void VI_U::GetDisplayService(Kernel::HLERequestContext& ctx) { -    LOG_WARNING(Service_VI, "(STUBBED) called"); - -    IPC::ResponseBuilder rb{ctx, 2, 0, 1}; -    rb.Push(RESULT_SUCCESS); -    rb.PushIpcInterface<IApplicationDisplayService>(nv_flinger); -} - -VI_U::VI_U(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) -    : ServiceFramework("vi:u"), nv_flinger(std::move(nv_flinger)) { +VI_U::VI_U(std::shared_ptr<Module> module, std::shared_ptr<NVFlinger::NVFlinger> nv_flinger) +    : Module::Interface(std::move(module), "vi:u", std::move(nv_flinger)) {      static const FunctionInfo functions[] = {          {0, &VI_U::GetDisplayService, "GetDisplayService"},          {3, nullptr, "GetDisplayServiceWithProxyNameExchange"}, diff --git a/src/core/hle/service/vi/vi_u.h b/src/core/hle/service/vi/vi_u.h index b3e9c094d..c557a2235 100644 --- a/src/core/hle/service/vi/vi_u.h +++ b/src/core/hle/service/vi/vi_u.h @@ -4,25 +4,14 @@  #pragma once -#include <memory> -#include "core/hle/service/service.h" +#include "core/hle/service/vi/vi.h"  namespace Service { -namespace NVFlinger { -class NVFlinger; -} -  namespace VI { -class VI_U final : public ServiceFramework<VI_U> { +class VI_U final : public Module::Interface {  public: -    VI_U(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); -    ~VI_U() = default; - -private: -    void GetDisplayService(Kernel::HLERequestContext& ctx); - -    std::shared_ptr<NVFlinger::NVFlinger> nv_flinger; +    explicit VI_U(std::shared_ptr<Module> module, std::shared_ptr<NVFlinger::NVFlinger> nv_flinger);  };  } // namespace VI diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp index 5802b9855..eb22a8ccf 100644 --- a/src/yuzu/main.cpp +++ b/src/yuzu/main.cpp @@ -18,7 +18,6 @@  #include "common/logging/log.h"  #include "common/logging/text_formatter.h"  #include "common/microprofile.h" -#include "common/platform.h"  #include "common/scm_rev.h"  #include "common/scope_exit.h"  #include "common/string_util.h" | 
