diff options
Diffstat (limited to 'src/common')
| -rw-r--r-- | src/common/common_funcs.h | 6 | ||||
| -rw-r--r-- | src/common/fs/path_util.cpp | 44 | ||||
| -rw-r--r-- | src/common/fs/path_util.h | 8 | ||||
| -rw-r--r-- | src/common/host_memory.cpp | 38 | ||||
| -rw-r--r-- | src/common/host_memory.h | 2 | ||||
| -rw-r--r-- | src/common/settings.cpp | 2 | ||||
| -rw-r--r-- | src/common/settings.h | 10 | ||||
| -rw-r--r-- | src/common/settings_common.h | 1 | ||||
| -rw-r--r-- | src/common/settings_setting.h | 5 | 
9 files changed, 86 insertions, 30 deletions
diff --git a/src/common/common_funcs.h b/src/common/common_funcs.h index 47d028d48..ba3081efb 100644 --- a/src/common/common_funcs.h +++ b/src/common/common_funcs.h @@ -123,6 +123,12 @@ namespace Common {      return u32(a) | u32(b) << 8 | u32(c) << 16 | u32(d) << 24;  } +[[nodiscard]] constexpr u64 MakeMagic(char a, char b, char c, char d, char e, char f, char g, +                                      char h) { +    return u64(a) << 0 | u64(b) << 8 | u64(c) << 16 | u64(d) << 24 | u64(e) << 32 | u64(f) << 40 | +           u64(g) << 48 | u64(h) << 56; +} +  // std::size() does not support zero-size C arrays. We're fixing that.  template <class C>  constexpr auto Size(const C& c) -> decltype(c.size()) { diff --git a/src/common/fs/path_util.cpp b/src/common/fs/path_util.cpp index c3a81f9a9..4f69db6f5 100644 --- a/src/common/fs/path_util.cpp +++ b/src/common/fs/path_util.cpp @@ -354,18 +354,36 @@ std::string_view RemoveTrailingSlash(std::string_view path) {      return path;  } -std::vector<std::string> SplitPathComponents(std::string_view filename) { -    std::string copy(filename); -    std::replace(copy.begin(), copy.end(), '\\', '/'); -    std::vector<std::string> out; - -    std::stringstream stream(copy); -    std::string item; -    while (std::getline(stream, item, '/')) { -        out.push_back(std::move(item)); +template <typename F> +static void ForEachPathComponent(std::string_view filename, F&& cb) { +    const char* component_begin = filename.data(); +    const char* const end = component_begin + filename.size(); +    for (const char* it = component_begin; it != end; ++it) { +        const char c = *it; +        if (c == '\\' || c == '/') { +            if (component_begin != it) { +                cb(std::string_view{component_begin, it}); +            } +            component_begin = it + 1; +        } +    } +    if (component_begin != end) { +        cb(std::string_view{component_begin, end});      } +} + +std::vector<std::string_view> SplitPathComponents(std::string_view filename) { +    std::vector<std::string_view> components; +    ForEachPathComponent(filename, [&](auto component) { components.emplace_back(component); }); -    return out; +    return components; +} + +std::vector<std::string> SplitPathComponentsCopy(std::string_view filename) { +    std::vector<std::string> components; +    ForEachPathComponent(filename, [&](auto component) { components.emplace_back(component); }); + +    return components;  }  std::string SanitizePath(std::string_view path_, DirectorySeparator directory_separator) { @@ -400,9 +418,9 @@ std::string SanitizePath(std::string_view path_, DirectorySeparator directory_se      return std::string(RemoveTrailingSlash(path));  } -std::string_view GetParentPath(std::string_view path) { +std::string GetParentPath(std::string_view path) {      if (path.empty()) { -        return path; +        return std::string(path);      }  #ifdef ANDROID @@ -421,7 +439,7 @@ std::string_view GetParentPath(std::string_view path) {          name_index = std::max(name_bck_index, name_fwd_index);      } -    return path.substr(0, name_index); +    return std::string(path.substr(0, name_index));  }  std::string_view GetPathWithoutTop(std::string_view path) { diff --git a/src/common/fs/path_util.h b/src/common/fs/path_util.h index 2874ea738..59301e7ed 100644 --- a/src/common/fs/path_util.h +++ b/src/common/fs/path_util.h @@ -289,7 +289,11 @@ enum class DirectorySeparator {  // Splits the path on '/' or '\' and put the components into a vector  // i.e. "C:\Users\Yuzu\Documents\save.bin" becomes {"C:", "Users", "Yuzu", "Documents", "save.bin" } -[[nodiscard]] std::vector<std::string> SplitPathComponents(std::string_view filename); +[[nodiscard]] std::vector<std::string_view> SplitPathComponents(std::string_view filename); + +// Splits the path on '/' or '\' and put the components into a vector +// i.e. "C:\Users\Yuzu\Documents\save.bin" becomes {"C:", "Users", "Yuzu", "Documents", "save.bin" } +[[nodiscard]] std::vector<std::string> SplitPathComponentsCopy(std::string_view filename);  // Removes trailing slash, makes all '\\' into '/', and removes duplicate '/'. Makes '/' into '\\'  // depending if directory_separator is BackwardSlash or PlatformDefault and running on windows @@ -298,7 +302,7 @@ enum class DirectorySeparator {      DirectorySeparator directory_separator = DirectorySeparator::ForwardSlash);  // Gets all of the text up to the last '/' or '\' in the path. -[[nodiscard]] std::string_view GetParentPath(std::string_view path); +[[nodiscard]] std::string GetParentPath(std::string_view path);  // Gets all of the text after the first '/' or '\' in the path.  [[nodiscard]] std::string_view GetPathWithoutTop(std::string_view path); diff --git a/src/common/host_memory.cpp b/src/common/host_memory.cpp index 4bfc64f2d..e540375b8 100644 --- a/src/common/host_memory.cpp +++ b/src/common/host_memory.cpp @@ -11,10 +11,6 @@  #elif defined(__linux__) || defined(__FreeBSD__) // ^^^ Windows ^^^ vvv Linux vvv -#ifdef ANDROID -#include <android/sharedmem.h> -#endif -  #ifndef _GNU_SOURCE  #define _GNU_SOURCE  #endif @@ -193,6 +189,11 @@ public:          }      } +    bool ClearBackingRegion(size_t physical_offset, size_t length) { +        // TODO: This does not seem to be possible on Windows. +        return false; +    } +      void EnableDirectMappedAddress() {          // TODO          UNREACHABLE(); @@ -442,9 +443,7 @@ public:          }          // Backing memory initialization -#ifdef ANDROID -        fd = ASharedMemory_create("HostMemory", backing_size); -#elif defined(__FreeBSD__) && __FreeBSD__ < 13 +#if defined(__FreeBSD__) && __FreeBSD__ < 13          // XXX Drop after FreeBSD 12.* reaches EOL on 2024-06-30          fd = shm_open(SHM_ANON, O_RDWR, 0600);  #else @@ -455,7 +454,6 @@ public:              throw std::bad_alloc{};          } -#ifndef ANDROID          // Defined to extend the file with zeros          int ret = ftruncate(fd, backing_size);          if (ret != 0) { @@ -463,7 +461,6 @@ public:                           strerror(errno));              throw std::bad_alloc{};          } -#endif          backing_base = static_cast<u8*>(              mmap(nullptr, backing_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0)); @@ -552,6 +549,19 @@ public:          ASSERT_MSG(ret == 0, "mprotect failed: {}", strerror(errno));      } +    bool ClearBackingRegion(size_t physical_offset, size_t length) { +#ifdef __linux__ +        // Set MADV_REMOVE on backing map to destroy it instantly. +        // This also deletes the area from the backing file. +        int ret = madvise(backing_base + physical_offset, length, MADV_REMOVE); +        ASSERT_MSG(ret == 0, "madvise failed: {}", strerror(errno)); + +        return true; +#else +        return false; +#endif +    } +      void EnableDirectMappedAddress() {          virtual_base = nullptr;      } @@ -623,6 +633,10 @@ public:      void Protect(size_t virtual_offset, size_t length, bool read, bool write, bool execute) {} +    bool ClearBackingRegion(size_t physical_offset, size_t length) { +        return false; +    } +      void EnableDirectMappedAddress() {}      u8* backing_base{nullptr}; @@ -698,6 +712,12 @@ void HostMemory::Protect(size_t virtual_offset, size_t length, bool read, bool w      impl->Protect(virtual_offset + virtual_base_offset, length, read, write, execute);  } +void HostMemory::ClearBackingRegion(size_t physical_offset, size_t length, u32 fill_value) { +    if (!impl || fill_value != 0 || !impl->ClearBackingRegion(physical_offset, length)) { +        std::memset(backing_base + physical_offset, fill_value, length); +    } +} +  void HostMemory::EnableDirectMappedAddress() {      if (impl) {          impl->EnableDirectMappedAddress(); diff --git a/src/common/host_memory.h b/src/common/host_memory.h index cebfacab2..747c5850c 100644 --- a/src/common/host_memory.h +++ b/src/common/host_memory.h @@ -48,6 +48,8 @@ public:      void EnableDirectMappedAddress(); +    void ClearBackingRegion(size_t physical_offset, size_t length, u32 fill_value); +      [[nodiscard]] u8* BackingBasePointer() noexcept {          return backing_base;      } diff --git a/src/common/settings.cpp b/src/common/settings.cpp index 88f509ba7..ea52bbfa6 100644 --- a/src/common/settings.cpp +++ b/src/common/settings.cpp @@ -211,6 +211,8 @@ const char* TranslateCategory(Category category) {      case Category::Debugging:      case Category::DebuggingGraphics:          return "Debugging"; +    case Category::GpuDriver: +        return "GpuDriver";      case Category::Miscellaneous:          return "Miscellaneous";      case Category::Network: diff --git a/src/common/settings.h b/src/common/settings.h index 7dc18fffe..07dba53ab 100644 --- a/src/common/settings.h +++ b/src/common/settings.h @@ -197,7 +197,7 @@ struct Values {      SwitchableSetting<CpuAccuracy, true> cpu_accuracy{linkage,           CpuAccuracy::Auto,                                                        CpuAccuracy::Auto, CpuAccuracy::Paranoid,                                                        "cpu_accuracy",    Category::Cpu}; -    Setting<bool> cpu_debug_mode{linkage, false, "cpu_debug_mode", Category::CpuDebug}; +    SwitchableSetting<bool> cpu_debug_mode{linkage, false, "cpu_debug_mode", Category::CpuDebug};      Setting<bool> cpuopt_page_tables{linkage, true, "cpuopt_page_tables", Category::CpuDebug};      Setting<bool> cpuopt_block_linking{linkage, true, "cpuopt_block_linking", Category::CpuDebug}; @@ -211,9 +211,9 @@ struct Values {      Setting<bool> cpuopt_misc_ir{linkage, true, "cpuopt_misc_ir", Category::CpuDebug};      Setting<bool> cpuopt_reduce_misalign_checks{linkage, true, "cpuopt_reduce_misalign_checks",                                                  Category::CpuDebug}; -    Setting<bool> cpuopt_fastmem{linkage, true, "cpuopt_fastmem", Category::CpuDebug}; -    Setting<bool> cpuopt_fastmem_exclusives{linkage, true, "cpuopt_fastmem_exclusives", -                                            Category::CpuDebug}; +    SwitchableSetting<bool> cpuopt_fastmem{linkage, true, "cpuopt_fastmem", Category::CpuDebug}; +    SwitchableSetting<bool> cpuopt_fastmem_exclusives{linkage, true, "cpuopt_fastmem_exclusives", +                                                      Category::CpuDebug};      Setting<bool> cpuopt_recompile_exclusives{linkage, true, "cpuopt_recompile_exclusives",                                                Category::CpuDebug};      Setting<bool> cpuopt_ignore_memory_aborts{linkage, true, "cpuopt_ignore_memory_aborts", @@ -256,7 +256,7 @@ struct Values {                                                              AstcDecodeMode::CpuAsynchronous,                                                              "accelerate_astc",                                                              Category::Renderer}; -    Setting<VSyncMode, true> vsync_mode{ +    SwitchableSetting<VSyncMode, true> vsync_mode{          linkage,     VSyncMode::Fifo,    VSyncMode::Immediate,        VSyncMode::FifoRelaxed,          "use_vsync", Category::Renderer, Specialization::RuntimeList, true,          true}; diff --git a/src/common/settings_common.h b/src/common/settings_common.h index 344c04439..c82e17495 100644 --- a/src/common/settings_common.h +++ b/src/common/settings_common.h @@ -26,6 +26,7 @@ enum class Category : u32 {      DataStorage,      Debugging,      DebuggingGraphics, +    GpuDriver,      Miscellaneous,      Network,      WebService, diff --git a/src/common/settings_setting.h b/src/common/settings_setting.h index 3175ab07d..0b18ca5ec 100644 --- a/src/common/settings_setting.h +++ b/src/common/settings_setting.h @@ -81,6 +81,9 @@ public:      [[nodiscard]] virtual const Type& GetValue() const {          return value;      } +    [[nodiscard]] virtual const Type& GetValue(bool need_global) const { +        return value; +    }      /**       * Sets the setting to the given value. @@ -353,7 +356,7 @@ public:          }          return custom;      } -    [[nodiscard]] const Type& GetValue(bool need_global) const { +    [[nodiscard]] const Type& GetValue(bool need_global) const override final {          if (use_global || need_global) {              return this->value;          }  | 
