diff options
Diffstat (limited to 'src/core')
| -rw-r--r-- | src/core/core.cpp | 25 | ||||
| -rw-r--r-- | src/core/core.h | 7 | ||||
| -rw-r--r-- | src/core/file_sys/content_archive.cpp | 17 | ||||
| -rw-r--r-- | src/core/hle/service/am/am.cpp | 8 | ||||
| -rw-r--r-- | src/core/hle/service/audio/hwopus.cpp | 6 | ||||
| -rw-r--r-- | src/core/hle/service/audio/hwopus.h | 1 | ||||
| -rw-r--r-- | src/core/hle/service/sockets/nsd.cpp | 11 | ||||
| -rw-r--r-- | src/core/hle/service/sockets/sfdnsres.cpp | 12 | 
8 files changed, 69 insertions, 18 deletions
| diff --git a/src/core/core.cpp b/src/core/core.cpp index 2f67e60a9..e95ae80da 100644 --- a/src/core/core.cpp +++ b/src/core/core.cpp @@ -273,7 +273,8 @@ struct System::Impl {          time_manager.Initialize();          is_powered_on = true; -        exit_lock = false; +        exit_locked = false; +        exit_requested = false;          microprofile_cpu[0] = MICROPROFILE_TOKEN(ARM_CPU0);          microprofile_cpu[1] = MICROPROFILE_TOKEN(ARM_CPU1); @@ -398,7 +399,8 @@ struct System::Impl {          }          is_powered_on = false; -        exit_lock = false; +        exit_locked = false; +        exit_requested = false;          if (gpu_core != nullptr) {              gpu_core->NotifyShutdown(); @@ -507,7 +509,8 @@ struct System::Impl {      CpuManager cpu_manager;      std::atomic_bool is_powered_on{}; -    bool exit_lock = false; +    bool exit_locked = false; +    bool exit_requested = false;      bool nvdec_active{}; @@ -943,12 +946,20 @@ const Service::Time::TimeManager& System::GetTimeManager() const {      return impl->time_manager;  } -void System::SetExitLock(bool locked) { -    impl->exit_lock = locked; +void System::SetExitLocked(bool locked) { +    impl->exit_locked = locked;  } -bool System::GetExitLock() const { -    return impl->exit_lock; +bool System::GetExitLocked() const { +    return impl->exit_locked; +} + +void System::SetExitRequested(bool requested) { +    impl->exit_requested = requested; +} + +bool System::GetExitRequested() const { +    return impl->exit_requested;  }  void System::SetApplicationProcessBuildID(const CurrentBuildProcessID& id) { diff --git a/src/core/core.h b/src/core/core.h index c70ea1965..a9ff9315e 100644 --- a/src/core/core.h +++ b/src/core/core.h @@ -412,8 +412,11 @@ public:      /// Gets an immutable reference to the Room Network.      [[nodiscard]] const Network::RoomNetwork& GetRoomNetwork() const; -    void SetExitLock(bool locked); -    [[nodiscard]] bool GetExitLock() const; +    void SetExitLocked(bool locked); +    bool GetExitLocked() const; + +    void SetExitRequested(bool requested); +    bool GetExitRequested() const;      void SetApplicationProcessBuildID(const CurrentBuildProcessID& id);      [[nodiscard]] const CurrentBuildProcessID& GetApplicationProcessBuildID() const; diff --git a/src/core/file_sys/content_archive.cpp b/src/core/file_sys/content_archive.cpp index 44e6852fe..7d2f0abb8 100644 --- a/src/core/file_sys/content_archive.cpp +++ b/src/core/file_sys/content_archive.cpp @@ -22,6 +22,10 @@  namespace FileSys { +static u8 MasterKeyIdForKeyGeneration(u8 key_generation) { +    return std::max<u8>(key_generation, 1) - 1; +} +  NCA::NCA(VirtualFile file_, const NCA* base_nca)      : file(std::move(file_)), keys{Core::Crypto::KeyManager::Instance()} {      if (file == nullptr) { @@ -41,12 +45,17 @@ NCA::NCA(VirtualFile file_, const NCA* base_nca)          return;      } +    // Ensure we have the proper key area keys to continue. +    const u8 master_key_id = MasterKeyIdForKeyGeneration(reader->GetKeyGeneration()); +    if (!keys.HasKey(Core::Crypto::S128KeyType::KeyArea, master_key_id, reader->GetKeyIndex())) { +        status = Loader::ResultStatus::ErrorMissingKeyAreaKey; +        return; +    } +      RightsId rights_id{};      reader->GetRightsId(rights_id.data(), rights_id.size());      if (rights_id != RightsId{}) {          // External decryption key required; provide it here. -        const auto key_generation = std::max<s32>(reader->GetKeyGeneration(), 1) - 1; -          u128 rights_id_u128;          std::memcpy(rights_id_u128.data(), rights_id.data(), sizeof(rights_id)); @@ -57,12 +66,12 @@ NCA::NCA(VirtualFile file_, const NCA* base_nca)              return;          } -        if (!keys.HasKey(Core::Crypto::S128KeyType::Titlekek, key_generation)) { +        if (!keys.HasKey(Core::Crypto::S128KeyType::Titlekek, master_key_id)) {              status = Loader::ResultStatus::ErrorMissingTitlekek;              return;          } -        auto titlekek = keys.GetKey(Core::Crypto::S128KeyType::Titlekek, key_generation); +        auto titlekek = keys.GetKey(Core::Crypto::S128KeyType::Titlekek, master_key_id);          Core::Crypto::AESCipher<Core::Crypto::Key128> cipher(titlekek, Core::Crypto::Mode::ECB);          cipher.Transcode(titlekey.data(), titlekey.size(), titlekey.data(),                           Core::Crypto::Op::Decrypt); diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index da33f0e44..e92f400de 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp @@ -341,7 +341,7 @@ void ISelfController::Exit(HLERequestContext& ctx) {  void ISelfController::LockExit(HLERequestContext& ctx) {      LOG_DEBUG(Service_AM, "called"); -    system.SetExitLock(true); +    system.SetExitLocked(true);      IPC::ResponseBuilder rb{ctx, 2};      rb.Push(ResultSuccess); @@ -350,10 +350,14 @@ void ISelfController::LockExit(HLERequestContext& ctx) {  void ISelfController::UnlockExit(HLERequestContext& ctx) {      LOG_DEBUG(Service_AM, "called"); -    system.SetExitLock(false); +    system.SetExitLocked(false);      IPC::ResponseBuilder rb{ctx, 2};      rb.Push(ResultSuccess); + +    if (system.GetExitRequested()) { +        system.Exit(); +    }  }  void ISelfController::EnterFatalSection(HLERequestContext& ctx) { diff --git a/src/core/hle/service/audio/hwopus.cpp b/src/core/hle/service/audio/hwopus.cpp index 4a8276ed1..1557e6088 100644 --- a/src/core/hle/service/audio/hwopus.cpp +++ b/src/core/hle/service/audio/hwopus.cpp @@ -267,6 +267,10 @@ void HwOpus::GetWorkBufferSizeEx(HLERequestContext& ctx) {      GetWorkBufferSize(ctx);  } +void HwOpus::GetWorkBufferSizeExEx(HLERequestContext& ctx) { +    GetWorkBufferSizeEx(ctx); +} +  void HwOpus::GetWorkBufferSizeForMultiStreamEx(HLERequestContext& ctx) {      OpusMultiStreamParametersEx param;      std::memcpy(¶m, ctx.ReadBuffer().data(), ctx.GetReadBufferSize()); @@ -409,7 +413,7 @@ HwOpus::HwOpus(Core::System& system_) : ServiceFramework{system_, "hwopus"} {          {6, &HwOpus::OpenHardwareOpusDecoderForMultiStreamEx,           "OpenHardwareOpusDecoderForMultiStreamEx"},          {7, &HwOpus::GetWorkBufferSizeForMultiStreamEx, "GetWorkBufferSizeForMultiStreamEx"}, -        {8, nullptr, "GetWorkBufferSizeExEx"}, +        {8, &HwOpus::GetWorkBufferSizeExEx, "GetWorkBufferSizeExEx"},          {9, nullptr, "GetWorkBufferSizeForMultiStreamExEx"},      };      RegisterHandlers(functions); diff --git a/src/core/hle/service/audio/hwopus.h b/src/core/hle/service/audio/hwopus.h index 91d9998ac..90867bf74 100644 --- a/src/core/hle/service/audio/hwopus.h +++ b/src/core/hle/service/audio/hwopus.h @@ -34,6 +34,7 @@ private:      void OpenHardwareOpusDecoderForMultiStreamEx(HLERequestContext& ctx);      void GetWorkBufferSize(HLERequestContext& ctx);      void GetWorkBufferSizeEx(HLERequestContext& ctx); +    void GetWorkBufferSizeExEx(HLERequestContext& ctx);      void GetWorkBufferSizeForMultiStreamEx(HLERequestContext& ctx);  }; diff --git a/src/core/hle/service/sockets/nsd.cpp b/src/core/hle/service/sockets/nsd.cpp index bac21752a..491b76d48 100644 --- a/src/core/hle/service/sockets/nsd.cpp +++ b/src/core/hle/service/sockets/nsd.cpp @@ -19,6 +19,12 @@ enum class ServerEnvironmentType : u8 {      Dp,  }; +// This is nn::nsd::EnvironmentIdentifier +struct EnvironmentIdentifier { +    std::array<u8, 8> identifier; +}; +static_assert(sizeof(EnvironmentIdentifier) == 0x8); +  NSD::NSD(Core::System& system_, const char* name) : ServiceFramework{system_, name} {      // clang-format off      static const FunctionInfo functions[] = { @@ -101,8 +107,9 @@ void NSD::ResolveEx(HLERequestContext& ctx) {  }  void NSD::GetEnvironmentIdentifier(HLERequestContext& ctx) { -    const std::string environment_identifier = "lp1"; -    ctx.WriteBuffer(environment_identifier); +    constexpr EnvironmentIdentifier lp1 = { +        .identifier = {'l', 'p', '1', '\0', '\0', '\0', '\0', '\0'}}; +    ctx.WriteBuffer(lp1);      IPC::ResponseBuilder rb{ctx, 2};      rb.Push(ResultSuccess); diff --git a/src/core/hle/service/sockets/sfdnsres.cpp b/src/core/hle/service/sockets/sfdnsres.cpp index 22e4a6f49..c657c4efd 100644 --- a/src/core/hle/service/sockets/sfdnsres.cpp +++ b/src/core/hle/service/sockets/sfdnsres.cpp @@ -150,6 +150,12 @@ static std::pair<u32, GetAddrInfoError> GetHostByNameRequestImpl(HLERequestConte      const std::string host = Common::StringFromBuffer(host_buffer);      // For now, ignore options, which are in input buffer 1 for GetHostByNameRequestWithOptions. +    // Prevent resolution of Nintendo servers +    if (host.find("srv.nintendo.net") != std::string::npos) { +        LOG_WARNING(Network, "Resolution of hostname {} requested, returning EAI_AGAIN", host); +        return {0, GetAddrInfoError::AGAIN}; +    } +      auto res = Network::GetAddressInfo(host, /*service*/ std::nullopt);      if (!res.has_value()) {          return {0, Translate(res.error())}; @@ -261,6 +267,12 @@ static std::pair<u32, GetAddrInfoError> GetAddrInfoRequestImpl(HLERequestContext      const auto host_buffer = ctx.ReadBuffer(0);      const std::string host = Common::StringFromBuffer(host_buffer); +    // Prevent resolution of Nintendo servers +    if (host.find("srv.nintendo.net") != std::string::npos) { +        LOG_WARNING(Network, "Resolution of hostname {} requested, returning EAI_AGAIN", host); +        return {0, GetAddrInfoError::AGAIN}; +    } +      std::optional<std::string> service = std::nullopt;      if (ctx.CanReadBuffer(1)) {          const std::span<const u8> service_buffer = ctx.ReadBuffer(1); | 
