diff options
Diffstat (limited to 'src/video_core')
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_rasterizer.cpp | 4 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_state_tracker.cpp | 7 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_state_tracker.h | 16 | 
3 files changed, 14 insertions, 13 deletions
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index 936f76195..ff1b52eab 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp @@ -1443,10 +1443,10 @@ void RasterizerVulkan::UpdateFrontFace(Tegra::Engines::Maxwell3D::Regs& regs) {  }  void RasterizerVulkan::UpdatePrimitiveTopology(Tegra::Engines::Maxwell3D::Regs& regs) { -    if (!state_tracker.TouchPrimitiveTopology()) { +    const Maxwell::PrimitiveTopology primitive_topology = regs.draw.topology.Value(); +    if (!state_tracker.ChangePrimitiveTopology(primitive_topology)) {          return;      } -    const Maxwell::PrimitiveTopology primitive_topology = regs.draw.topology.Value();      scheduler.Record([this, primitive_topology](vk::CommandBuffer cmdbuf) {          cmdbuf.SetPrimitiveTopologyEXT(MaxwellToVK::PrimitiveTopology(device, primitive_topology));      }); diff --git a/src/video_core/renderer_vulkan/vk_state_tracker.cpp b/src/video_core/renderer_vulkan/vk_state_tracker.cpp index 9151d9fb1..4bd1009f9 100644 --- a/src/video_core/renderer_vulkan/vk_state_tracker.cpp +++ b/src/video_core/renderer_vulkan/vk_state_tracker.cpp @@ -42,7 +42,6 @@ Flags MakeInvalidationFlags() {      flags[DepthWriteEnable] = true;      flags[DepthCompareOp] = true;      flags[FrontFace] = true; -    flags[PrimitiveTopology] = true;      flags[StencilOp] = true;      flags[StencilTestEnable] = true;      return flags; @@ -112,10 +111,6 @@ void SetupDirtyFrontFace(Tables& tables) {      table[OFF(screen_y_control)] = FrontFace;  } -void SetupDirtyPrimitiveTopology(Tables& tables) { -    tables[0][OFF(draw.topology)] = PrimitiveTopology; -} -  void SetupDirtyStencilOp(Tables& tables) {      auto& table = tables[0];      table[OFF(stencil_front_op_fail)] = StencilOp; @@ -156,13 +151,13 @@ void StateTracker::Initialize() {      SetupDirtyDepthWriteEnable(tables);      SetupDirtyDepthCompareOp(tables);      SetupDirtyFrontFace(tables); -    SetupDirtyPrimitiveTopology(tables);      SetupDirtyStencilOp(tables);      SetupDirtyStencilTestEnable(tables);  }  void StateTracker::InvalidateCommandBufferState() {      system.GPU().Maxwell3D().dirty.flags |= invalidation_flags; +    current_topology = INVALID_TOPOLOGY;  }  } // namespace Vulkan diff --git a/src/video_core/renderer_vulkan/vk_state_tracker.h b/src/video_core/renderer_vulkan/vk_state_tracker.h index 54ca0d6c6..13a6ce786 100644 --- a/src/video_core/renderer_vulkan/vk_state_tracker.h +++ b/src/video_core/renderer_vulkan/vk_state_tracker.h @@ -32,7 +32,6 @@ enum : u8 {      DepthWriteEnable,      DepthCompareOp,      FrontFace, -    PrimitiveTopology,      StencilOp,      StencilTestEnable, @@ -43,6 +42,8 @@ static_assert(Last <= std::numeric_limits<u8>::max());  } // namespace Dirty  class StateTracker { +    using Maxwell = Tegra::Engines::Maxwell3D::Regs; +  public:      explicit StateTracker(Core::System& system); @@ -102,10 +103,6 @@ public:          return Exchange(Dirty::FrontFace, false);      } -    bool TouchPrimitiveTopology() { -        return Exchange(Dirty::PrimitiveTopology, false); -    } -      bool TouchStencilOp() {          return Exchange(Dirty::StencilOp, false);      } @@ -114,7 +111,15 @@ public:          return Exchange(Dirty::StencilTestEnable, false);      } +    bool ChangePrimitiveTopology(Maxwell::PrimitiveTopology new_topology) { +        const bool has_changed = current_topology != new_topology; +        current_topology = new_topology; +        return has_changed; +    } +  private: +    static constexpr auto INVALID_TOPOLOGY = static_cast<Maxwell::PrimitiveTopology>(~0u); +      bool Exchange(std::size_t id, bool new_value) const noexcept {          auto& flags = system.GPU().Maxwell3D().dirty.flags;          const bool is_dirty = flags[id]; @@ -124,6 +129,7 @@ private:      Core::System& system;      Tegra::Engines::Maxwell3D::DirtyState::Flags invalidation_flags; +    Maxwell::PrimitiveTopology current_topology = INVALID_TOPOLOGY;  };  } // namespace Vulkan  | 
