summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-05memory_manager: Improved implementation of read/write/copy block.bunnei
- Fixes graphical issues with Chocobo's Mystery Dungeon EVERY BUDDY! - Fixes a crash with Mario Tennis Aces
2019-04-05Merge pull request #2350 from lioncash/vmembunnei
video_core/memory_manager: Mark a few member functions with the const qualifier
2019-04-05Merge pull request #2340 from lioncash/viewbunnei
file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash
2019-04-05Merge pull request #2334 from lioncash/overridebunnei
core: Add missing override specifiers where applicable
2019-04-05Merge pull request #2347 from lioncash/truncbunnei
video_core/gpu_thread: Silence truncation warning in ThreadManager's constructor
2019-04-05Merge pull request #2341 from lioncash/comparebunnei
file_sys/nca_metadata: Remove unnecessary comparison operators for TitleType
2019-04-05Merge pull request #2339 from lioncash/rankbunnei
service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs
2019-04-05Merge pull request #2327 from ReinUsesLisp/crash-safe-visitbunnei
gl_shader_decompiler: Return early when an operation is invalid
2019-04-05Merge pull request #2343 from lioncash/todobunnei
file_sys/program_metadata: Remove obsolete TODOs
2019-04-05Merge pull request #2337 from lioncash/temporarybunnei
gl_shader_decompiler: Rename GenerateTemporal() to GenerateTemporary()
2019-04-05Merge pull request #2329 from lioncash/sanitizebunnei
kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomic
2019-04-05Merge pull request #2344 from lioncash/resultbunnei
hle/result: Remove unnecessary bitfield entry for ResultCode
2019-04-05Merge pull request #2349 from lioncash/surfacebunnei
yuzu/debugger/graphics/graphics_surface: General cleanup
2019-04-05Merge pull request #2351 from lioncash/macrobunnei
video_core/macro_interpreter: Simplify GetRegister()
2019-04-05video_core/macro_interpreter: Remove assertion within FetchParameter()Lioncash
We can just use .at(), which essentially does the same thing, but with less code.
2019-04-05video_core/macro_interpreter: Simplify GetRegister()Lioncash
Given we already ensure nothing can set the zeroth register in SetRegister(), we don't need to check if the index is zero and special case it. We can just access the register normally, since it's already going to be zero. We can also replace the assertion with .at() to perform the equivalent behavior inline as part of the API.
2019-04-05video_core/memory_manager: Make Read() a const qualified member functionLioncash
Given this doesn't actually alter internal state, this can be made a const member function.
2019-04-05video_core/memory_manager: Make ReadBlock() a const qualifier member functionLioncash
Now, since we have a const qualified variant of GetPointer(), we can put it to use in ReadBlock() to retrieve the source pointer that is passed into memcpy. Now block reading may be done from a const context.
2019-04-05video_core/memory_manager: Add a const qualified variant of GetPointer()Lioncash
Allows retrieving read-only pointers from a const context externally.
2019-04-05video_core/memory_manager: Make FindFreeRegion() a const member functionLioncash
This doesn't modify internal state, so it can be made a const member function.
2019-04-05video_core/memory_manager: Make GpuToCpuAddress() a const member functionLioncash
This doesn't modify any internal state, so it can be made a const member function to allow its use in const contexts.
2019-04-05yuzu/debugger/graphics_surface: Display error messages for file I/O errorsLioncash
2019-04-05yuzu/debugger/graphics_surface: Tidy up SaveSurfaceLioncash
- Use QStringLiteral where applicable. - Use const where applicable - Remove unnecessary precondition check (we already assert the pixbuf being non null)
2019-04-05yuzu/debugger/graphics_surface: Clean up connection overload deductionLioncash
We can utilize qOverload with the signal connections to make the function deducing a little less ugly.
2019-04-05yuzu/debugger/graphics_surface: Fill in missing surface format listingsLioncash
Fills in the missing surface types that were marked as unknown. The order corresponds with the TextureFormat enum within video_core/texture.h. We also don't need to all of these strings as translatable (only the first string, as it's an English word).
2019-04-05video_core/gpu_thread: Silence truncation warning in ThreadManager's constructorLioncash
Since c5d41fd812d7eb1a04f36b76c08fe971cee0868c callback parameters were changed to use an s64 to represent late cycles instead of an int, so this was causing a truncation warning to occur here. Changing it to s64 is sufficient to silence the warning.
2019-04-05hle/result: Remove unnecessary bitfield entry for ResultCodeLioncash
This is a hold over from the 3DS error codes in Citra.
2019-04-05file_sys/program_metadata: Remove obsolete TODOsLioncash
BitField has been trivially copyable since e99a14862841841d74be8d0ea9426c2d23546b5e, so we can eliminate these TODO comments and use ReadObject() directly instead of memcpying the data.
2019-04-05file_sys/nca_metadata: Remove unnecessary comparison operators for TitleTypeLioncash
enum class elements from the same enum can already be compared against one another without the need for explicitly defined comparison operators.
2019-04-05file_sys/fsmitm_romfsbuild: Utilize a string_view in romfs_calc_path_hash()Lioncash
The given string instance doesn't need to be copied entirely, we can just use a view instead.
2019-04-05service/fsp_srv: Don't pass SaveDataDescriptor instances by value.Lioncash
Passing around a 64 byte data struct by value is kind of wasteful, instead pass a reference to the struct.
2019-04-05service/fsp_srv: Remove unnecessary unknown member in OpenSaveDataFileSystemLioncash
The unknown member here is actually padding due to being passed as a struct. We can do the same, and remove the need to pop a padding word.
2019-04-05service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structsLioncash
I realized that I updated the documentation on SwitchBrew a while ago, but never actually updated the structs within yuzu.
2019-04-05Merge pull request #2338 from lioncash/fsbunnei
filesystem: Use a std::string_view in OpenFile()
2019-04-04Merge pull request #2282 from bunnei/gpu-asynch-v2bunnei
gpu_thread: Improve synchronization by using CoreTiming.
2019-04-04Merge pull request #2292 from lioncash/nacpbunnei
file_sys/control_metadata: Amend naming of members
2019-04-04Merge pull request #2335 from lioncash/service-unusedbunnei
hle/service: Resolve unused variable warnings
2019-04-04Merge pull request #2336 from ReinUsesLisp/txqbunnei
gl_shader_decompiler: Fix TXQ types
2019-04-04Merge pull request #2331 from lioncash/cachebunnei
yuzu/main: Minor adjustments to OnTransferableShaderCacheOpenFile()
2019-04-04Merge pull request #2333 from lioncash/video-includebunnei
video_core/renderer_opengl: Remove unnecessary includes
2019-04-04Merge pull request #2332 from lioncash/includebunnei
yuzu/main: Remove unnecessary includes
2019-04-04filesystem: Use a std::string_view in OpenFile()Lioncash
Rather than make a full copy of the path, we can just use a string view and truncate the viewed portion of the string instead of creating a totally new truncated string.
2019-04-04gl_shader_decompiler: Rename GenerateTemporal() to GenerateTemporary()Lioncash
Temporal generally indicates a relation to time, but this is just creating a temporary, so this isn't really an accurate name for what the function is actually doing.
2019-04-04gl_shader_decompiler: Fix TXQ typesReinUsesLisp
TXQ returns integer types. Shaders usually do: R0 = TXQ(); // => int R0 = static_cast<float>(R0); If we don't treat it as an integer, it will cast a binary float value as float - resulting in a corrupted number.
2019-04-04hle/service: Resolve unused variable warningsLioncash
In several places, we have request parsers where there's nothing to really parse, simply because the HLE function in question operates on buffers. In these cases we can just remove these instances altogether. In the other cases, we can retrieve the relevant members from the parser and at least log them out, giving them some use.
2019-04-04core: Add missing override specifiers where applicableLioncash
Applies the override specifier where applicable. In the case of destructors that are defaulted in their definition, they can simply be removed. This also removes the unnecessary inclusions being done in audin_u and audrec_u, given their close proximity.
2019-04-04video_core/renderer_opengl: Remove unnecessary includesLioncash
Quite a few unused includes have built up over time, particularly on core/memory.h. Removing these includes means the source files including those files will no longer need to be rebuilt if they're changed, making compilation slightly faster in this scenario.
2019-04-04yuzu/main: Remove unnecessary includesLioncash
While we're at it, don't use <QtGui> and <QtWidgets> and instead include exactly which headers we actually need.
2019-04-04yuzu/main: Use QStringLiteral where applicable within ↵Lioncash
OnTransferableShaderCacheOpenFile() Allows these strings to have no allocation cost when used at runtime.
2019-04-04yuzu/main: Tidy up the error dialog string in ↵Lioncash
OnTransferableShaderCacheOpenFile() Rather than scream that the file doesn't exist, we can clearly state what specifically doesn't exist, to avoid ambiguity, and make it easier to understand for non-primary English speakers/readers.