summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-06Merge pull request #5148 from comex/xx-unused-fieldsbunnei
core: Mark unused fields as [[maybe_unused]]
2020-12-06Merge pull request #5154 from comex/xx-ipcbunnei
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
2020-12-07Merge pull request #5147 from comex/xx-purevirtLC
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
2020-12-07Merge pull request #5150 from comex/xx-boxcatLC
boxcat: Avoid unnecessary object copy
2020-12-07Merge pull request #5152 from comex/xx-overrideLC
renderer_vulkan: Add missing `override` specifier
2020-12-07Merge pull request #5136 from lioncash/video-shadow3LC
video_core: Resolve more variable shadowing scenarios pt.3
2020-12-06Merge pull request #5155 from comex/xx-defaultLC
Fix "explicitly defaulted but implicitly deleted" warning
2020-12-06Fix "explicitly defaulted but implicitly deleted" warningcomex
`PhysicalCore`'s move assignment operator was declared as `= default`, but was implicitly deleted because `PhysicalCore` has fields of reference type. Switch to explicitly deleting it to avoid a Clang warning. The move *constructor* is still defaulted, and is required to exist due to the use of `std::vector<PhysicalCore>`.
2020-12-06hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cppcomex
- Add a type check so that calling Push with an invalid type produces a compile error rather than a linker error. - vi.cpp was calling Push with a variable of type `std::size_t`. There's no explicit overload for `size_t`, but there is one for `u64`, which on most platforms is the same type as `size_t`. On macOS, however, it isn't: both types are 64 bits, but `size_t` is `unsigned long` and `u64` is `unsigned long long`. Regardless, it makes more sense to explicitly use `u64` here instead of `size_t`.
2020-12-06renderer_vulkan: Add missing `override` specifiercomex
2020-12-06core: Mark unused fields as [[maybe_unused]]comex
2020-12-06boxcat: Avoid unnecessary object copycomex
2020-12-06Merge pull request #5146 from comex/xx-numLC
video_core: Adjust `NUM` macro to avoid Clang warning
2020-12-06nvdrv: Remove useless re-declaration of pure virtual methods that were ↵comex
already declared in the superclass
2020-12-06video_core: Adjust `NUM` macro to avoid Clang warningcomex
The previous definition was: #define NUM(field_name) (sizeof(Maxwell3D::Regs::field_name) / sizeof(u32)) In cases where `field_name` happens to refer to an array, Clang thinks `sizeof(an array value) / sizeof(a type)` is an instance of the idiom where `sizeof` is used to compute an array length. So it thinks the type in the denominator ought to be the array element type, and warns if it isn't, assuming this is a mistake. In reality, `NUM` is not used to get array lengths at all, so there is no mistake. Silence the warning by applying Clang's suggested workaround of parenthesizing the denominator.
2020-12-06Merge pull request #5143 from comex/xx-users-sizeRodrigo Locatti
yuzu_cmd: Remove 'users_size'
2020-12-06Merge pull request #5141 from comex/xx-true-falseRodrigo Locatti
maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict
2020-12-06Merge pull request #5140 from FearlessTobi/port-5577bunnei
Port citra-emu/citra#5577: "Update cubeb and request a persistent stream session"
2020-12-06Merge pull request #5132 from lioncash/xbyak-abibunnei
xbyak_abi: Avoid implicit sign conversions
2020-12-06Merge pull request #5139 from lioncash/deprecated-qtbunnei
game_list_p: Resolve deprecated usage of QVariant operator<
2020-12-05maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflictcomex
On Apple platforms, FALSE and TRUE are defined as macros by <mach/boolean.h>, which is included by various system headers. Note that there appear to be no actual users of the names to fix up.
2020-12-05yuzu_cmd: Remove 'users_size'comex
Specifically: const auto size = sdl2_config->GetInteger("System", "users_size", 0); The variable is never used, producing a warning. I wondered if this ought to be assigning something to in `Settings`, but nothing else in the codebase ever mentions a setting called "users_size", so I guess it's safe to remove...
2020-12-05Update cubeb and request a persistent stream sessionVitor Kiguchi
2020-12-05video_core: Resolve more variable shadowing scenarios pt.3Lioncash
Cleans out the rest of the occurrences of variable shadowing and makes any further occurrences of shadowing compiler errors.
2020-12-05game_list_p: Resolve deprecated usage of QVariant operator<Lioncash
This is designated as obsolete in Qt's docs (see: https://doc.qt.io/qt-5/qvariant-obsolete.html#operator-lt)
2020-12-05Merge pull request #5133 from lioncash/video-shadow2Chloe
video_core: Resolve more variable shadowing scenarios pt.2
2020-12-05video_core: Resolve more variable shadowing scenarios pt.2Lioncash
Migrates the video core code closer to enabling variable shadowing warnings as errors. This primarily sorts out shadowing occurrences within the Vulkan code.
2020-12-05Merge pull request #5124 from lioncash/video-shadowbunnei
video_core: Resolve more variable shadowing scenarios
2020-12-04Merge pull request #5127 from FearlessTobi/port-5617bunnei
Port citra-emu/citra#5617: "Fix telemetry-related exit crash from use-after-free"
2020-12-05xbyak_abi: Shorten std::size_t to size_tLioncash
Makes for less reading.
2020-12-05xbyak_abi: Avoid implicit sign conversionsLioncash
2020-12-05Merge pull request #5130 from ogniK5377/sys-11.0.0LC
system_version: Update to 11.0.0
2020-12-05system_version: Update to 11.0.0Chloe Marcec
2020-12-05Fix telemetry-related exit crash from use-after-freeFearlessTobi
Co-Authored-By: xperia64 <xperia64@users.noreply.github.com>
2020-12-04Merge pull request #5126 from lioncash/deprecatedbunnei
codec: Remove deprecated usage of AVCodecContext::refcounted_frames
2020-12-04codec: Remove deprecated usage of AVCodecContext::refcounted_framesLioncash
This was only necessary for use with the avcodec_decode_video2/avcoded_decode_audio4 APIs which are also deprecated. Given we use avcodec_send_packet/avcodec_receive_frame, this isn't necessary, this is even indicated directly within the FFmpeg API changes document here on 2017-09-26: https://github.com/FFmpeg/FFmpeg/blob/master/doc/APIchanges#L410 This prevents our code from breaking whenever we update to a newer version of FFmpeg in the future if they ever decide to fully remove this API member.
2020-12-04video_core: Resolve more variable shadowing scenariosLioncash
Resolves variable shadowing scenarios up to the end of the OpenGL code to make it nicer to review. The rest will be resolved in a following commit.
2020-12-04Merge pull request #5064 from lioncash/node-shadowbunnei
node: Eliminate variable shadowing
2020-12-03Merge pull request #5061 from lioncash/pessimizingbunnei
vp9/vic: Resolve pessimizing moves
2020-12-03Merge pull request #4996 from bunnei/use-4jitsbunnei
Kernel: Refactor to use 4-instances of Dynarmic & various cleanups and improvements
2020-12-03node: Mark member functions as [[nodiscard]] where applicableLioncash
Prevents logic bugs from accidentally ignoring the return value.
2020-12-03node: Eliminate variable shadowingLioncash
2020-12-03Merge pull request #5059 from lioncash/mousebunnei
mouse_input/mouse_poller: Minor cleanup
2020-12-03vp9/vic: Resolve pessimizing movesLioncash
Removes the usage of moves that don't result in behavior different from a copy, or otherwise would prevent copy elision from occurring.
2020-12-03mouse_poller: Remove unused includesLioncash
2020-12-03mouse_input: Invert conditional in UpdateYuzuSettings()Lioncash
Allows the struct to be constructed in place.
2020-12-03mouse_input: Remove two casts and amend some formattingLioncash
Removes the use of two static casts and improves the readability of some vectors slightly.
2020-12-03mouse_input: Resolve a -Wdocumentation warningLioncash
2020-12-03mouse_input: Remove unused includesLioncash
2020-12-02Merge pull request #5000 from lioncash/audio-errorbunnei
audio_core: Make shadowing and unused parameters errors