summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-10Merge pull request #5162 from lioncash/copy-shaderbunnei
gl_shader_decompiler: Elide unnecessary copies within DeclareConstantBuffers()
2020-12-09Merge pull request #5179 from ReinUsesLisp/fs-pathLC
common/file_util: Let std::filesystem cast from UTF16 to std::string
2020-12-09common/file_util: Let std::filesystem cast from UTF16 to std::stringReinUsesLisp
Fix invalid encoding paths when iterating over a directory on Windows.
2020-12-09Merge pull request #5176 from Morph1984/fix-createfileChloe
vfs_real: Fix CreateFile for files without a file extension
2020-12-09vfs_real: Fix CreateFile for files without a file extensionMorph
2020-12-09Merge pull request #5174 from ReinUsesLisp/fs-fixMorph
common/file_util: Fix and deprecate CreateFullPath, add CreateDirs
2020-12-09common/file_util: Fix and deprecate CreateFullPath, add CreateDirsReinUsesLisp
Fix CreateFullPath to have its intended previous behavior (whatever that was), and deprecate it in favor of the new CreateDirs function. Unlike CreateDir, CreateDirs is marked as [[nodiscard]] to avoid new code ignoring its result value.
2020-12-09common/file_util: Succeed on CreateDir when the directory existsReinUsesLisp
2020-12-09Merge pull request #5142 from comex/xx-poll-eventsRodrigo Locatti
network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents`
2020-12-09Merge pull request #5173 from lioncash/common-fsRodrigo Locatti
common/file_util: Make use of std::filesystem
2020-12-09file_util: Migrate remaining file handling functions over to std::filesystemLioncash
Converts creation and deletion functions over to std::filesystem, simplifying our file-handling code. Notably with this, CopyDir will now function on Windows.
2020-12-08Merge pull request #5166 from lioncash/log-castbunnei
core: Remove unnecessary enum casts in log calls
2020-12-08Merge pull request #5135 from Morph1984/applets-shadowbunnei
applets: Resolve variable shadowing
2020-12-08file_util: Migrate Exists() and IsDirectory() over to std::filesystemLioncash
Greatly simplifies our file-handling code for these functions.
2020-12-08Merge pull request #5171 from lat9nq/ci-unicorn-cleanupLC
ci: Remove `-DYUZU_USE_BUNDLED_UNICORN=ON`
2020-12-08ci: Remove `-DYUZU_USE_BUNDLED_UNICORN=ON`lat9nq
Unicorn has been removed, yet CI still enables building with Unicorn. This just cleans up a few leftovers by removing the variable from the CMake parameters in CI.
2020-12-08Merge pull request #5167 from lioncash/doc-memorybunnei
memory: Resolve -Wdocumentation warning for Write()
2020-12-08memory: Resolve -Wdocumentation warning for Write()Lioncash
Write() doesn't return anything, so the @returns tag shouldn't be present.
2020-12-08Merge pull request #5156 from comex/xx-rawsbunnei
configure_motion_touch: Fix unescaped backslash in regex
2020-12-08Merge pull request #5165 from lioncash/copy-controllerMorph
controller: Avoid unnecessary copies in ConfigurationComplete()
2020-12-07core: Remove unnecessary enum casts in log callsLioncash
Follows the video core PR. fmt doesn't require casts for enum classes anymore, so we can remove quite a few casts.
2020-12-07controller: Use std::move within ConvertToFrontendParameters()Lioncash
Avoids unnecessary copies.
2020-12-07controller: Avoid unnecessary copies in ConfigurationComplete()Lioncash
Avoids unnecessary 1072 byte copies when querying info about controllers.
2020-12-08Merge pull request #5020 from german77/AnalogfromButtonFixMorph
Disable analog joystick from buttons by default
2020-12-07Disable analog joystick from buttons by defaultgerman
2020-12-07Merge pull request #5164 from lioncash/containsRodrigo Locatti
video_core: Make use of ordered container contains() where applicable
2020-12-07Merge pull request #5163 from lioncash/concatRodrigo Locatti
ast: Improve string concat readability in operator()
2020-12-07Merge pull request #5153 from comex/xx-unixbunnei
CMakeLists,network: Create YUZU_UNIX macro to replace __unix__
2020-12-07video_core: Make use of ordered container contains() where applicableLioncash
With C++20, we can use the more concise contains() member function instead of comparing the result of the find() call with the end iterator.
2020-12-07ast: Improve string concat readability in operator()Lioncash
Provides an in-place format string to make it more pleasant to read.
2020-12-07gl_shader_decompiler: Elide unnecessary copies within DeclareConstantBuffers()Lioncash
Resolves a -Wrange-loop-analysis warning.
2020-12-07Merge pull request #5149 from comex/xx-map-intervalbunnei
map_interval: Change field order to address uninitialized field warning
2020-12-07Merge pull request #5159 from lioncash/move-amendRodrigo Locatti
shader_ir: std::move node within DeclareAmend()
2020-12-07Merge pull request #5160 from lioncash/buffer-headerRodrigo Locatti
buffer_block: Remove unnecessary includes
2020-12-07buffer_block: Mark interface as nodiscard where applicableLioncash
Prevents logic errors from occurring from unused values.
2020-12-07buffer_block: Remove unnecessary includesLioncash
Reduces the amount of dependencies the header pulls in.
2020-12-07Merge pull request #5158 from lioncash/video-fmtRodrigo Locatti
video_core: Remove unnecessary enum class casting in logging messages
2020-12-06Merge pull request #5148 from comex/xx-unused-fieldsbunnei
core: Mark unused fields as [[maybe_unused]]
2020-12-06Merge pull request #5154 from comex/xx-ipcbunnei
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
2020-12-07shader_ir: std::move node within DeclareAmend()Lioncash
Same behavior, but elides an unnecessary atomic reference count increment and decrement.
2020-12-07video_core: Remove unnecessary enum class casting in logging messagesLioncash
fmt now automatically prints the numeric value of an enum class member by default, so we don't need to use casts any more. Reduces the line noise a bit.
2020-12-07Merge pull request #5147 from comex/xx-purevirtLC
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
2020-12-07Merge pull request #5150 from comex/xx-boxcatLC
boxcat: Avoid unnecessary object copy
2020-12-07Merge pull request #5152 from comex/xx-overrideLC
renderer_vulkan: Add missing `override` specifier
2020-12-07Merge pull request #5136 from lioncash/video-shadow3LC
video_core: Resolve more variable shadowing scenarios pt.3
2020-12-06configure_motion_touch: Fix unescaped backslash in regexcomex
Since this is inside a string literal, backslashes that are part of regex syntax have to be escaped. But that's ugly, so convert to a raw string instead.
2020-12-06network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an ↵comex
`enum class PollEvents` Actually, two enum classes, since for some reason there are two separate yet identical `PollFD` types used in the codebase. I get that one is ABI-compatible with the Switch while the other is an abstract type used for the host, but why not use `WSAPOLLFD` directly for the latter? Anyway, why make this change? Because on Apple platforms, `POLL_IN`, `POLL_OUT`, etc. (with an underscore) are defined as macros in <sys/signal.h>. (This is inherited from FreeBSD.) So defining a variable with the same name causes a compile error. I could just rename the variables, but while I was at it I thought I might as well switch to an enum for stronger typing. Also, change the type used for values copied directly to/from the `events` and `revents` fields of the host *native* `pollfd`/`WSASPOLLFD`, from `u32` to `short`, as `short` is the correct canonical type on both Unix and Windows.
2020-12-06Merge pull request #5155 from comex/xx-defaultLC
Fix "explicitly defaulted but implicitly deleted" warning
2020-12-06Fix "explicitly defaulted but implicitly deleted" warningcomex
`PhysicalCore`'s move assignment operator was declared as `= default`, but was implicitly deleted because `PhysicalCore` has fields of reference type. Switch to explicitly deleting it to avoid a Clang warning. The move *constructor* is still defaulted, and is required to exist due to the use of `std::vector<PhysicalCore>`.
2020-12-06hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cppcomex
- Add a type check so that calling Push with an invalid type produces a compile error rather than a linker error. - vi.cpp was calling Push with a variable of type `std::size_t`. There's no explicit overload for `size_t`, but there is one for `u64`, which on most platforms is the same type as `size_t`. On macOS, however, it isn't: both types are 64 bits, but `size_t` is `unsigned long` and `u64` is `unsigned long long`. Regardless, it makes more sense to explicitly use `u64` here instead of `size_t`.