summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-20partition_filesystem, vfs_real: Use std::move in ↵Lioncash
ReplaceFileWithSubdirectory() where applicable Avoids unnecessary atomic increment and decrement operations.
2018-07-20partition_filesystem, vfs_real: Use std::distance() instead of subtractionLioncash
This is a little bit more self-documenting on what is being done here.
2018-07-20Merge pull request #743 from lioncash/viewbunnei
logging: Use std::string_view where applicable
2018-07-20Merge pull request #745 from lioncash/packagebunnei
param_package: Minor changes
2018-07-20Merge pull request #742 from bunnei/misc-apmbunnei
apm: Improve stub for GetPerformanceConfiguration.
2018-07-20Merge pull request #741 from lioncash/enumbunnei
ipc_helpers: Add PushEnum() member function to ResponseBuilder
2018-07-20param_package: Take std::string by value in string-based Set() functionLioncash
Allows avoiding string copies by letting the strings be moved into the function calls.
2018-07-20param_package: Use std::unordered_map's insert_or_assign instead of map indexingLioncash
This avoids a redundant std::string construction if a key doesn't exist in the map already. e.g. data[key] requires constructing a new default instance of the value in the map (but this is wasteful, since we're already setting something into the map over top of it).
2018-07-20param_package: Get rid of file-static std::string constructionLioncash
Avoids potential dynamic allocation occuring during program launch
2018-07-20logging/filter: Use std::string_view in ParseFilterString()Lioncash
Allows avoiding constructing std::string instances, since this only reads an arbitrary sequence of characters. We can also make ParseFilterRule() internal, since it doesn't depend on any private instance state of Filter
2018-07-20logging/backend: Add missing standard includesLioncash
A few inclusions were being satisfied indirectly. To prevent breakages in the future, include these directly.
2018-07-20logging/backend: Use std::string_view in RemoveBackend() and GetBackend()Lioncash
These can just use a view to a string since its only comparing against two names in both cases for matches. This avoids constructing std::string instances where they aren't necessary.
2018-07-20apm: Improve stub for GetPerformanceConfiguration.bunnei
2018-07-20ipc_helpers: Add PushEnum() member function to ResponseBuilderLioncash
Allows pushing strongly-typed enum members without the need to always cast them at the call sites. Note that we *only* allow strongly-typed enums in this case. The reason for this is that strongly typed enums have a guaranteed defined size, so the size of the data being pushed is always deterministic. With regular enums this can be a little more error-prone, so we disallow them. This function simply uses the underlying type of the enum to determine the size of the data. For example, if an enum is defined as: enum class SomeEnum : u16 { SomeEntry }; if PushEnum(SomeEnum::SomeEntry); is called, then it will push a u16-size amount of data.
2018-07-20Merge pull request #740 from Subv/acc_crashbunnei
HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error.
2018-07-20Merge pull request #739 from lioncash/gladbunnei
externals: Update glad to version 0.1.25
2018-07-20Merge pull request #738 from lioncash/signbunnei
gl_state: Get rid of mismatched sign conversions in Apply()
2018-07-20Merge pull request #737 from lioncash/movebunnei
filesys/loader: std::move VirtualFile instances in constructors where applicable
2018-07-20Merge pull request #736 from lioncash/nullbunnei
audout_u/audren_u: Ensure null terminators are written out in ListAudioOutsImpl(), ListAudioDeviceName(), and GetActiveAudioDeviceName()
2018-07-20Merge pull request #735 from lioncash/video-unusedbunnei
maxwell_3d: Remove unused variable within GetStageTextures()
2018-07-20Merge pull request #734 from lioncash/threadbunnei
thread: Convert ThreadStatus into an enum class
2018-07-20Merge pull request #733 from lioncash/dirsbunnei
partition_filesystem: Return pfs_dirs member variable within GetSubdirectories()
2018-07-20Merge pull request #732 from lioncash/unusedbunnei
nso: Minor changes
2018-07-20Merge pull request #731 from lioncash/shadowbunnei
gl_shader_decompiler: Eliminate variable and declaration shadowing
2018-07-20HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error.Subv
And make IManagerForApplication::CheckAvailability always return false. Returning a bogus id from GetAccountId causes games to crash on boot. We should investigate this with a hwtest and either stub it properly or implement it.
2018-07-20externals: Update glad to version 0.1.25Lioncash
Keeps the OpenGL loader library up to date. Previously we were at version 0.1.16
2018-07-20gl_state: Make references const where applicable in Apply()Lioncash
2018-07-20gl_state: Get rid of mismatched sign conversionsLioncash
While we're at it, amend the loop variable type to be the same width as that returned by the .size() call.
2018-07-20loader/{nca, nro}: std::move VirtualFile in the constructors where applicableLioncash
This avoids unnecessary atomic reference count increments and decrements
2018-07-20vfs_offset: std::move file and name parameters of OffsetVfsFileLioncash
Avoids potentially unnecessary atomic reference count incrementing and decrementing, as well as string copying.
2018-07-19Merge pull request #730 from lioncash/stringbunnei
gl_shader_decompiler: Remove unnecessary const from return values
2018-07-19Merge pull request #729 from lioncash/simplifybunnei
pl_u: Simplify WriteBuffer() calls in GetSharedFontInOrderOfPriority()
2018-07-19audren_u: Use a std::array instead of std::string for holding the audio ↵Lioncash
interface/device name std::string doesn't include the null-terminator in its data() + size() range. This ensures that the null-terminator will also be written to the buffer
2018-07-19audout_u: Use a std::array instead of std::string for holding the audio ↵Lioncash
interface name Uses a type that doesn't potentially dynamically allocate, and ensures that the name of the interface is properly null-terminated when writing it to the buffer.
2018-07-19maxwell_3d: Remove unused variable within GetStageTextures()Lioncash
2018-07-19thread: Convert ThreadStatus into an enum classLioncash
Makes the thread status strongly typed, so implicit conversions can't happen. It also makes it easier to catch mistakes at compile time.
2018-07-19partition_filesystem: Return pfs_dirs member variable within GetSubdirectories()Lioncash
This should be returned here, otherwise pfs_dirs is effectively only ever added to, but never read.
2018-07-19nso: Silence implicit sign conversion warningsLioncash
2018-07-19nso: Remove unused function ReadSegment()Lioncash
2018-07-19gl_shader_decompiler: Eliminate variable and declaration shadowingLioncash
Ensures that no identifiers are being hidden, which also reduces compiler warnings.
2018-07-19gl_shader_decompiler: Remove unnecessary const from return valuesLioncash
This adds nothing from a behavioral point of view, and can inhibit the move constructor/RVO
2018-07-19pl_u: Simplify WriteBuffer() calls in GetSharedFontInOrderOfPriority()Lioncash
With the new overload, we can simply pass the container directly.
2018-07-19Merge pull request #726 from lioncash/overloadbunnei
hle_ipc: Introduce generic WriteBuffer overload for multiple container types
2018-07-19Merge pull request #725 from lioncash/bytesbunnei
pl_u: Specify correct size for buffers in GetSharedFontInOrderOfPriority()
2018-07-19Merge pull request #728 from Subv/acc_profilebunnei
HLE/ACC: Change the default user id and small improvements to the way we handle profiles
2018-07-19Merge pull request #727 from Subv/acc_usersbunnei
HLE/ACC: Write a single whole user id in ListAllUsers and ListOpenUsers.
2018-07-19Merge pull request #724 from lioncash/printfbunnei
pl_u: Remove printf specifier in log call in a log call in GetSharedFontInOrderOfPriority()
2018-07-19Merge pull request #723 from lioncash/gdbbunnei
gdbstub: Get rid of a few signed/unsigned comparisons
2018-07-19Merge pull request #722 from lioncash/signedbunnei
hid: Resolve a signed/unsigned comparison warning
2018-07-19Merge pull request #721 from lioncash/svcbunnei
svc: Correct always true assertion case in SetThreadCoreMask