summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-21file_util: Use an enum class for GetUserPath()Lioncash
Instead of using an unsigned int as a parameter and expecting a user to always pass in the correct values, we can just convert the enum into an enum class and use that type as the parameter type instead, which makes the interface more type safe. We also get rid of the bookkeeping "NUM_" element in the enum by just using an unordered map. This function is generally low-frequency in terms of calls (and I'd hope so, considering otherwise would mean we're slamming the disk with IO all the time) so I'd consider this acceptable in this case.
2018-07-21Merge pull request #754 from lioncash/partbunnei
partition_filesystem, vfs_real: Minor changes
2018-07-21Merge pull request #750 from lioncash/ctxbunnei
arm_interface: Remove unused tls_address member of ThreadContext
2018-07-21Merge pull request #756 from lioncash/dynarmicbunnei
externals: Update dynarmic to 7ea1241
2018-07-21Merge pull request #746 from lioncash/testsbunnei
tests/arm_test_common: Minor changes
2018-07-21Merge pull request #747 from lioncash/unimplementedbunnei
gl_shader_manager: Remove unimplemented function prototype
2018-07-21Merge pull request #755 from lioncash/ctorbunnei
file_sys/errors: Remove redundant object constructor calls
2018-07-21Merge pull request #749 from lioncash/consistencybunnei
gpu: Rename Get3DEngine() to Maxwell3D()
2018-07-21Merge pull request #751 from Subv/tpidr_el0bunnei
CPU: Save and restore the TPIDR_EL0 system register on every context switch
2018-07-21Merge pull request #753 from lioncash/constbunnei
vfs: Minor changes
2018-07-21externals: Update dynarmic to 7ea1241Lioncash
Resolves an issue with TPIDR setting being erroneously removed in the dead code pass.
2018-07-20Merge pull request #752 from Subv/vfs_loadbunnei
Loader: Only print the module names and addresses if they actually exist.
2018-07-20file_sys/errors: Remove redundant object constructor callsLioncash
Given we're already constructing the error code, we don't need to call the constructor inside of it.
2018-07-20vfs_real: Remove redundant copying of std::vector instances in GetFiles() ↵Lioncash
and GetSubdirectories() We already return by value, so we don't explicitly need to make the copy.
2018-07-20partition_filesystem, vfs_real: Add missing standard includesLioncash
2018-07-20partition_filesystem, vfs_real: Use std::move in ↵Lioncash
ReplaceFileWithSubdirectory() where applicable Avoids unnecessary atomic increment and decrement operations.
2018-07-20partition_filesystem, vfs_real: Use std::distance() instead of subtractionLioncash
This is a little bit more self-documenting on what is being done here.
2018-07-20vfs_offset: Simplify TrimToFit()Lioncash
We can simply use std::clamp() here, instead of using an equivalent with std::max() and std::min().
2018-07-20vfs: Make WriteBytes() overload taking a std::vector pass the std::vector by ↵Lioncash
const reference Given the data is intended to be directly written, there's no need to take the std::vector by value and copy the data.
2018-07-20vfs: Use variable template variants of std::is_trivially_copyableLioncash
Provides the same behavior, but with less writing
2018-07-20vfs: Amend constness on pointers in WriteBytes() and WriteArrays() member ↵Lioncash
functions to be const qualified These functions don't modify the data being pointed to, so these can be pointers to const data
2018-07-20Loader: Only print the module names and addresses if they actually exist.Subv
2018-07-20CPU: Save and restore the TPIDR_EL0 system register on every context switch.Subv
Note that there's currently a dynarmic bug preventing this register from being written.
2018-07-20Merge pull request #743 from lioncash/viewbunnei
logging: Use std::string_view where applicable
2018-07-20Merge pull request #745 from lioncash/packagebunnei
param_package: Minor changes
2018-07-20arm_interface: Remove unused tls_address member of ThreadContextLioncash
Currently, the TLS address is set within the scheduler, making this member unused.
2018-07-20gl_shader_manager: Replace unimplemented function prototypeLioncash
This was just a linker error waiting to happen.
2018-07-20gpu: Rename Get3DEngine() to Maxwell3D()Lioncash
This makes it match its const qualified equivalent.
2018-07-20Merge pull request #742 from bunnei/misc-apmbunnei
apm: Improve stub for GetPerformanceConfiguration.
2018-07-20Merge pull request #741 from lioncash/enumbunnei
ipc_helpers: Add PushEnum() member function to ResponseBuilder
2018-07-20arm_test_common: Get rid of truncation warningsLioncash
Explicitly cast the value to a u8 to show that this is intentional.
2018-07-20arm_test_common: Make file static variable a member variable of the testing ↵Lioncash
environment Gets rid of file-static behavior.
2018-07-20arm_test_common: Add missing header guardLioncash
2018-07-20param_package: Take std::string by value in string-based Set() functionLioncash
Allows avoiding string copies by letting the strings be moved into the function calls.
2018-07-20param_package: Use std::unordered_map's insert_or_assign instead of map indexingLioncash
This avoids a redundant std::string construction if a key doesn't exist in the map already. e.g. data[key] requires constructing a new default instance of the value in the map (but this is wasteful, since we're already setting something into the map over top of it).
2018-07-20param_package: Get rid of file-static std::string constructionLioncash
Avoids potential dynamic allocation occuring during program launch
2018-07-20logging/filter: Use std::string_view in ParseFilterString()Lioncash
Allows avoiding constructing std::string instances, since this only reads an arbitrary sequence of characters. We can also make ParseFilterRule() internal, since it doesn't depend on any private instance state of Filter
2018-07-20logging/backend: Add missing standard includesLioncash
A few inclusions were being satisfied indirectly. To prevent breakages in the future, include these directly.
2018-07-20logging/backend: Use std::string_view in RemoveBackend() and GetBackend()Lioncash
These can just use a view to a string since its only comparing against two names in both cases for matches. This avoids constructing std::string instances where they aren't necessary.
2018-07-20apm: Improve stub for GetPerformanceConfiguration.bunnei
2018-07-20ipc_helpers: Add PushEnum() member function to ResponseBuilderLioncash
Allows pushing strongly-typed enum members without the need to always cast them at the call sites. Note that we *only* allow strongly-typed enums in this case. The reason for this is that strongly typed enums have a guaranteed defined size, so the size of the data being pushed is always deterministic. With regular enums this can be a little more error-prone, so we disallow them. This function simply uses the underlying type of the enum to determine the size of the data. For example, if an enum is defined as: enum class SomeEnum : u16 { SomeEntry }; if PushEnum(SomeEnum::SomeEntry); is called, then it will push a u16-size amount of data.
2018-07-20Merge pull request #740 from Subv/acc_crashbunnei
HLE/ACC: Stub IManagerForApplication::GetAccountId to return an error.
2018-07-20Merge pull request #739 from lioncash/gladbunnei
externals: Update glad to version 0.1.25
2018-07-20Merge pull request #738 from lioncash/signbunnei
gl_state: Get rid of mismatched sign conversions in Apply()
2018-07-20Merge pull request #737 from lioncash/movebunnei
filesys/loader: std::move VirtualFile instances in constructors where applicable
2018-07-20Merge pull request #736 from lioncash/nullbunnei
audout_u/audren_u: Ensure null terminators are written out in ListAudioOutsImpl(), ListAudioDeviceName(), and GetActiveAudioDeviceName()
2018-07-20Merge pull request #735 from lioncash/video-unusedbunnei
maxwell_3d: Remove unused variable within GetStageTextures()
2018-07-20Merge pull request #734 from lioncash/threadbunnei
thread: Convert ThreadStatus into an enum class
2018-07-20Merge pull request #733 from lioncash/dirsbunnei
partition_filesystem: Return pfs_dirs member variable within GetSubdirectories()
2018-07-20Merge pull request #732 from lioncash/unusedbunnei
nso: Minor changes