summaryrefslogtreecommitdiff
path: root/src/core
AgeCommit message (Collapse)Author
2020-07-15settings: Resolve a sign conversion warning within GetTimeZoneString()Lioncash
A sign conversion warning was occurring due to an int < size_t comparison.
2020-07-15kernel/process: Move name and system context to the bottom of the member listLioncash
These aren't directly important or commonly used within the process, so we can move these to the bottom to allow everything else to be more likely to be within a cache line.
2020-07-15kernel/handle_table: Remove usages of the global system instanceLioncash
Removes even more usages of the global system instance, trimming away more dependencies on global variables and making them explicit in the interface.
2020-07-15settings: Make use of std::string_view over std::string for loggingLioncash
In all usages of LogSetting(), string literals are provided. std::string_view is better suited here, as we won't churn a bunch of string allocations every time the settings are logged out. While we're at it, we can fold LogSetting() into LogSettings(), given it's only ever used there.
2020-07-15kernel/thread: Remove global GetCurrentThread()Lioncash
This is only used in one place, so we can fold it into the calling code, eliminating a place for the global system instance to be used.
2020-07-15clang formatMorph
2020-07-15Use proper install result when overwriting filesMorph
2020-07-15Remove global system instance and address feedbackMorph
2020-07-15registered_cache: Remove previous update/dlc if it exists on installMorph
- This checks for and removes old updates or dlc based on title id. If a content meta nca exists within the registered cache, it will attempt to remove all the ncas associated with the content meta before installing a new update/dlc
2020-07-15clang-formatVolcaEM
2020-07-15dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister)VolcaEM
This was based on Atmosphére's DMNT Cheat VM: - https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.hpp - https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.cpp From Atmosphére's documentation: "Code type 0xC3 reads or writes a static register with a given register" There are now only two remaining opcodes to implement (PauseProcess and BreakProcess) This is untested because I don't have any experience in testing cheats on yuzu
2020-07-14clang-formatlat9nq
2020-07-14settings: Move settings sanitization to its own functionlat9nq
Creates a new function that can be expanded later to fix other settings that are known to cause emulation errors across executables.
2020-07-14Merge pull request #4294 from MerryMage/cpu-opt-settingsbunnei
configuration: Add settings to enable/disable specific CPU optimizations
2020-07-14Merge pull request #4282 from Morph1984/fs-sizebunnei
filesystem: Set various NAND partition sizes to their defaults
2020-07-13memory_layout: Remove unused data memberLioncash
This isn't used, so it can be removed entirely, shrinking the structure size by 8 bytes.
2020-07-13address_space_info: Use type alias to simplify codeLioncash
We can define an alias for the index arrays and then just reuse it to make the code nicer to read.
2020-07-13address_space_info: Make use of designated initializersLioncash
We can alter the structure so that we can use designated initializers in the array, eliminating the comments that indicate their field names.
2020-07-12kernel/scheduler: Use std::mutex instead of spin lockReinUsesLisp
Profiling shows that this is a highly contested mutex, causing dimishing results compared to a OS lock. std::mutex implementations can spin for a while before falling back to an OS lock. This avoids wasting precious CPU cycles in a no-op.
2020-07-12Merge pull request #4265 from Morph1984/file-renameFernando Sahmkow
vfs_real: Fix MoveFile
2020-07-12fs: Fix RomFS building when zero byte files are presentMorph
When zero byte files are present, the key (offset) for that file is identical to the file right after. A std::map isn't able to fit key-value pairs with identical keys (offsets), therefore, the solution is to use std::multimap which permits multiple entries with the same key. This most prominently fixes Pokemon Sword and Shield weather with any RomFS mod applied.
2020-07-12Merge pull request #4275 from CrazyMax/desired_languagebunnei
AM: fix GetDesiredLanguage:
2020-07-11hle: service: mii: Rewrite service to properly support creation of random ↵bunnei
and default miis.
2020-07-11configure_cpu: Show/Hide debugging optionsMerryMage
2020-07-11configuration: Add settings to enable/disable specific CPU optimizationsMerryMage
2020-07-11Merge pull request #4203 from VolcaEM/servicesbunnei
service: Update function tables
2020-07-10vfs_real: Fix MoveFileMorph
The file wasn't closed prior to being renamed / moved, throwing an error that states "The process cannot access the file because it is being used by another process." Fix this by closing the file prior to a rename / move operation. Fixes saving in Luigi's Mansion 3 and KATANA KAMI: A Way of the Samurai Story.
2020-07-10KeyManager: Prevent writing of invalid keysMorph
If the keys are zero, don't write them to the autogenerated file.
2020-07-10bis_factory: Set User NAND free space to be 1 MiB less than total.Morph
2020-07-10sdmc_factory: Set the SDMC total size to 1 TiBMorph
We should not be limited by the SDMC's partition size, set this to 1 TiB. Hardware is limited to the max allowed by the MBR partition table which is 2 TiB.
2020-07-10bis_factory: Use hardware default NAND partition sizesMorph
Sets the total space of user and system partitions to their hardware defaults. Furthermore, return the total space as free space for the user partition to prevent it from reaching zero. Some games like Bioshock 2 check for the available free space prior to save creation, and we should not be limited by arbitrary limits.
2020-07-10settings: Remove storage size optionsMorph
2020-07-09configuration: implement per-game configurations (#4098)lat9nq
* Switch game settings to use a pointer In order to add full per-game settings, we need to be able to tell yuzu to switch to using either the global or game configuration. Using a pointer makes it easier to switch. * configuration: add new UI without changing existing funcitonality The new UI also adds General, System, Graphics, Advanced Graphics, and Audio tabs, but as yet they do nothing. This commit keeps yuzu to the same functionality as originally branched. * configuration: Rename files These weren't included in the last commit. Now they are. * configuration: setup global configuration checkbox Global config checkbox now enables/disables the appropriate tabs in the game properties dialog. The use global configuration setting is now saved to the config, defaulting to true. This also addresses some changes requested in the PR. * configuration: swap to per-game config memory for properties dialog Does not set memory going in-game. Swaps to game values when opening the properties dialog, then swaps back when closing it. Uses a `memcpy` to swap. Also implements saving config files, limited to certain groups of configurations so as to not risk setting unsafe configurations. * configuration: change config interfaces to use config-specific pointers When a game is booted, we need to be able to open the configuration dialogs without changing the settings pointer in the game's emualtion. A new pointer specific to just the configuration dialogs can be used to separate changes to just those config dialogs without affecting the emulation. * configuration: boot a game using per-game settings Swaps values where needed to boot a game. * configuration: user correct config during emulation Creates a new pointer specifically for modifying the configuration while emulation is in progress. Both the regular configuration dialog and the game properties dialog now use the pointer Settings::config_values to focus edits to the correct struct. * settings: split Settings::values into two different structs By splitting the settings into two mutually exclusive structs, it becomes easier, as a developer, to determine how to use the Settings structs after per-game configurations is merged. Other benefits include only duplicating the required settings in memory. * settings: move use_docked_mode to Controls group `use_docked_mode` is set in the input settings and cannot be accessed from the system settings. Grouping it with system settings causes it to be saved with per-game settings, which may make transferring configs more difficult later on, especially since docked mode cannot be set from within the game properties dialog. * configuration: Fix the other yuzu executables and a regression In main.cpp, we have to get the title ID before the ROM is loaded, else the renderer will reflect only the global settings and now the user's game specific settings. * settings: use a template to duplicate memory for each setting Replaces the type of each variable in the Settings::Values struct with a new class that allows basic data reading and writing. The new struct Settings::Setting duplicates the data in memory and can manage global overrides per each setting. * configuration: correct add-ons config and swap settings when apropriate Any add-ons interaction happens directly through the global values struct. Swapping bewteen structs now also includes copying the necessary global configs that cannot be changed nor saved in per-game settings. General and System config menus now update based on whether it is viewing the global or per-game settings. * settings: restore old values struct No longer needed with the Settings::Setting class template. * configuration: implement hierarchical game properties dialog This sets the apropriate global or local data in each setting. * clang format * clang format take 2 can the docker container save this? * address comments and style issues * config: read and write settings with global awareness Adds new functions to read and write settings while keeping the global state in focus. Files now generated per-game are much smaller since often they only need address the global state. * settings: restore global state when necessary Upon closing a game or the game properties dialog, we need to restore all global settings to the original global state so that we can properly open the configuration dialog or boot a different game. * configuration: guard setting values incorrectly This disables setting values while a game is running if the setting is overwritten by a per game setting. * config: don't write local settings in the global config Simple guards to prevent writing the wrong settings in the wrong files. * configuration: add comments, assume less, and clang format No longer assumes that a disabled UI element means the global state is turned off, instead opting to directly answer that question. Still however assumes a game is running if it is in that state. * configuration: fix a logic error Should not be negated * restore settings' global state regardless of accept/cancel Fixes loading a properties dialog and causing the global config dialog to show local settings. * fix more logic errors Fixed the frame limit would set the global setting from the game properties dialog. Also strengthened the Settings::Setting member variables and simplified the logic in config reading (ReadSettingGlobal). * fix another logic error In my efforts to guard RestoreGlobalState, I accidentally negated the IsPowered condition. * configure_audio: set toggle_stretched_audio to tristate * fixed custom rtc and rng seed overwriting the global value * clang format * rebased * clang format take 4 * address my own review Basically revert unintended changes * settings: literal instead of casting "No need to cast, use 1U instead" Thanks, Morph! Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> * Revert "settings: literal instead of casting " This reverts commit 95e992a87c898f3e882ffdb415bb0ef9f80f613f. * main: fix status buttons reporting wrong settings after stop emulation * settings: Log UseDockedMode in the Controls group This should have happened when use_docked_mode was moved over to the controls group internally. This just reflects this in the log. * main: load settings if the file has a title id In other words, don't exit if the loader has trouble getting a title id. * use a zero * settings: initalize resolution factor with constructor instead of casting * Revert "settings: initalize resolution factor with constructor instead of casting" This reverts commit 54c35ecb46a29953842614620f9b7de1aa9d5dc8. * configure_graphics: guard device selector when Vulkan is global Prevents the user from editing the device selector if Vulkan is the global renderer backend. Also resets the vulkan_device variable when the users switches back-and-forth between global and Vulkan. * address reviewer concerns Changes function variables to const wherever they don't need to be changed. Sets Settings::Setting to final as it should not be inherited from. Sets ConfigurationShared::use_global_text to static. Co-Authored-By: VolcaEM <volcaem@users.noreply.github.com> * main: load per-game settings after LoadROM This prevents `Restart Emulation` from restoring the global settings *after* the per-game settings were applied. Thanks to BSoDGamingYT for finding this bug. * Revert "main: load per-game settings after LoadROM" This reverts commit 9d0d48c52d2dcf3bfb1806cc8fa7d5a271a8a804. * main: only restore global settings when necessary Loading the per-game settings cannot happen after the ROM is loaded, so we have to specify when to restore the global state. Again thanks to BSoD for finding the bug. * configuration_shared: address reviewer concerns except operator overrides Dropping operator override usage in next commit. Co-Authored-By: LC <lioncash@users.noreply.github.com> * settings: Drop operator overrides from Setting template Requires using GetValue and SetValue explicitly. Also reverts a change that broke title ID formatting in the game properties dialog. * complete rebase * configuration_shared: translate "Use global configuration" Uses ConfigurePerGame to do so, since its usage, at least as of now, corresponds with ConfigurationShared. * configure_per_game: address reviewer concern As far as I understand, it prevents the program from unnecessarily copying strings. Co-Authored-By: LC <lioncash@users.noreply.github.com> Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> Co-authored-by: VolcaEM <volcaem@users.noreply.github.com> Co-authored-by: LC <lioncash@users.noreply.github.com>
2020-07-09Merge pull request #4248 from Morph1984/CreateManagedDisplaySeparableLayerbunnei
AM/ISelfController: Stub CreateManagedDisplaySeparableLayer
2020-07-09Merge pull request #4202 from ReinUsesLisp/scoped-lockbunnei
core_timing,scheduler: Use std::scoped_lock when possible
2020-07-08AM: fix GetDesiredLanguage:CrazyMax
try to get a control metadata from application update when is failed to get from the basic version. Tested on Kirby Star Allies
2020-07-08Merge pull request #4243 from CrazyMax/display_versionbunnei
AM: fix GetDisplayVersion
2020-07-08Merge pull request #4245 from MerryMage/page-table-racebunnei
memory: Race-condition in pagetables.
2020-07-07cpu_interrupt_handler: Remove #pragma once from .cpp fileMerryMage
2020-07-07GetDisplayVersion should return a null-terminated version string.CrazyMax
also, in case of failed to get of the basic version, we will try get it from application update.
2020-07-05memory: Set page-table pointers before setting attribute = MemoryMerryMage
2020-07-05AM/ISelfController: Stub CreateManagedDisplaySeparableLayerMorph
Stub this by sending 1 layer id instead of 2 as yuzu does not support multiple layers per display. No adverse side effects have been observed. - Used by Animal Crossing: New Horizons Update 1.3.0
2020-07-04Merge pull request #4218 from ogniK5377/opus-externalRodrigo Locatti
externals: Track opus as submodule instead of using conan
2020-07-02Merge pull request #3924 from ogniK5377/GetKeyCodeMapbunnei
Implement GetKeyCodeMap & GetKeyCodeMap2
2020-07-02Merge pull request #4193 from ogniK5377/GetIndirectLayerConsumerHandle-stubbunnei
am: Stub GetIndirectLayerConsumerHandle
2020-07-02Merge pull request #4192 from ogniK5377/acc-ListOpenContextStoredUsers-stubbunnei
acc: ListOpenContextStoredUsers partial stub
2020-07-02Rename two functions in NSVolcaEM
- Rename "GetShellEvent" to "GetShellEventHandle" - Rename "LaunchApplicationFromHost" to "LaunchApplication"
2020-07-02Rename GetApplicationArea2 to GetApplicationAreaSizeVolcaEM
2020-07-01externals: Track opus as submodule instead of using conanDavid Marcec
Supersedes #4068 see for details.
2020-07-01key_manager: Correct casing of instance()Lioncash
Our codebase uppercases member function names.