| Age | Commit message (Collapse) | Author |
|---|
|
Another request from GillianMC.
The translated strings have been placed in a separate "Hotkeys" context as an alternative
to having to add the tr function to the Config class, or adding them to ConfigureHotkeys
context which is quite long. The English strings get attached to the items in the Action
column as "data", and are used for RetranslateUI and saving the hotkey configuration.
|
|
Also configure minimum width of columns to be 150px.
|
|
|
|
|
|
- Removes a dependency on core and input_common from common.
|
|
There's no need to translate an empty string. This just gives
translators unnecessary work.
|
|
|
|
|
|
To prepare for translation support, this makes all of the widgets
cognizant of the language change event that occurs whenever
installTranslator() is called and automatically retranslates their text
where necessary.
This is important as calling the backing UI's retranslateUi() is often
not enough, particularly in cases where we add our own strings that
aren't controlled by it. In that case we need to manually refresh the
strings ourselves.
|
|
|
|
Nothing from the hotkeys dialog relies on this call occurring, and is
already called from the dialog that calls applyConfiguration().
|
|
Avoids mentioning the user and formalizes the error itself.
|
|
critical() is intended for critical/fatal errors that threaten the
overall stability of an application. A user entering a conflicting key
sequence is neither of those.
|
|
We don't need to extract the entire set of hotkeys into a list and then
iterate through it. We can traverse the list and early-exit if we're
able to.
|
|
1. This is something that should be solely emitted by the hotkey dialog
itself
2. This is functionally unused, given there's nothing listening for the
signal.
|
|
Without passing in a parent, this can result in focus being stolen from
the dialog in certain cases.
Example:
On Windows, if the logging window is left open, the logging Window will
potentially get focus over the hotkey dialog itself, since it brings all
open windows for the application into view. By specifying a parent, we
only bring windows for the parent into view (of which there are none,
aside from the hotkey dialog).
|
|
Without a parent, this dialog won't have its memory freed when it
happens to get destroyed.
|
|
Configure()
|
|
This is checking if an index is valid or not and returning early if it
isn't.
|
|
This doesn't actually modify instance state of the dialog, so this can
be made const.
|
|
* Adds a new Hotkeys tab in the Controls group.
* Double-click a Hotkey to rebind it.
|
