| Age | Commit message (Collapse) | Author |
|---|
|
game_list: Use QString::fromStdString() where applicable instead of c_str()
|
|
* GDBStub works with both Unicorn and Dynarmic now
* Tidy up
|
|
game_list: Join declarations and assignments in onTextChanged()
|
|
qt/main: Collapse if statement in UpdateRecentFiles()
|
|
qt: Don't show error dialog when canceling the Load Folder dialog
|
|
qt: Minor cleanup-related changes
|
|
kernel/event: Make data members private
|
|
This was intermixing signed and unsigned values when they could all just
be signed.
|
|
We can just use the file interfaces that Qt provides to prevent needing
to convert to std::string.
|
|
The codec used by Qt for const char* and std::string don't necessarily
have to be the same depending on locale. Therefore, we should be using
the correct functions to do the conversions.
|
|
There's no need to keep these separate from one another.
|
|
Given the function accepts a boolean, we don't need to use an if
statement here and repeat ourselves.
|
|
UpdateUITheme()
In OnMenuRecentFile() we don't need to construct a QFileInfo instance
just to check if a file exists, we can just use the static member
function to do that (which Qt's documentation also notes as quicker than
constructing an instance).
In UpdateUITheme(), we just want to try and open the file and check the
success of that operation. Technically speaking, between the existence
check and the open call, the file can be deleted or moved, but still
appear to succeed in code. i.e.
1. Existence check -> Returns true
2. File is moved/deleted
3. Open is called, the return value of which isn't checked
4. Nonsense behavior
This way we combine the existence check and the open into one.
|
|
Previously, when canceling out of the Load Folder dialog, a user would
get an error dialog about the selected folder not containing a main
file, however, by canceling out of the dialog, no selection was actually
made.
|
|
These occur automatically without the need to call them. While we're at
it, also std::move the QString instance into its member variable.
|
|
|
|
Makes code consistent with our style of defaulting special member
functions where applicable.
|
|
Instead we can simply provide accessors to the required data instead of
giving external read/write access to the variables directly.
|
|
video_core: Eliminate the g_renderer global variable
|
|
XCI and Encrypted NCA Support
|
|
We move the initialization of the renderer to the core class, while
keeping the creation of it and any other specifics in video_core. This
way we can ensure that the renderer is initialized and doesn't give
unfettered access to the renderer. This also makes dependencies on types
more explicit.
For example, the GPU class doesn't need to depend on the
existence of a renderer, it only needs to care about whether or not it
has a rasterizer, but since it was accessing the global variable, it was
also making the renderer a part of its dependency chain. By adjusting
the interface, we can get rid of this dependency.
|
|
IProfile::Get and SET::GetLanguageCode for libnx tests (#851)
|
|
video_core: Make global EmuWindow instance part of the base renderer …
|
|
kernel: Move object class to its own source files
|
|
Makes the signal/slot connections type-safe instead of string-based.
|
|
General moving to keep kernel object types separate from the direct
kernel code. Also essentially a preliminary cleanup before eliminating
global kernel state in the kernel code.
|
|
Makes the global a member of the RendererBase class. We also change this
to be a reference. Passing any form of null pointer to these functions
is incorrect entirely, especially given the code itself assumes that the
pointer would always be in a valid state.
This also makes it easier to follow the lifecycle of instances being
used, as we explicitly interact the renderer with the rasterizer, rather
than it just operating on a global pointer.
|
|
|
|
|
|
|
|
|
|
|
|
Port #3837 from Citra: "citra-qt: Add build date in about dialog"
|
|
|
|
Port #3911 from Citra: "citra-qt: optimize settings application"
|
|
|
|
|
|
|
|
Port #3594 from Citra: "citra_qt: Add Continue/Pause & Toggle Speed Limit hotkeys"
|
|
kernel/timer: Make data members private where applicable
|
|
|
|
Instead, we can just expose functions that return the queryable state
instead of letting anything modify it.
|
|
|
|
We were missing the enum entry for WaitIPC
|
|
If code execution hits this spot, something has gone very wrong, so mark
the path as unreachable. This silences a warning on MSVC.
|
|
|
|
This avoids a truncating cast on size. I doubt we'd ever traverse a
directory this large, however we also shouldn't truncate sizes away.
|
|
Instead of using an unsigned int as a parameter and expecting a user to
always pass in the correct values, we can just convert the enum into an
enum class and use that type as the parameter type instead, which makes
the interface more type safe.
We also get rid of the bookkeeping "NUM_" element in the enum by just
using an unordered map. This function is generally low-frequency in
terms of calls (and I'd hope so, considering otherwise would mean we're
slamming the disk with IO all the time) so I'd consider this acceptable
in this case.
|
|
This makes it match its const qualified equivalent.
|
|
Makes the thread status strongly typed, so implicit conversions can't
happen. It also makes it easier to catch mistakes at compile time.
|
