| Age | Commit message (Collapse) | Author |
|---|
|
yuzu/wait_tree: Pass QString by value and std::move in the initializer list for WaitTreeText
|
|
We can hide the direct array from external view and instead provide
functions to retrieve the necessary info. This has the benefit of
completely hiding the makeup of the SinkDetails structure from the rest
of the code.
Given that this makes the array hidden, we can also make the array
constexpr by altering the members slightly. This gets rid of several
static constructor calls related to std::vector and std::function.
Now we don't have heap allocations here that need to occur before the
program can even enter main(). It also has the benefit of saving a
little bit of heap space, but this doesn't matter too much, since the
savings in that regard are pretty tiny.
|
|
patch_manager: Add support for disabling patches
|
|
loaders: Make GetFileType() a const qualified member function
|
|
for WaitTreeText
Just a trivial modernization that potentially avoids copying strings in certain scenarios.
|
|
AddFstEntriesToGameList()
Similarly, here we can avoid doing unnecessary work twice by retrieving
the file type only once and comparing it against relevant operands,
avoiding potential unnecessary object construction/destruction.
|
|
in MakeGameListEntry()
While GetFileType() is indeed a getter function, that doesn't mean it's
a trivial function, given some case require reading from the data or
constructing other objects in the background. Instead, only do necessary
work once.
|
|
|
|
Greatly simplifies the current input UI, while still allowing power users to tweak advanced settings. Adds 'input profiles', which are easy autoconfigurations to make getting started easy and fast. Also has a custom option which brings up the current, full UI.
|
|
|
|
|
|
|
|
Avoids typing the same long accessor just to retrieve player attributes.
|
|
yuzu/game_list_worker: Minor cleanup and code deduplication
|
|
check in callbacks
Avoids potentially allocating a std::string instance when it isn't
needed.
|
|
|
|
|
|
writable events
Two kernel object should absolutely never have the same handle ID type.
This can cause incorrect behavior when it comes to retrieving object
types from the handle table. In this case it allows converting a
WritableEvent into a ReadableEvent and vice-versa, which is undefined
behavior, since the object types are not the same.
This also corrects ClearEvent() to check both kernel types like the
kernel itself does.
|
|
|
|
Fixes bugs relating to signalling in software keyboard.
|
|
Presents profiles in a list, similar to switch.
|
|
|
|
|
|
|
|
yuzu/configuration: Minor clean-up related changes
|
|
filesystem: De-globalize registered_cache_union
|
|
kernel: Divide Event into ReadableEvent and WritableEvent
|
|
|
|
These slots are only ever attached to event handling mechanisms within
the class itself, they're never used externally. Because of this, we can
make the functions private.
This also removes redundant usages of the private access specifier.
|
|
classes
Resolves trivial compiler warnings.
|
|
The previous code could potentially be a compilation issue waiting to
occur, given we forward declare the type for a std::unique_ptr. If the
complete definition of the forward declared type isn't visible in a
translation unit that the class is used in, then it would fail to
compile.
Defaulting the destructor in a cpp file ensures the std::unique_ptr's
destructor is only invoked where its complete type is known.
|
|
video_core: Minor style changes
|
|
We can just return a new instance of this when it's requested. This only
ever holds pointers to the existing registed caches, so it's not a large
object. Plus, this also gets rid of the need to keep around a separate
member function just to properly clear out the union.
Gets rid of one of five globals in the filesystem code.
|
|
Avoids duplicating the same code twice verbatim.
|
|
We don't need to call out to our own file handling functions when we're
going to construct a QFileInfo instance right after it. We also don't
need to convert to a std::string again just to compare the file
extension.
|
|
|
|
|
|
|
|
|
|
Uncheck automatically joycons docked when docked mode is enable
|
|
|
|
file_sys/registered_cache: Use regular const references instead of std::shared_ptr for InstallEntry()
|
|
instead of u8
Prevents compiler warnings related to truncation when invoking the
dialog. It's also extremely suspect to use a u8 value here instead of a
more general type to begin with.
|
|
This doesn't depend on any part of the private interface, so it can be
made a non-member internal function.
|
|
std::shared_ptr for InstallEntry()
These parameters don't need to utilize a shared lifecycle directly in
the interface. Instead, the caller should provide a regular reference
for the function to use. This also allows the type system to flag
attempts to pass nullptr and makes it more generic, since it can now be
used in contexts where a shared_ptr isn't being used (in other words, we
don't constrain the usage of the interface to a particular mode of
memory management).
|
|
std::bind is the pre-C++11 way of doing this.
|
|
Orders the elements the way they would actually be initialized in.
Resolves compiler warnings with gcc and clang
|
|
|
|
The common pattern is to put the data members after the function
interface where applicable.
|
|
|
