| Age | Commit message (Collapse) | Author |
|---|
|
With C++20, we can use the more concise contains() member function
instead of comparing the result of the find() call with the end
iterator.
|
|
map_interval: Change field order to address uninitialized field warning
|
|
shader_ir: std::move node within DeclareAmend()
|
|
Prevents logic errors from occurring from unused values.
|
|
Reduces the amount of dependencies the header pulls in.
|
|
video_core: Remove unnecessary enum class casting in logging messages
|
|
core: Mark unused fields as [[maybe_unused]]
|
|
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
|
|
Same behavior, but elides an unnecessary atomic reference count
increment and decrement.
|
|
fmt now automatically prints the numeric value of an enum class member
by default, so we don't need to use casts any more.
Reduces the line noise a bit.
|
|
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
|
|
boxcat: Avoid unnecessary object copy
|
|
renderer_vulkan: Add missing `override` specifier
|
|
video_core: Resolve more variable shadowing scenarios pt.3
|
|
`PhysicalCore`'s move assignment operator was declared as `= default`,
but was implicitly deleted because `PhysicalCore` has fields
of reference type. Switch to explicitly deleting it to avoid a Clang
warning.
The move *constructor* is still defaulted, and is required to exist due
to the use of `std::vector<PhysicalCore>`.
|
|
- Add a type check so that calling Push with an invalid type produces a
compile error rather than a linker error.
- vi.cpp was calling Push with a variable of type `std::size_t`.
There's no explicit overload for `size_t`, but there is one for `u64`,
which on most platforms is the same type as `size_t`. On macOS,
however, it isn't: both types are 64 bits, but `size_t` is `unsigned
long` and `u64` is `unsigned long long`. Regardless, it makes more
sense to explicitly use `u64` here instead of `size_t`.
|
|
|
|
Clang complains about `new_chunk`'s constructor using the
then-uninitialized `first_chunk` (even though it's just to get a pointer
into it).
|
|
|
|
|
|
already declared in the superclass
|
|
The previous definition was:
#define NUM(field_name) (sizeof(Maxwell3D::Regs::field_name) / sizeof(u32))
In cases where `field_name` happens to refer to an array, Clang thinks
`sizeof(an array value) / sizeof(a type)` is an instance of the idiom
where `sizeof` is used to compute an array length. So it thinks the
type in the denominator ought to be the array element type, and warns if
it isn't, assuming this is a mistake.
In reality, `NUM` is not used to get array lengths at all, so there is no
mistake. Silence the warning by applying Clang's suggested workaround
of parenthesizing the denominator.
|
|
yuzu_cmd: Remove 'users_size'
|
|
maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict
|
|
Port citra-emu/citra#5577: "Update cubeb and request a persistent stream session"
|
|
xbyak_abi: Avoid implicit sign conversions
|
|
On Apple platforms, FALSE and TRUE are defined as macros by
<mach/boolean.h>, which is included by various system headers.
Note that there appear to be no actual users of the names to fix up.
|
|
Specifically:
const auto size = sdl2_config->GetInteger("System", "users_size", 0);
The variable is never used, producing a warning. I wondered if this
ought to be assigning something to in `Settings`, but nothing else in
the codebase ever mentions a setting called "users_size", so I guess
it's safe to remove...
|
|
|
|
Cleans out the rest of the occurrences of variable shadowing and makes
any further occurrences of shadowing compiler errors.
|
|
This is designated as obsolete in Qt's docs (see:
https://doc.qt.io/qt-5/qvariant-obsolete.html#operator-lt)
|
|
Migrates the video core code closer to enabling variable shadowing
warnings as errors.
This primarily sorts out shadowing occurrences within the Vulkan code.
|
|
video_core: Resolve more variable shadowing scenarios
|
|
Port citra-emu/citra#5617: "Fix telemetry-related exit crash from use-after-free"
|
|
Makes for less reading.
|
|
|
|
|
|
Co-Authored-By: xperia64 <xperia64@users.noreply.github.com>
|
|
This was only necessary for use with the
avcodec_decode_video2/avcoded_decode_audio4 APIs which are also
deprecated.
Given we use avcodec_send_packet/avcodec_receive_frame, this isn't
necessary, this is even indicated directly within the FFmpeg API changes
document here on 2017-09-26:
https://github.com/FFmpeg/FFmpeg/blob/master/doc/APIchanges#L410
This prevents our code from breaking whenever we update to a newer
version of FFmpeg in the future if they ever decide to fully remove this
API member.
|
|
Resolves variable shadowing scenarios up to the end of the OpenGL code
to make it nicer to review. The rest will be resolved in a following
commit.
|
|
node: Eliminate variable shadowing
|
|
vp9/vic: Resolve pessimizing moves
|
|
Kernel: Refactor to use 4-instances of Dynarmic & various cleanups and improvements
|
|
Prevents logic bugs from accidentally ignoring the return value.
|
|
|
|
Removes the usage of moves that don't result in behavior different from
a copy, or otherwise would prevent copy elision from occurring.
|
|
|
|
Allows the struct to be constructed in place.
|
|
Removes the use of two static casts and improves the readability of some
vectors slightly.
|
|
|
