Age | Commit message (Collapse) | Author |
|
fsp_srv: Misc individual changes
|
|
filesystem: Minor changes
|
|
common/swap: Minor changes
|
|
common/common_funcs: Remove unused rotation functions
|
|
loader/{nro, nso}: Resolve compilation warnings
|
|
common/misc: Deduplicate code in GetLastErrorMsg()
|
|
file_util: return string by const reference for GetExeDirectory()
|
|
string_util: Remove AsciiToHex()
|
|
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
|
|
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
|
|
content_archive: Minor changes
|
|
We can avoid constructing a std::vector here by simply passing a pointer
to the original data and the size of the copy we wish to perform to the
backend's Write() function instead, avoiding copying the data where it's
otherwise not needed.
|
|
function
We were using a second std::vector as a buffer to convert another
std::vector's data into a byte sequence, however we can just use
pointers to the original data and use them directly with WriteBuffer,
which avoids copying the data at all into a separate std::vector.
We simply cast the pointers to u8* (which is allowed by the standard,
given std::uint8_t is an alias for unsigned char on platforms that we
support).
|
|
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
|
|
gl_state: Temporarily disable culling and depth test.
|
|
constructor
Avoids unnecessary atomic reference count incrementing and decrementing
|
|
a literal
This is simply a basic value check as opposed to potentially doing
string based operations (unlikely, but still, avoiding it is free).
|
|
This was just an artifact missed during PR review.
|
|
Prevents implicit conversions.
|
|
Gets rid of relying on indirect inclusions.
|
|
|
|
Previously we were just copying the data whole-sale, even if the length
was less than the total data size. This effectively makes the
actual_data vector useless, which is likely not intended.
Instead, amend this to only copy the given length amount of data.
At the same time, we can avoid zeroing out the data before using it by
passing iterators to the constructor instead of a size.
|
|
|
|
|
|
|
|
These are unused and essentially don't provide much benefit either. If
we ever need rotation functions, these can be introduced in a way that
they don't sit in a common_* header and require a bunch of ifdefing to
simply be available
|
|
Android and macOS have supported thread_local for quite a while, but
most importantly is that we don't even really need it. Instead of using
a thread-local buffer, we can just return a non-static buffer as a
std::string, avoiding the need for that quality entirely.
|
|
This disallows modifying the internal string buffer (which shouldn't be
modified anyhow).
|
|
Easy TODO
|
|
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
|
|
core/memory, core/hle/kernel: Use std::move where applicable
|
|
member function
This function doesn't alter class state.
|
|
initialized
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.
While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
|
|
|
|
There's no need to take this by value when it's possible to avoid
unnecessary copies entirely like this.
|
|
|
|
Gets rid of unnecessary atomic reference count incrementing and
decrementing.
|
|
We can just use a generic lambda to avoid writing the same thing twice.
|
|
service/prepo: Add missing header guard
|
|
externals: update fmt to version 5.1.0
|
|
|
|
We can just initialize these vectors directly via their constructor.
|
|
|
|
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
|
|
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
|
|
core: Don't construct instance of Core::System, just to access its live instance
|
|
decoders: Fix calc of swizzle image_width_in_gobs.
|
|
game_list: Make ContainsAllWords an internally linked non-member function
|
|
|
|
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
|