summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2018-07-19Merge pull request #712 from lioncash/fspbunnei
fsp_srv: Misc individual changes
2018-07-19Merge pull request #713 from lioncash/filesysbunnei
filesystem: Minor changes
2018-07-19Merge pull request #711 from lioncash/swapbunnei
common/swap: Minor changes
2018-07-19Merge pull request #710 from lioncash/unusedbunnei
common/common_funcs: Remove unused rotation functions
2018-07-19Merge pull request #694 from lioncash/warnbunnei
loader/{nro, nso}: Resolve compilation warnings
2018-07-19Merge pull request #709 from lioncash/thread-localbunnei
common/misc: Deduplicate code in GetLastErrorMsg()
2018-07-19Merge pull request #705 from lioncash/string-refbunnei
file_util: return string by const reference for GetExeDirectory()
2018-07-19Merge pull request #704 from lioncash/stringbunnei
string_util: Remove AsciiToHex()
2018-07-19Merge pull request #703 from lioncash/constbunnei
savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function
2018-07-19Merge pull request #702 from lioncash/initializebunnei
partition_filesystem: Ensure all class members of PartitionFilesystem are initialized
2018-07-19Merge pull request #701 from lioncash/movingbunnei
content_archive: Minor changes
2018-07-19fsp_srv: Remove unnecessary vector construction in IFile's Write() functionLioncash
We can avoid constructing a std::vector here by simply passing a pointer to the original data and the size of the copy we wish to perform to the backend's Write() function instead, avoiding copying the data where it's otherwise not needed.
2018-07-19fsp_srv: Remove unnecessary std::vector construction in IDirectory's Read() ↵Lioncash
function We were using a second std::vector as a buffer to convert another std::vector's data into a byte sequence, however we can just use pointers to the original data and use them directly with WriteBuffer, which avoids copying the data at all into a separate std::vector. We simply cast the pointers to u8* (which is allowed by the standard, given std::uint8_t is an alias for unsigned char on platforms that we support).
2018-07-19Merge pull request #699 from lioncash/vfsbunnei
vfs: Deduplicate accumulation code in VfsDirectory's GetSize()
2018-07-19Merge pull request #697 from bunnei/disable-depth-cullbunnei
gl_state: Temporarily disable culling and depth test.
2018-07-19filesystem: std::move VirtualDir instance in VfsDirectoryServiceWrapper's ↵Lioncash
constructor Avoids unnecessary atomic reference count incrementing and decrementing
2018-07-19filesystem: Use std::string's empty() function instead of comparing against ↵Lioncash
a literal This is simply a basic value check as opposed to potentially doing string based operations (unlikely, but still, avoiding it is free).
2018-07-19filesystem: Remove pragma disabling global optimizationsLioncash
This was just an artifact missed during PR review.
2018-07-19fsp_srv: Make IStorage constructor explicitLioncash
Prevents implicit conversions.
2018-07-19fsp_srv: Add missing includesLioncash
Gets rid of relying on indirect inclusions.
2018-07-19fsp_srv: Resolve sign-mismatch warnings in assertion comparisonsLioncash
2018-07-19fsp_srv: Respect write length in Write()Lioncash
Previously we were just copying the data whole-sale, even if the length was less than the total data size. This effectively makes the actual_data vector useless, which is likely not intended. Instead, amend this to only copy the given length amount of data. At the same time, we can avoid zeroing out the data before using it by passing iterators to the constructor instead of a size.
2018-07-19common/swap: Remove unnecessary const on return value of swap()Lioncash
2018-07-19common/swap: Use static_cast where applicableLioncash
2018-07-19common/swap: Use using aliases where applicableLioncash
2018-07-19common/common_funcs: Remove unused rotation functionsLioncash
These are unused and essentially don't provide much benefit either. If we ever need rotation functions, these can be introduced in a way that they don't sit in a common_* header and require a bunch of ifdefing to simply be available
2018-07-19common/misc: Deduplicate code in GetLastErrorMsg()Lioncash
Android and macOS have supported thread_local for quite a while, but most importantly is that we don't even really need it. Instead of using a thread-local buffer, we can just return a non-static buffer as a std::string, avoiding the need for that quality entirely.
2018-07-19file_util: return string by const reference for GetExeDirectory()Lioncash
This disallows modifying the internal string buffer (which shouldn't be modified anyhow).
2018-07-18string_util: Remove AsciiToHex()Lioncash
Easy TODO
2018-07-18Merge pull request #692 from lioncash/assignbunnei
address_arbiter: Correct assignment within an assertion statement in WakeThreads()
2018-07-18Merge pull request #690 from lioncash/movebunnei
core/memory, core/hle/kernel: Use std::move where applicable
2018-07-18savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const ↵Lioncash
member function This function doesn't alter class state.
2018-07-18partition_filesystem: Ensure all class members of PartitionFilesystem are ↵Lioncash
initialized Previously is_hfs and pfs_header members wouldn't be initialized in the constructor, as they were stored in locals instead. This would result in things like GetName() and PrintDebugInfo() behaving incorrectly. While we're at it, initialize the members to deterministic values as well, in case loading ever fails.
2018-07-18gl_state: Temporarily disable culling and depth test.bunnei
2018-07-18content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const referenceLioncash
There's no need to take this by value when it's possible to avoid unnecessary copies entirely like this.
2018-07-18content_archive: Add missing standard includesLioncash
2018-07-18content_archive: std::move VirtualFile in NCA's constructorLioncash
Gets rid of unnecessary atomic reference count incrementing and decrementing.
2018-07-18vfs: Deduplicate accumulation code in VfsDirectory's GetSize()Lioncash
We can just use a generic lambda to avoid writing the same thing twice.
2018-07-18Merge pull request #691 from lioncash/guardbunnei
service/prepo: Add missing header guard
2018-07-18Merge pull request #686 from lioncash/fmtbunnei
externals: update fmt to version 5.1.0
2018-07-18loader/nro: Resolve sign mismatch warningsLioncash
2018-07-18loader/nso: Remove unnecessary vector resizesLioncash
We can just initialize these vectors directly via their constructor.
2018-07-18loader/nso: Resolve sign mismatch warningsLioncash
2018-07-18Merge pull request #688 from lioncash/commabunnei
vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
2018-07-18Merge pull request #693 from lioncash/unusedbunnei
core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()
2018-07-18Merge pull request #687 from lioncash/instancebunnei
core: Don't construct instance of Core::System, just to access its live instance
2018-07-18Merge pull request #680 from bunnei/fix-swizzbunnei
decoders: Fix calc of swizzle image_width_in_gobs.
2018-07-18Merge pull request #684 from lioncash/nonmemberbunnei
game_list: Make ContainsAllWords an internally linked non-member function
2018-07-18decoders: Fix calc of swizzle image_width_in_gobs.bunnei
2018-07-18Virtual Filesystem 2: Electric Boogaloo (#676)Zach Hilman
* Virtual Filesystem * Fix delete bug and documentate * Review fixes + other stuff * Fix puyo regression