From ba7eb5abf4cd50b4dd1dc894bc633b678d38a1cb Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 15 Sep 2020 03:13:22 -0400 Subject: cheat_engine: Remove unnecessary system argument to CheatParser's Parse function This isn't used within the function at all in any implementations, so we can remove it entirely. --- src/core/memory/cheat_engine.cpp | 5 ++--- src/core/memory/cheat_engine.h | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) (limited to 'src/core/memory') diff --git a/src/core/memory/cheat_engine.cpp b/src/core/memory/cheat_engine.cpp index e503118dd..68d09d350 100644 --- a/src/core/memory/cheat_engine.cpp +++ b/src/core/memory/cheat_engine.cpp @@ -98,10 +98,9 @@ std::string_view ExtractName(std::string_view data, std::size_t start_index) { } } // Anonymous namespace -std::vector TextCheatParser::Parse(const Core::System& system, - std::string_view data) const { +std::vector TextCheatParser::Parse(std::string_view data) const { std::vector out(1); - std::optional current_entry = std::nullopt; + std::optional current_entry; for (std::size_t i = 0; i < data.size(); ++i) { if (::isspace(data[i])) { diff --git a/src/core/memory/cheat_engine.h b/src/core/memory/cheat_engine.h index fa039a831..a31002346 100644 --- a/src/core/memory/cheat_engine.h +++ b/src/core/memory/cheat_engine.h @@ -47,8 +47,7 @@ class CheatParser { public: virtual ~CheatParser(); - virtual std::vector Parse(const Core::System& system, - std::string_view data) const = 0; + [[nodiscard]] virtual std::vector Parse(std::string_view data) const = 0; }; // CheatParser implementation that parses text files @@ -56,7 +55,7 @@ class TextCheatParser final : public CheatParser { public: ~TextCheatParser() override; - std::vector Parse(const Core::System& system, std::string_view data) const override; + [[nodiscard]] std::vector Parse(std::string_view data) const override; }; // Class that encapsulates a CheatList and manages its interaction with memory and CoreTiming -- cgit v1.2.3