From 29b6afb82f39a9f21389e2d9ee65ff6cdd909db8 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 2 Aug 2018 21:41:51 -0400 Subject: input_common: Add missing override specifiers --- src/input_common/keyboard.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/input_common/keyboard.cpp') diff --git a/src/input_common/keyboard.cpp b/src/input_common/keyboard.cpp index 0f0d10f23..0410ff328 100644 --- a/src/input_common/keyboard.cpp +++ b/src/input_common/keyboard.cpp @@ -14,7 +14,7 @@ public: explicit KeyButton(std::shared_ptr key_button_list_) : key_button_list(key_button_list_) {} - ~KeyButton(); + ~KeyButton() override; bool GetStatus() const override { return status.load(); -- cgit v1.2.3 From 684fc2c32067cf450cd1e95c036c5337aa860718 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 2 Aug 2018 21:51:08 -0400 Subject: input_common: Use std::move where applicable Avoids unnecessary atomic reference count increments and decrements --- src/input_common/keyboard.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/input_common/keyboard.cpp') diff --git a/src/input_common/keyboard.cpp b/src/input_common/keyboard.cpp index 0410ff328..525fe6abc 100644 --- a/src/input_common/keyboard.cpp +++ b/src/input_common/keyboard.cpp @@ -5,6 +5,7 @@ #include #include #include +#include #include "input_common/keyboard.h" namespace InputCommon { @@ -12,7 +13,7 @@ namespace InputCommon { class KeyButton final : public Input::ButtonDevice { public: explicit KeyButton(std::shared_ptr key_button_list_) - : key_button_list(key_button_list_) {} + : key_button_list(std::move(key_button_list_)) {} ~KeyButton() override; -- cgit v1.2.3