From b04c7b63435ad51ce747d678be3fe5899f14609e Mon Sep 17 00:00:00 2001 From: vonchenplus Date: Tue, 26 Oct 2021 23:01:57 +0800 Subject: Support gl_BackColor attribute --- src/shader_recompiler/backend/spirv/emit_context.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'src/shader_recompiler/backend/spirv/emit_context.cpp') diff --git a/src/shader_recompiler/backend/spirv/emit_context.cpp b/src/shader_recompiler/backend/spirv/emit_context.cpp index 2885e6799..9d84c4fc6 100644 --- a/src/shader_recompiler/backend/spirv/emit_context.cpp +++ b/src/shader_recompiler/backend/spirv/emit_context.cpp @@ -1286,6 +1286,14 @@ void EmitContext::DefineInputs(const IR::Program& program) { Decorate(id, spv::Decoration::Location, location); input_front_color = id; } + if (loads.AnyComponent(IR::Attribute::ColorBackDiffuseR)) { + const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); + previous_unused_location = location; + used_locations.set(location); + const Id id{DefineInput(*this, F32[4], true)}; + Decorate(id, spv::Decoration::Location, location); + input_back_color = id; + } for (size_t index = 0; index < NUM_FIXEDFNCTEXTURE; ++index) { if (loads.AnyComponent(IR::Attribute::FixedFncTexture0S + index * 4)) { const size_t location = @@ -1363,6 +1371,14 @@ void EmitContext::DefineOutputs(const IR::Program& program) { Decorate(id, spv::Decoration::Location, static_cast(location)); output_front_color = id; } + if (info.stores.AnyComponent(IR::Attribute::ColorBackDiffuseR)) { + const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); + previous_unused_location = location; + used_locations.set(location); + const Id id{DefineOutput(*this, F32[4], invocations)}; + Decorate(id, spv::Decoration::Location, static_cast(location)); + output_back_color = id; + } for (size_t index = 0; index < NUM_FIXEDFNCTEXTURE; ++index) { if (info.stores.AnyComponent(IR::Attribute::FixedFncTexture0S + index * 4)) { const size_t location = -- cgit v1.2.3 From 92bebecf4632fb5435d74a77d45bf56535eb85e4 Mon Sep 17 00:00:00 2001 From: vonchenplus Date: Tue, 26 Oct 2021 23:09:44 +0800 Subject: Support gl_FrontSecondaryColor attribute --- src/shader_recompiler/backend/spirv/emit_context.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'src/shader_recompiler/backend/spirv/emit_context.cpp') diff --git a/src/shader_recompiler/backend/spirv/emit_context.cpp b/src/shader_recompiler/backend/spirv/emit_context.cpp index 9d84c4fc6..7726bc9c6 100644 --- a/src/shader_recompiler/backend/spirv/emit_context.cpp +++ b/src/shader_recompiler/backend/spirv/emit_context.cpp @@ -1286,6 +1286,14 @@ void EmitContext::DefineInputs(const IR::Program& program) { Decorate(id, spv::Decoration::Location, location); input_front_color = id; } + if (loads.AnyComponent(IR::Attribute::ColorFrontSpecularR)) { + const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); + previous_unused_location = location; + used_locations.set(location); + const Id id{DefineInput(*this, F32[4], true)}; + Decorate(id, spv::Decoration::Location, location); + input_front_secondary_color = id; + } if (loads.AnyComponent(IR::Attribute::ColorBackDiffuseR)) { const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); previous_unused_location = location; @@ -1371,6 +1379,14 @@ void EmitContext::DefineOutputs(const IR::Program& program) { Decorate(id, spv::Decoration::Location, static_cast(location)); output_front_color = id; } + if (info.stores.AnyComponent(IR::Attribute::ColorFrontSpecularR)) { + const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); + previous_unused_location = location; + used_locations.set(location); + const Id id{DefineOutput(*this, F32[4], invocations)}; + Decorate(id, spv::Decoration::Location, static_cast(location)); + output_front_secondary_color = id; + } if (info.stores.AnyComponent(IR::Attribute::ColorBackDiffuseR)) { const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); previous_unused_location = location; -- cgit v1.2.3 From 36c21ff6cbffd55ba9314314ee8f414181fd4f9b Mon Sep 17 00:00:00 2001 From: vonchenplus Date: Tue, 26 Oct 2021 23:14:40 +0800 Subject: Support gl_BackSecondaryColor attribute --- src/shader_recompiler/backend/spirv/emit_context.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'src/shader_recompiler/backend/spirv/emit_context.cpp') diff --git a/src/shader_recompiler/backend/spirv/emit_context.cpp b/src/shader_recompiler/backend/spirv/emit_context.cpp index 7726bc9c6..d60ad139d 100644 --- a/src/shader_recompiler/backend/spirv/emit_context.cpp +++ b/src/shader_recompiler/backend/spirv/emit_context.cpp @@ -1302,6 +1302,14 @@ void EmitContext::DefineInputs(const IR::Program& program) { Decorate(id, spv::Decoration::Location, location); input_back_color = id; } + if (loads.AnyComponent(IR::Attribute::ColorBackSpecularR)) { + const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); + previous_unused_location = location; + used_locations.set(location); + const Id id{DefineInput(*this, F32[4], true)}; + Decorate(id, spv::Decoration::Location, location); + input_back_secondary_color = id; + } for (size_t index = 0; index < NUM_FIXEDFNCTEXTURE; ++index) { if (loads.AnyComponent(IR::Attribute::FixedFncTexture0S + index * 4)) { const size_t location = @@ -1395,6 +1403,14 @@ void EmitContext::DefineOutputs(const IR::Program& program) { Decorate(id, spv::Decoration::Location, static_cast(location)); output_back_color = id; } + if (info.stores.AnyComponent(IR::Attribute::ColorBackSpecularR)) { + const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); + previous_unused_location = location; + used_locations.set(location); + const Id id{DefineOutput(*this, F32[4], invocations)}; + Decorate(id, spv::Decoration::Location, static_cast(location)); + output_back_secondary_color = id; + } for (size_t index = 0; index < NUM_FIXEDFNCTEXTURE; ++index) { if (info.stores.AnyComponent(IR::Attribute::FixedFncTexture0S + index * 4)) { const size_t location = -- cgit v1.2.3 From 49f9a442356d582d31832e79098fd6db22f0f4c3 Mon Sep 17 00:00:00 2001 From: vonchenplus Date: Sun, 31 Oct 2021 22:02:05 +0800 Subject: Support gl_FogFragCoord attribute --- .../backend/spirv/emit_context.cpp | 85 +++++++++++----------- 1 file changed, 41 insertions(+), 44 deletions(-) (limited to 'src/shader_recompiler/backend/spirv/emit_context.cpp') diff --git a/src/shader_recompiler/backend/spirv/emit_context.cpp b/src/shader_recompiler/backend/spirv/emit_context.cpp index d60ad139d..386c14ce5 100644 --- a/src/shader_recompiler/backend/spirv/emit_context.cpp +++ b/src/shader_recompiler/backend/spirv/emit_context.cpp @@ -430,10 +430,12 @@ Id DescType(EmitContext& ctx, Id sampled_type, Id pointer_type, u32 count) { } } -size_t FindNextUnusedLocation(const std::bitset& used_locations, - size_t start_offset) { +size_t FindAndSetNextUnusedLocation(std::bitset& used_locations, + size_t& start_offset) { for (size_t location = start_offset; location < used_locations.size(); ++location) { if (!used_locations.test(location)) { + start_offset = location; + used_locations.set(location); return location; } } @@ -1279,45 +1281,40 @@ void EmitContext::DefineInputs(const IR::Program& program) { } size_t previous_unused_location = 0; if (loads.AnyComponent(IR::Attribute::ColorFrontDiffuseR)) { - const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, location); + Decorate(id, spv::Decoration::Location, + FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); input_front_color = id; } if (loads.AnyComponent(IR::Attribute::ColorFrontSpecularR)) { - const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, location); + Decorate(id, spv::Decoration::Location, + FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); input_front_secondary_color = id; } if (loads.AnyComponent(IR::Attribute::ColorBackDiffuseR)) { - const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, location); + Decorate(id, spv::Decoration::Location, + FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); input_back_color = id; } if (loads.AnyComponent(IR::Attribute::ColorBackSpecularR)) { - const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, location); + Decorate(id, spv::Decoration::Location, + FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); input_back_secondary_color = id; } + if (loads.AnyComponent(IR::Attribute::FogCoordinate)) { + const Id id{DefineInput(*this, F32[4], true)}; + Decorate(id, spv::Decoration::Location, + FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); + input_fog_frag_coord = id; + } for (size_t index = 0; index < NUM_FIXEDFNCTEXTURE; ++index) { if (loads.AnyComponent(IR::Attribute::FixedFncTexture0S + index * 4)) { - const size_t location = - FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, location); + Decorate(id, spv::Decoration::Location, + FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); input_fixed_fnc_textures[index] = id; } } @@ -1380,45 +1377,45 @@ void EmitContext::DefineOutputs(const IR::Program& program) { } size_t previous_unused_location = 0; if (info.stores.AnyComponent(IR::Attribute::ColorFrontDiffuseR)) { - const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, static_cast(location)); + Decorate(id, spv::Decoration::Location, + static_cast( + FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); output_front_color = id; } if (info.stores.AnyComponent(IR::Attribute::ColorFrontSpecularR)) { - const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, static_cast(location)); + Decorate(id, spv::Decoration::Location, + static_cast( + FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); output_front_secondary_color = id; } if (info.stores.AnyComponent(IR::Attribute::ColorBackDiffuseR)) { - const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, static_cast(location)); + Decorate(id, spv::Decoration::Location, + static_cast( + FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); output_back_color = id; } if (info.stores.AnyComponent(IR::Attribute::ColorBackSpecularR)) { - const size_t location = FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, static_cast(location)); + Decorate(id, spv::Decoration::Location, + static_cast( + FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); output_back_secondary_color = id; } + if (info.stores.AnyComponent(IR::Attribute::FogCoordinate)) { + const Id id{DefineOutput(*this, F32[4], invocations)}; + Decorate(id, spv::Decoration::Location, + static_cast( + FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); + output_fog_frag_coord = id; + } for (size_t index = 0; index < NUM_FIXEDFNCTEXTURE; ++index) { if (info.stores.AnyComponent(IR::Attribute::FixedFncTexture0S + index * 4)) { - const size_t location = - FindNextUnusedLocation(used_locations, previous_unused_location); - previous_unused_location = location; - used_locations.set(location); const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, location); + Decorate(id, spv::Decoration::Location, + FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); output_fixed_fnc_textures[index] = id; } } -- cgit v1.2.3 From f2a420424546fbc031594c5927b553b9d928b3a4 Mon Sep 17 00:00:00 2001 From: Feng Chen Date: Mon, 1 Nov 2021 12:00:13 +0800 Subject: Simply legacy attribute implement --- .../backend/spirv/emit_context.cpp | 148 +++++++++++++-------- 1 file changed, 95 insertions(+), 53 deletions(-) (limited to 'src/shader_recompiler/backend/spirv/emit_context.cpp') diff --git a/src/shader_recompiler/backend/spirv/emit_context.cpp b/src/shader_recompiler/backend/spirv/emit_context.cpp index 386c14ce5..3c84e6466 100644 --- a/src/shader_recompiler/backend/spirv/emit_context.cpp +++ b/src/shader_recompiler/backend/spirv/emit_context.cpp @@ -441,6 +441,22 @@ size_t FindAndSetNextUnusedLocation(std::bitset& used_location } throw RuntimeError("Unable to get an unused location for legacy attribute"); } + +Id DefineLegacyInput(EmitContext& ctx, std::bitset& used_locations, + size_t& start_offset) { + const Id id{DefineInput(ctx, ctx.F32[4], true)}; + const size_t location = FindAndSetNextUnusedLocation(used_locations, start_offset); + ctx.Decorate(id, spv::Decoration::Location, location); + return id; +} + +Id DefineLegacyOutput(EmitContext& ctx, std::bitset& used_locations, + size_t& start_offset, std::optional invocations) { + const Id id{DefineOutput(ctx, ctx.F32[4], invocations)}; + const size_t location = FindAndSetNextUnusedLocation(used_locations, start_offset); + ctx.Decorate(id, spv::Decoration::Location, location); + return id; +} } // Anonymous namespace void VectorTypes::Define(Sirit::Module& sirit_ctx, Id base_type, std::string_view name) { @@ -522,6 +538,64 @@ Id EmitContext::BitOffset16(const IR::Value& offset) { return OpBitwiseAnd(U32[1], OpShiftLeftLogical(U32[1], Def(offset), Const(3u)), Const(16u)); } +Id EmitContext::InputLegacyAttribute(IR::Attribute attribute) { + if (attribute >= IR::Attribute::ColorFrontDiffuseR && + attribute <= IR::Attribute::ColorFrontDiffuseA) { + return input_front_color; + } + if (attribute >= IR::Attribute::ColorFrontSpecularR && + attribute <= IR::Attribute::ColorFrontSpecularA) { + return input_front_secondary_color; + } + if (attribute >= IR::Attribute::ColorBackDiffuseR && + attribute <= IR::Attribute::ColorBackDiffuseA) { + return input_back_color; + } + if (attribute >= IR::Attribute::ColorBackSpecularR && + attribute <= IR::Attribute::ColorBackSpecularA) { + return input_back_secondary_color; + } + if (attribute == IR::Attribute::FogCoordinate) { + return input_fog_frag_coord; + } + if (attribute >= IR::Attribute::FixedFncTexture0S && + attribute <= IR::Attribute::FixedFncTexture9Q) { + u32 index = + (static_cast(attribute) - static_cast(IR::Attribute::FixedFncTexture0S)) / 4; + return input_fixed_fnc_textures[index]; + } + throw InvalidArgument("Attribute is not legacy attribute {}", attribute); +} + +Id EmitContext::OutputLegacyAttribute(IR::Attribute attribute) { + if (attribute >= IR::Attribute::ColorFrontDiffuseR && + attribute <= IR::Attribute::ColorFrontDiffuseA) { + return output_front_color; + } + if (attribute >= IR::Attribute::ColorFrontSpecularR && + attribute <= IR::Attribute::ColorFrontSpecularA) { + return output_front_secondary_color; + } + if (attribute >= IR::Attribute::ColorBackDiffuseR && + attribute <= IR::Attribute::ColorBackDiffuseA) { + return output_back_color; + } + if (attribute >= IR::Attribute::ColorBackSpecularR && + attribute <= IR::Attribute::ColorBackSpecularA) { + return output_back_secondary_color; + } + if (attribute == IR::Attribute::FogCoordinate) { + return output_fog_frag_coord; + } + if (attribute >= IR::Attribute::FixedFncTexture0S && + attribute <= IR::Attribute::FixedFncTexture9Q) { + u32 index = + (static_cast(attribute) - static_cast(IR::Attribute::FixedFncTexture0S)) / 4; + return output_fixed_fnc_textures[index]; + } + throw InvalidArgument("Attribute is not legacy attribute {}", attribute); +} + void EmitContext::DefineCommonTypes(const Info& info) { void_id = TypeVoid(); @@ -1281,41 +1355,26 @@ void EmitContext::DefineInputs(const IR::Program& program) { } size_t previous_unused_location = 0; if (loads.AnyComponent(IR::Attribute::ColorFrontDiffuseR)) { - const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, - FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); - input_front_color = id; + input_front_color = DefineLegacyInput(*this, used_locations, previous_unused_location); } if (loads.AnyComponent(IR::Attribute::ColorFrontSpecularR)) { - const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, - FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); - input_front_secondary_color = id; + input_front_secondary_color = + DefineLegacyInput(*this, used_locations, previous_unused_location); } if (loads.AnyComponent(IR::Attribute::ColorBackDiffuseR)) { - const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, - FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); - input_back_color = id; + input_back_color = DefineLegacyInput(*this, used_locations, previous_unused_location); } if (loads.AnyComponent(IR::Attribute::ColorBackSpecularR)) { - const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, - FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); - input_back_secondary_color = id; + input_back_secondary_color = + DefineLegacyInput(*this, used_locations, previous_unused_location); } if (loads.AnyComponent(IR::Attribute::FogCoordinate)) { - const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, - FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); - input_fog_frag_coord = id; + input_fog_frag_coord = DefineLegacyInput(*this, used_locations, previous_unused_location); } for (size_t index = 0; index < NUM_FIXEDFNCTEXTURE; ++index) { if (loads.AnyComponent(IR::Attribute::FixedFncTexture0S + index * 4)) { - const Id id{DefineInput(*this, F32[4], true)}; - Decorate(id, spv::Decoration::Location, - FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); - input_fixed_fnc_textures[index] = id; + input_fixed_fnc_textures[index] = + DefineLegacyInput(*this, used_locations, previous_unused_location); } } if (stage == Stage::TessellationEval) { @@ -1377,46 +1436,29 @@ void EmitContext::DefineOutputs(const IR::Program& program) { } size_t previous_unused_location = 0; if (info.stores.AnyComponent(IR::Attribute::ColorFrontDiffuseR)) { - const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, - static_cast( - FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); - output_front_color = id; + output_front_color = + DefineLegacyOutput(*this, used_locations, previous_unused_location, invocations); } if (info.stores.AnyComponent(IR::Attribute::ColorFrontSpecularR)) { - const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, - static_cast( - FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); - output_front_secondary_color = id; + output_front_secondary_color = + DefineLegacyOutput(*this, used_locations, previous_unused_location, invocations); } if (info.stores.AnyComponent(IR::Attribute::ColorBackDiffuseR)) { - const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, - static_cast( - FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); - output_back_color = id; + output_back_color = + DefineLegacyOutput(*this, used_locations, previous_unused_location, invocations); } if (info.stores.AnyComponent(IR::Attribute::ColorBackSpecularR)) { - const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, - static_cast( - FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); - output_back_secondary_color = id; + output_back_secondary_color = + DefineLegacyOutput(*this, used_locations, previous_unused_location, invocations); } if (info.stores.AnyComponent(IR::Attribute::FogCoordinate)) { - const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, - static_cast( - FindAndSetNextUnusedLocation(used_locations, previous_unused_location))); - output_fog_frag_coord = id; + output_fog_frag_coord = + DefineLegacyOutput(*this, used_locations, previous_unused_location, invocations); } for (size_t index = 0; index < NUM_FIXEDFNCTEXTURE; ++index) { if (info.stores.AnyComponent(IR::Attribute::FixedFncTexture0S + index * 4)) { - const Id id{DefineOutput(*this, F32[4], invocations)}; - Decorate(id, spv::Decoration::Location, - FindAndSetNextUnusedLocation(used_locations, previous_unused_location)); - output_fixed_fnc_textures[index] = id; + output_fixed_fnc_textures[index] = + DefineLegacyOutput(*this, used_locations, previous_unused_location, invocations); } } switch (stage) { -- cgit v1.2.3