From c41451af75520a19b050347bb9c267b69773ff0a Mon Sep 17 00:00:00 2001 From: lat9nq <22451773+lat9nq@users.noreply.github.com> Date: Wed, 2 Jun 2021 15:05:45 -0400 Subject: yuzu qt: Revert some usages of string_view Causes a heap-use-after free reported by AddressSanitizer. This makes use of std::filesystem::path, but due to that we have to use their string() function which may not work for all characters. --- src/yuzu/configuration/config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/yuzu/configuration/config.h') diff --git a/src/yuzu/configuration/config.h b/src/yuzu/configuration/config.h index 114a2eaa7..ce3355588 100644 --- a/src/yuzu/configuration/config.h +++ b/src/yuzu/configuration/config.h @@ -22,7 +22,7 @@ public: InputProfile, }; - explicit Config(std::string_view config_name = "qt-config", + explicit Config(const std::string& config_name = "qt-config", ConfigType config_type = ConfigType::GlobalConfig); ~Config(); @@ -45,7 +45,7 @@ public: static const std::array default_hotkeys; private: - void Initialize(std::string_view config_name); + void Initialize(const std::string& config_name); void ReadValues(); void ReadPlayerValue(std::size_t player_index); -- cgit v1.2.3