From c03fb00ac142e27ba8d7e7cc1dde0539375b7d96 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sat, 25 May 2019 03:53:41 -0400 Subject: configure_hotkeys: Remove unused EmitHotkeysChanged() 1. This is something that should be solely emitted by the hotkey dialog itself 2. This is functionally unused, given there's nothing listening for the signal. --- src/yuzu/configuration/configure_hotkeys.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/yuzu/configuration/configure_hotkeys.h') diff --git a/src/yuzu/configuration/configure_hotkeys.h b/src/yuzu/configuration/configure_hotkeys.h index 73fb8a175..1bbe64114 100644 --- a/src/yuzu/configuration/configure_hotkeys.h +++ b/src/yuzu/configuration/configure_hotkeys.h @@ -24,8 +24,6 @@ public: void applyConfiguration(HotkeyRegistry& registry); void retranslateUi(); - void EmitHotkeysChanged(); - /** * Populates the hotkey list widget using data from the provided registry. * Called everytime the Configure dialog is opened. @@ -33,9 +31,6 @@ public: */ void Populate(const HotkeyRegistry& registry); -signals: - void HotkeysChanged(QList new_key_list); - private: void Configure(QModelIndex index); bool IsUsedKey(QKeySequence key_sequence) const; -- cgit v1.2.3 From ef3c0f54d0cdfc3a4a24daac93ecc65a4359b0df Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sat, 25 May 2019 04:03:15 -0400 Subject: configure_hotkeys: Move conflict detection logic to IsUsedKey() We don't need to extract the entire set of hotkeys into a list and then iterate through it. We can traverse the list and early-exit if we're able to. --- src/yuzu/configuration/configure_hotkeys.h | 1 - 1 file changed, 1 deletion(-) (limited to 'src/yuzu/configuration/configure_hotkeys.h') diff --git a/src/yuzu/configuration/configure_hotkeys.h b/src/yuzu/configuration/configure_hotkeys.h index 1bbe64114..e77d73c35 100644 --- a/src/yuzu/configuration/configure_hotkeys.h +++ b/src/yuzu/configuration/configure_hotkeys.h @@ -34,7 +34,6 @@ public: private: void Configure(QModelIndex index); bool IsUsedKey(QKeySequence key_sequence) const; - QList GetUsedKeyList() const; std::unique_ptr ui; -- cgit v1.2.3